Skip to content

NIAD-3401: DUMMY instances replacement in DiagnosticReportMapper #1376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ORybak5 merged 5 commits into from
Oct 23, 2025
Merged

NIAD-3401: DUMMY instances replacement in DiagnosticReportMapper #1376

ORybak5 merged 5 commits into from
Oct 23, 2025

Conversation

@ORybak5
Copy link
Contributor

@ORybak5 ORybak5 commented Oct 22, 2025 •
edited
Loading

What

DUMMY instances replacement in DiagnosticReportMapper

Why

The usage of "DUMMY" wording looks inappropriate within the patient's record. The logic is fine and so it will be changed to "Not present" instead.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Internal change (non-breaking change with no effect on the functionality affecting end users)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated the Changelog with details of my change in the UNRELEASED section if this change will affect end users

@github-actions
Copy link

github-actions bot commented Oct 23, 2025

Looks good. All 3 mutations in this change were killed.

class surviving killed
💯uk.nhs.adaptors.gp2gp.ehr.mapper.diagnosticreport.ObservationMapper 0 2
💯uk.nhs.adaptors.gp2gp.ehr.mapper.diagnosticreport.DiagnosticReportMapper 0 1

See https://pitest.org

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 23, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ORybak5 ORybak5 marked this pull request as ready for review October 23, 2025 13:36
@ORybak5 ORybak5 requested a review from a team as a code owner October 23, 2025 13:36
@chiaramapellimt
Copy link
Contributor

chiaramapellimt commented Oct 23, 2025

I assume the move from 'dummy' to 'not_present' has been agreed upon before, otherwise LGTM

@ORybak5 ORybak5 merged commit cc14997 into main Oct 23, 2025
15 checks passed
@ORybak5 ORybak5 deleted the NIAD-3401 branch October 23, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chiaramapellimt chiaramapellimt chiaramapellimt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ORybak5 @chiaramapellimt