Skip to content

Commit 0fd0815

Browse files
authored
Merge pull request #156 from NHSDigital/PPHA-263-add-input-suffixes-to-weight-page
PPHA-263: add input suffixes to weight page
2 parents a884be6 + ce7eae5 commit 0fd0815

File tree

6 files changed

+87
-4
lines changed

6 files changed

+87
-4
lines changed

lung_cancer_screening/nhsuk_forms/imperial_weight_form.py renamed to lung_cancer_screening/nhsuk_forms/imperial_weight_field.py

File renamed without changes.

lung_cancer_screening/nhsuk_forms/jinja2/imperial-weight-input.jinja

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,8 @@
3131
"name": field.html_name + "_0",
3232
"value": field.subwidgets.0.data.value,
3333
"classes": "nhsuk-input--width-2" + field_error_classes,
34-
"type": "number"
34+
"type": "number",
35+
"suffix": "st"
3536
}) }}
3637
</div>
3738

@@ -46,7 +47,8 @@
4647
"name": field.html_name + "_1",
4748
"value": field.subwidgets.1.data.value,
4849
"classes": "nhsuk-input--width-2" + field_error_classes,
49-
"type": "number"
50+
"type": "number",
51+
"suffix": "lb"
5052
}) }}
5153
</div>
5254
</div>
Lines changed: 40 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,40 @@
1+
from django.test import TestCase
2+
from django.forms import Form
3+
from ...imperial_height_field import ImperialHeightField
4+
5+
6+
class TestImperialHeightField(TestCase):
7+
def test_renders_nhs_input(self):
8+
class TestForm(Form):
9+
field = ImperialHeightField(label="Abc")
10+
11+
self.assertHTMLEqual(
12+
TestForm()["field"].as_field_group(),
13+
"""
14+
<div id="field" class="multi-field-input nhsuk-form-group">
15+
<div class="multi-field-input__item">
16+
<div class="nhsuk-form-group">
17+
<label class="nhsuk-label" for="id_field_0">
18+
Feet
19+
</label>
20+
<div class="nhsuk-input__wrapper">
21+
<input class="nhsuk-input nhsuk-input--width-4" id="id_field_0" name="field_0" type="number">
22+
<div class="nhsuk-input__suffix" aria-hidden="true">ft</div>
23+
</div>
24+
</div>
25+
</div>
26+
27+
<div class="multi-field-input__item">
28+
<div class="nhsuk-form-group">
29+
<label class="nhsuk-label" for="id_field_1">
30+
Inches
31+
</label>
32+
<div class="nhsuk-input__wrapper">
33+
<input class="nhsuk-input nhsuk-input--width-4" id="id_field_1" name="field_1" type="number">
34+
<div class="nhsuk-input__suffix" aria-hidden="true">in</div>
35+
</div>
36+
</div>
37+
</div>
38+
</div>
39+
""",
40+
)
Lines changed: 40 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,40 @@
1+
from django.test import TestCase
2+
from django.forms import Form
3+
from ...imperial_weight_field import ImperialWeightField
4+
5+
6+
class TestImperialWeightField(TestCase):
7+
def test_renders_nhs_input(self):
8+
class TestForm(Form):
9+
field = ImperialWeightField(label="Abc")
10+
11+
self.assertHTMLEqual(
12+
TestForm()["field"].as_field_group(),
13+
"""
14+
<div id="field" class="multi-field-input nhsuk-form-group">
15+
<div class="multi-field-input__item">
16+
<div class="nhsuk-form-group">
17+
<label class="nhsuk-label nhsuk-fieldset__legend--m" for="id_field_0">
18+
Stone
19+
</label>
20+
<div class="nhsuk-input__wrapper">
21+
<input class="nhsuk-input nhsuk-input--width-2" id="id_field_0" name="field_0" type="number">
22+
<div class="nhsuk-input__suffix" aria-hidden="true">st</div>
23+
</div>
24+
</div>
25+
</div>
26+
27+
<div class="multi-field-input__item">
28+
<div class="nhsuk-form-group">
29+
<label class="nhsuk-label nhsuk-fieldset__legend--m" for="id_field_1">
30+
Pounds
31+
</label>
32+
<div class="nhsuk-input__wrapper">
33+
<input class="nhsuk-input nhsuk-input--width-2" id="id_field_1" name="field_1" type="number">
34+
<div class="nhsuk-input__suffix" aria-hidden="true">lb</div>
35+
</div>
36+
</div>
37+
</div>
38+
</div>
39+
""",
40+
)

lung_cancer_screening/questions/forms/imperial_weight_form.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
from django import forms
22

3-
from ...nhsuk_forms.imperial_weight_form import ImperialWeightField
3+
from ...nhsuk_forms.imperial_weight_field import ImperialWeightField
44
from ..models.response_set import ResponseSet
55

66
class ImperialWeightForm(forms.ModelForm):

lung_cancer_screening/questions/forms/metric_weight_form.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,8 @@ def __init__(self, *args, **kwargs):
1616
required=True,
1717
error_messages={
1818
'required': 'Enter your weight',
19-
}
19+
},
20+
suffix="kg"
2021
)
2122
def clean_weight_metric(self):
2223
return self.cleaned_data['weight_metric'] * 10

0 commit comments

Comments
 (0)