Fix broken tests

Author: miriam-z

lung_cancer_screening/core/tests/acceptance/test_cannot_change_answers_after_submission.py

@@ -49,7 +49,7 @@ def test_cannot_change_responses_once_checked_and_submitted(self):
         fill_in_and_submit_gender(page, "Male")
         fill_in_and_submit_ethnicity(page, "White")
         page.click("text=Continue") # education
-        fill_in_and_submit_respiratory_conditions(page, "None of the above")
+        fill_in_and_submit_respiratory_conditions(page, "No, I have not had any of these respiratory conditions")
         fill_in_and_submit_asbestos_exposure(page, "No")
         page.click("text=Continue") # cancer diagnosis
         page.click("text=Continue") # family history

lung_cancer_screening/questions/jinja2/responses.jinja

@@ -24,7 +24,7 @@
         <li>Which of these best describes you? {{ response_set.get_gender_display() }}</li>
         <li>What is your ethnic background? {{ response_set.get_ethnicity_display() }}</li>
         <li>Have you ever worked in a job where you might have been exposed to asbestos? {{ "Yes" if response_set.asbestos_exposure else "No" }}</li>
-        <li>Have you ever been diagnosed with any of the following respiratory conditions? {{ response_set.respiratory_conditions }}</li>
+        <li>Have you ever been diagnosed with any of the following respiratory conditions? {{ response_set.formatted_respiratory_conditions }}</li>
       </ul>
       <form action="{{ request.path }}" method="post">
         {{ csrf_input }}

lung_cancer_screening/questions/models/response_set.py

@@ -163,3 +163,14 @@ def formatted_weight(self):
             value = Decimal(self.weight_imperial)
             return f"{value // 14} stone {value % 14} pounds"
 
+    @property
+    def formatted_respiratory_conditions(self):
+        if not self.respiratory_conditions:
+            return None
+        # Get the display values for each code
+        display_values = [
+            RespiratoryConditionValues(code).label
+            for code in self.respiratory_conditions
+        ]
+        return ", ".join(display_values)
+

lung_cancer_screening/questions/tests/unit/views/test_respiratory_conditions.py

@@ -37,7 +37,7 @@ def test_get_contains_the_correct_form_fields(self):
         self.assertContains(response, "Chronic bronchitis")
         self.assertContains(response, "Tuberculosis (TB)")
         self.assertContains(response, "Chronic obstructive pulmonary disease (COPD)")
-        self.assertContains(response, "None of the above")
+        self.assertContains(response, "No, I have not had any of these respiratory conditions")
 
     def test_post_redirects_if_the_participant_does_not_exist(self):
         session = self.client.session