PPHA-525: Ensure user has to change periods stopped smoking if changeing age started smoking

Author: Themitchell

.gitleaksignore

@@ -29,8 +29,8 @@ infrastructure/bootstrap/main.bicep:generic-api-key:32
 infrastructure/bootstrap/modules/storage.bicep:generic-api-key:59
 infrastructure/bootstrap/modules/keyVault.bicep:generic-api-key:10
 infrastructure/bootstrap/modules/storage.bicep:generic-api-key:59
-infrastructure/terraform/hub/data.tf:generic-api-key:18
-infrastructure/terraform/hub/data.tf:generic-api-key:22
+infrastructure/terraform/hub/data.tf:generic-api-key:19
+infrastructure/terraform/hub/data.tf:generic-api-key:23
 infrastructure/terraform/resource_group_init/core.bicep:generic-api-key:11
 infrastructure/terraform/resource_group_init/keyVault.bicep:generic-api-key:10
 infrastructure/terraform/resource_group_init/main.bicep:generic-api-key:30

docs/diagrams/PlantUML/data_flow_diagram.puml

@@ -0,0 +1,21 @@
+@startuml
+
+actor "Participant" as Participant
+entity "LCS App" as LCS_App
+entity "NHS Login" as NHS_Login
+entity "In Health" as InHealth
+entity "NHS Incentivisation system" as NHS_Incentivisation_System
+
+' Date flow into LCS App
+Participant -> LCS_App
+LCS_App -> NHS_Login
+NHS_Login -> LCS_App: Participant logs in and shares profile, email address and NHS Number (scopes "openid profile email") with LCS app
+Participant -> LCS_App: Completes questionnaire
+
+' Data flow from LCS App to In Health
+LCS_App -> InHealth: Completed digital participant NHS Numbers shared with InHealth
+InHealth -> LCS_App: InHealth share completed telephone responses corresponding to digital NHS number responses
+
+' Data flow from LCS App to NHS Incentivisation system
+LCS_App -> NHS_Incentivisation_System: Eligible participant's email addresses shared with NHS Incentivisation system
+NHS_Incentivisation_System -> Participant: Participant is incentivised

docs/diagrams/PlantUML/user_flow_diagram_returning_user.puml

@@ -0,0 +1,20 @@
+@startuml
+
+entity "In Health" as InHealth
+actor "Participant" as Participant
+entity "LCS App" as LCS_App
+entity "NHS Login" as NHS_Login
+entity "NHS Incentivisation system" as NHS_Incentivisation_System
+
+' Participant flow
+InHealth -> Participant: Initial contact via letter or SMS
+Participant -> LCS_App
+LCS_App -> NHS_Login: Participant clicks start and is redirected to NHS Login
+NHS_Login -> LCS_App: NHS Login shares profile, email address and NHS Number (scopes "openid profile email")
+Participant -> LCS_App: Completes questionnaire and submits
+
+' In Health flow
+LCS_App -> InHealth: Completed digital participant NHS Numbers shared with InHealth
+InHealth -> LCS_App: In Health shared completed telephone responses corresponding to digital NHS number responses
+LCS_App -> NHS_Incentivisation_System: Eligible participant's email addresses shared with NHS Incentivisation system
+NHS_Incentivisation_System -> Participant: Participant is incentivised

features/age_when_started_smoking.feature

@@ -40,5 +40,4 @@ Feature: Age when started smoking
     Then I am on "/age-when-started-smoking?change=True"
     And I see "18" filled in for "How old were you when you started smoking?"
     When I fill in "How old were you when you started smoking?" as "22" and submit
-    Then I am on "/check-your-answers"
-    And I see "22" as a response to "Age you started smoking" under "Smoking history"
+    Then I am on "/periods-when-you-stopped-smoking?change=True"

features/periods_when_you_stopped_smoking.feature

@@ -22,7 +22,7 @@ Feature: Periods when you stopped smoking page
     And I have answered questions showing I am eligible
     And I have answered questions showing I have smoked for "10" years
     When I go to "/periods-when-you-stopped-smoking"
-    Then I see a back link to "/family-history-lung-cancer"
+    Then I see a back link to "/age-when-started-smoking"
     When I check "Yes"
     And I fill in "Enter the total number of years you stopped smoking for" with "1"
     And I submit the form

features/steps/accessibility_steps.py

@@ -9,5 +9,4 @@ def then_there_are_no_accessibility_violations(context):
         f"Found the following accessibility violations: \n"
         f"{axe_results.generate_snapshot()}"
     )
-    print(axe_results)
     assert axe_results.violations_count == 0, violations_msg

features/steps/preflight_steps.py

@@ -1,6 +1,12 @@
 from behave import given
-from datetime import datetime
-from dateutil.relativedelta import relativedelta
+
+from features.steps.form_steps import (
+    when_i_fill_in_and_submit_my_date_of_birth_as_x_years_ago,
+    when_i_submit_the_form,
+    when_i_check_label,
+    when_i_fill_in_label_with_value
+)
+
 from lung_cancer_screening.questions.tests.factories.have_you_ever_smoked_response_factory import (
     ResponseSetFactory,
 )
@@ -23,6 +29,7 @@ def get_or_create_response_set(context):
         )
     )
 
+
 @given('I have answered have you ever smoked with an eligible response')
 def given_i_have_answered_have_your_ever_smoked_with_an_eligible_response(context):
     response_set = get_or_create_response_set(context)
@@ -57,3 +64,16 @@ def given_i_have_answered_questions_showing_i_have_smoked_for_years_years(contex
         response_set=response_set,
         value=response_set.date_of_birth_response.age_in_years() - int(years),
     )
+
+@given('I have answered questions showing I am aged "{years}" years old')
+def given_i_have_answered_questions_showing_i_am_aged_60_years_old(context, years):
+    context.page.goto(f"{context.live_server_url}/date-of-birth")
+    when_i_fill_in_and_submit_my_date_of_birth_as_x_years_ago(context, years)
+
+
+@given('I have answered questions showing I stopped smoking for "{years}" years')
+def given_i_have_answered_questions_showing_i_stopped_smoking_for_years_years(context, years):
+    context.page.goto(f"{context.live_server_url}/periods-when-you-stopped-smoking")
+    when_i_check_label(context, "Yes")
+    when_i_fill_in_label_with_value(context, "Enter the total number of years you stopped smoking for", years)
+    when_i_submit_the_form(context)

lung_cancer_screening/questions/forms/age_when_started_smoking_form.py

@@ -28,3 +28,18 @@ def __init__(self, *args, **kwargs):
     class Meta:
         model = AgeWhenStartedSmokingResponse
         fields = ["value"]
+
+
+    def save(self, commit=True):
+        instance = super(AgeWhenStartedSmokingForm, self).save(commit=False)
+
+        self._cleanup_periods_stopped_smoking_if_value_changed()
+
+        if commit:
+            instance.save()
+
+        return instance
+
+    def _cleanup_periods_stopped_smoking_if_value_changed(self):
+        if 'value' in self.changed_data and hasattr(self.instance.response_set, 'periods_when_you_stopped_smoking_response'):
+            self.instance.response_set.periods_when_you_stopped_smoking_response.delete()

lung_cancer_screening/questions/tests/factories/periods_when_you_stopped_smoking_response_factory.py

@@ -10,3 +10,4 @@ class Meta:
 
     response_set = factory.SubFactory(ResponseSetFactory)
     value = False
+    duration_years = None

lung_cancer_screening/questions/tests/unit/forms/test_age_when_started_smoking_form.py

@@ -8,6 +8,8 @@
 from ...factories.response_set_factory import ResponseSetFactory
 from ...factories.date_of_birth_response_factory import DateOfBirthResponseFactory
 from ....forms.age_when_started_smoking_form import AgeWhenStartedSmokingForm
+from ...factories.periods_when_you_stopped_smoking_response_factory import PeriodsWhenYouStoppedSmokingResponseFactory
+from ....models.periods_when_you_stopped_smoking_response import PeriodsWhenYouStoppedSmokingResponse
 
 
 @tag("AgeWhenStartedSmoking")
@@ -106,3 +108,43 @@ def test_is_invalid_when_age_entered_greater_than_current_age(self):
             form.errors["value"],
             ["The age you started smoking must be the same as, or less than your current age"]
         )
+
+
+    def test_deletes_periods_when_stopped_smoking_response_if_age_started_smoking_is_changed(self):
+        self.response.value = 17
+        self.response.save()
+
+        PeriodsWhenYouStoppedSmokingResponseFactory.create(
+            response_set=self.response_set,
+            value=True,
+            duration_years=self.response.years_smoked_including_stopped() - 1
+        )
+        form = AgeWhenStartedSmokingForm(
+            instance=self.response,
+            data={
+                "value": 18
+            }
+        )
+        form.save()
+
+        self.assertFalse(PeriodsWhenYouStoppedSmokingResponse.objects.filter(response_set=self.response_set).exists())
+
+
+    def test_does_not_delete_periods_when_stopped_smoking_response_if_age_started_smoking_is_not_changed(self):
+        self.response.value = 18
+        self.response.save()
+
+        PeriodsWhenYouStoppedSmokingResponseFactory.create(
+            response_set=self.response_set,
+            value=True,
+            duration_years=self.response.years_smoked_including_stopped() - 1
+        )
+        form = AgeWhenStartedSmokingForm(
+            instance=self.response,
+            data={
+                "value": 18
+            }
+        )
+        form.save()
+
+        self.assertTrue(PeriodsWhenYouStoppedSmokingResponse.objects.filter(response_set=self.response_set).exists())