PPHA-475: Ensure recall values for height and weight are re converted for display

Author: Themitchell

lung_cancer_screening/questions/forms/metric_height_form.py

@@ -9,6 +9,10 @@ class MetricHeightForm(forms.ModelForm):
     def __init__(self, *args, **kwargs):
         super().__init__(*args, **kwargs)
 
+        # Convert mm to cm for display
+        if self.instance and self.instance.height is not None:
+            self.initial['height'] = self.instance.height / 10
+
         self.fields["height"] = DecimalField(
             decimal_places=1,
             label="Centimetres",

lung_cancer_screening/questions/forms/metric_weight_form.py

@@ -9,6 +9,10 @@ class MetricWeightForm(forms.ModelForm):
     def __init__(self, *args, **kwargs):
         super().__init__(*args, **kwargs)
 
+        # Convert hundreds of grams to kg for display
+        if self.instance and self.instance.weight_metric is not None:
+            self.initial['weight_metric'] = self.instance.weight_metric / 10
+
         self.fields["weight_metric"] = DecimalField(
             decimal_places=1,
             label="Kilograms",
@@ -27,6 +31,9 @@ def __init__(self, *args, **kwargs):
     def clean_weight_metric(self):
         return self.cleaned_data['weight_metric'] * 10
 
+    def clean_weight_imperial(self):
+        return None
+
     class Meta:
         model = ResponseSet
-        fields = ['weight_metric']
+        fields = ['weight_metric', 'weight_imperial']

lung_cancer_screening/questions/tests/unit/forms/test_imperial_weight_form.py

@@ -154,3 +154,15 @@ def test_is_invalid_when_stone_over_50(self):
             form.errors["weight_imperial"],
             ["Weight must be between 4 stone and 50 stone"]
         )
+
+    def test_setting_imperial_weight_clears_metric_weight(self):
+        self.response_set.weight_metric = 705
+        form = ImperialWeightForm(
+            instance=self.response_set,
+            data={
+                "weight_imperial_0": "5",
+                "weight_imperial_1": "9"
+            }
+        )
+        form.save()
+        self.assertEqual(self.response_set.weight_metric, None)

lung_cancer_screening/questions/tests/unit/forms/test_metric_height_form.py

@@ -21,7 +21,7 @@ def test_is_valid_with_valid_input(self):
         )
         self.assertTrue(form.is_valid())
 
-    def test_converts_cm_to_mm(self):
+    def test_converts_cm_to_mm_before_saving(self):
         height = "170.4"
         form = MetricHeightForm(
             instance=self.response_set,
@@ -33,6 +33,15 @@ def test_converts_cm_to_mm(self):
         form.is_valid()
         self.assertEqual(form.cleaned_data["height"], 1704)
 
+    def test_converts_mm_to_cm_before_rendering(self):
+        self.response_set.height = 1704
+        form = MetricHeightForm(
+            instance=self.response_set
+        )
+
+        self.assertEqual(form["height"].value(), 170.4)
+
+
     def test_setting_height_clears_imperial_height(self):
         height = "170.4"
         form = MetricHeightForm(

lung_cancer_screening/questions/tests/unit/forms/test_metric_weight_form.py

@@ -20,6 +20,26 @@ def test_is_valid_with_valid_input(self):
         )
         self.assertTrue(form.is_valid())
 
+    def test_converts_kg_to_hundreds_of_grams_before_saving(self):
+        weight = "70.5"
+        form = MetricWeightForm(
+            instance=self.response_set,
+            data={
+                "weight_metric": weight
+            }
+        )
+
+        form.is_valid()
+        self.assertEqual(form.cleaned_data["weight_metric"], 705)
+
+    def test_converts_hundreds_of_grams_to_kg_before_rendering(self):
+        self.response_set.weight_metric = 705
+        form = MetricWeightForm(
+            instance=self.response_set
+        )
+
+        self.assertEqual(form["weight_metric"].value(), 70.5)
+
     def test_is_not_valid_with_invalid_input(self):
         weight = "a"
         form = MetricWeightForm(
@@ -107,3 +127,15 @@ def test_is_invalid_with_multiple_decimal_places(self):
             form.errors["weight_metric"],
             ["Kilograms must be to 1 decimal place, for example 90.2kgs"]
         )
+
+    def test_setting_metric_weight_clears_imperial_weight(self):
+        self.response_set.weight_imperial = "66"
+        form = MetricWeightForm(
+            instance=self.response_set,
+            data={
+                "weight_metric": "70.5"
+            }
+        )
+        form.save()
+        self.response_set.refresh_from_db()
+        self.assertEqual(self.response_set.weight_imperial, None)