Skip to content

Commit 5721e0b

Browse files
authored
PPHA-463 Date of birth updates (#171)
* Change date of birth page header font size * footer possible fix and devcontainer python version upping
1 parent a9a2572 commit 5721e0b

File tree

6 files changed

+23
-2
lines changed

6 files changed

+23
-2
lines changed

.devcontainer/devcontainer.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,10 @@
1616
"ghcr.io/azutake/devcontainer-features/go-packages-install:0": {
1717
"PACKAGES": "github.com/asdf-vm/asdf/cmd/[email protected]"
1818
},
19-
"ghcr.io/devcontainers/features/python:1": {},
19+
"ghcr.io/devcontainers/features/python:1": {
20+
"version": "3.14",
21+
"toolsToInstall": "flake8,autopep8,black,yapf,mypy,pydocstyle,pycodestyle,bandit,pipenv,virtualenv,pylint,poetry"
22+
},
2023
"ghcr.io/devcontainers/features/common-utils": {
2124
"installZsh": true,
2225
"installOhMyZsh": true,

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,3 +20,4 @@ lung_cancer_screening/assets/compiled/*
2020
.venv
2121
.devcontainer/ca.crt
2222
tests/TEST-*.xml
23+
node_modules
Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
footer {
2+
margin-top: auto;
3+
border-top: 4px solid #005eb8;
4+
padding: 1rem;
5+
}
6+
7+
body {
8+
display: flex;
9+
flex-direction: column;
10+
min-height: 100vh;
11+
}
12+
13+
.nhsuk-width-container {
14+
width: 100%;
15+
}

lung_cancer_screening/nhsuk_forms/jinja2/date-input.jinja

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"fieldset": {
1111
"legend": {
1212
"text": field.label,
13-
"classes": "nhsuk-fieldset__legend--m",
13+
"classes": unbound_field.label_classes if unbound_field.label_classes else "nhsuk-fieldset__legend--m",
1414
"isPageHeading": unbound_field.label_is_page_heading
1515
}
1616
} if field.label,

lung_cancer_screening/nhsuk_forms/split_date_field.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@ def __init__(self, *args, **kwargs):
6969
max_value = kwargs.pop("max_value", datetime.date.today())
7070
min_value = kwargs.pop("min_value", datetime.date(1900, 1, 1))
7171
self.label_is_page_heading = kwargs.pop("label_is_page_heading", False)
72+
self.label_classes = kwargs.pop("label_classes", "")
7273
self.hint = kwargs.pop("hint", None)
7374

7475
day_bounds_error = kwargs.get("error_messages", {}).pop("day_bounds", gettext("Day should be between 1 and 31."))

lung_cancer_screening/questions/forms/date_of_birth_form.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ def __init__(self, *args, **kwargs):
1717
require_all_fields=False,
1818
label="What is your date of birth?",
1919
label_is_page_heading=True,
20+
label_classes="nhsuk-fieldset__legend--l",
2021
hint="For example, 15 3 1965",
2122
error_messages={
2223
'required': 'Enter your date of birth',

0 commit comments

Comments
 (0)