Refactor acceptance tests into helpers

Author: Themitchell

lung_cancer_screening/core/tests/acceptance/helpers/__init__.py

@@ -0,0 +1,24 @@
+from playwright.sync_api import expect
+
+def fill_in_and_submit_participant_id(page, participant_id):
+    page.fill("input[name='participant_id']", participant_id)
+    page.click('text=Start now')
+
+
+def fill_in_and_submit_smoking_elligibility(page, smoking_status):
+    expect(page.locator("legend")).to_have_text(
+        "Have you ever smoked?")
+
+    page.get_by_label(smoking_status).check()
+
+    page.click("text=Continue")
+
+def fill_in_and_submit_date_of_birth(page, age):
+    expect(page.locator("legend")).to_have_text(
+        "What is your date of birth?")
+
+    page.get_by_label("Day").fill(str(age.day))
+    page.get_by_label("Month").fill(str(age.month))
+    page.get_by_label("Year").fill(str(age.year))
+
+    page.click("text=Continue")

lung_cancer_screening/core/tests/acceptance/helpers/user_interaction_helpers.py

@@ -3,6 +3,12 @@
 from playwright.sync_api import sync_playwright, expect
 
 
+from .helpers.user_interaction_helpers import (
+    fill_in_and_submit_participant_id,
+    fill_in_and_submit_smoking_elligibility
+)
+
+
 class TestParticipantNotSmoker(StaticLiveServerTestCase):
 
     @classmethod
@@ -24,18 +30,8 @@ def test_participant_not_smoker(self):
         page = self.browser.new_page()
         page.goto(f"{self.live_server_url}/start")
 
-        page.fill("input[name='participant_id']", participant_id)
-
-        page.click('text=Start now')
-
-        expect(page).to_have_url(f"{self.live_server_url}/have-you-ever-smoked")
-
-        expect(page.locator("legend")).to_have_text(
-            "Have you ever smoked?")
-
-        page.get_by_label('No, I have never smoked').check()
-
-        page.click("text=Continue")
+        fill_in_and_submit_participant_id(page, participant_id)
+        fill_in_and_submit_smoking_elligibility(page, 'No, I have never smoked')
 
         expect(page).to_have_url(f"{self.live_server_url}/non-smoker-exit")
 

lung_cancer_screening/core/tests/acceptance/test_cannot_change_answers_after_submission.py

@@ -4,6 +4,12 @@
 from datetime import datetime
 from dateutil.relativedelta import relativedelta
 
+from .helpers.user_interaction_helpers import (
+    fill_in_and_submit_participant_id,
+    fill_in_and_submit_smoking_elligibility,
+    fill_in_and_submit_date_of_birth
+)
+
 
 class TestParticipantOutOfAgeRange(StaticLiveServerTestCase):
 
@@ -26,32 +32,11 @@ def test_participant_out_of_age_range(self):
         page = self.browser.new_page()
         page.goto(f"{self.live_server_url}/start")
 
-        page.fill("input[name='participant_id']", participant_id)
-
-        page.click('text=Start now')
-
-        expect(page).to_have_url(
-            f"{self.live_server_url}/have-you-ever-smoked")
-
-        expect(page.locator("legend")).to_have_text(
-            "Have you ever smoked?")
-
-        page.get_by_label('Yes, I used to smoke regularly').check()
-
-        page.click("text=Continue")
-
-        expect(page).to_have_url(f"{self.live_server_url}/date-of-birth")
-
-        expect(page.locator("legend")).to_have_text(
-            "What is your date of birth?")
+        fill_in_and_submit_participant_id(page, participant_id)
+        fill_in_and_submit_smoking_elligibility(page, 'Yes, I used to smoke regularly')
 
         age = datetime.now() - relativedelta(years=20)
-
-        page.get_by_label("Day").fill(str(age.day))
-        page.get_by_label("Month").fill(str(age.month))
-        page.get_by_label("Year").fill(str(age.year))
-
-        page.click("text=Continue")
+        fill_in_and_submit_date_of_birth(page, age)
 
         expect(page).to_have_url(f"{self.live_server_url}/age-range-exit")
 

lung_cancer_screening/core/tests/acceptance/test_participant_not_smoker.py

@@ -4,6 +4,12 @@
 from datetime import datetime
 from dateutil.relativedelta import relativedelta
 
+from .helpers.user_interaction_helpers import (
+    fill_in_and_submit_participant_id,
+    fill_in_and_submit_smoking_elligibility,
+    fill_in_and_submit_date_of_birth
+)
+
 class TestQuestionnaire(StaticLiveServerTestCase):
 
     @classmethod
@@ -21,36 +27,22 @@ def tearDownClass(cls):
 
     def test_full_questionaire_user_journey(self):
         participant_id = '123'
+        smoking_status = 'Yes, I used to smoke regularly'
+        age = datetime.now() - relativedelta(years=55)
 
         page = self.browser.new_page()
         page.goto(f"{self.live_server_url}/start")
 
-        page.fill("input[name='participant_id']", participant_id)
-
-        page.click('text=Start now')
+        fill_in_and_submit_participant_id(page, participant_id)
 
         expect(page).to_have_url(
             f"{self.live_server_url}/have-you-ever-smoked")
 
-        expect(page.locator("legend")).to_have_text(
-            "Have you ever smoked?")
-
-        page.get_by_label('Yes, I used to smoke regularly').check()
-
-        page.click("text=Continue")
+        fill_in_and_submit_smoking_elligibility(page, smoking_status)
 
         expect(page).to_have_url(f"{self.live_server_url}/date-of-birth")
 
-        expect(page.locator("legend")).to_have_text(
-            "What is your date of birth?")
-
-        age = datetime.now() - relativedelta(years=55)
-
-        page.get_by_label("Day").fill(str(age.day))
-        page.get_by_label("Month").fill(str(age.month))
-        page.get_by_label("Year").fill(str(age.year))
-
-        page.click("text=Continue")
+        fill_in_and_submit_date_of_birth(page, age)
 
         expect(page).to_have_url(f"{self.live_server_url}/responses")
 

lung_cancer_screening/core/tests/acceptance/test_participant_out_of_age_range.py

@@ -2,6 +2,12 @@
 from django.contrib.staticfiles.testing import StaticLiveServerTestCase
 from playwright.sync_api import sync_playwright, expect
 
+from .helpers.user_interaction_helpers import (
+    fill_in_and_submit_participant_id,
+    fill_in_and_submit_smoking_elligibility,
+    fill_in_and_submit_date_of_birth
+)
+
 class TestQuestionnaireValidationErrors(StaticLiveServerTestCase):
 
     @classmethod
@@ -23,21 +29,8 @@ def test_full_questionaire_user_journey_with_validation_errors(self):
         page = self.browser.new_page()
         page.goto(f"{self.live_server_url}/start")
 
-        page.fill("input[name='participant_id']", participant_id)
-
-        page.click('text=Start now')
-
-        expect(page).to_have_url(
-            f"{self.live_server_url}/have-you-ever-smoked")
-
-        expect(page.locator("legend")).to_have_text(
-            "Have you ever smoked?")
-
-        page.get_by_label('Yes, I currently smoke').check()
-
-        page.click("text=Continue")
-
-        expect(page).to_have_url(f"{self.live_server_url}/date-of-birth")
+        fill_in_and_submit_participant_id(page, participant_id)
+        fill_in_and_submit_smoking_elligibility(page, 'Yes, I currently smoke')
 
         expect(page.locator("legend")).to_have_text(
             "What is your date of birth?")