Do not allow default arguments in the calculator

Author: Themitchell

lung_cancer_screening/calculators/plco.py

@@ -12,10 +12,11 @@ class Plco:
     FAMILY_HISTORY_OF_CANCER_COEFFICIENT = Decimal('0.587185')
 
     def __init__(self,
-                 age=None,
-                 bmi=None,
-                 copd_enphysema_or_chronic_bronchitis=None,
-                 personal_history_of_cancer=None, family_history_of_cancer=None):
+                 age,
+                 bmi,
+                 copd_enphysema_or_chronic_bronchitis,
+                 personal_history_of_cancer,
+                 family_history_of_cancer):
         self.age = Decimal(str(age or 0))
         self.bmi = Decimal(str(bmi or 0))
         self.copd_enphysema_or_chronic_bronchitis = copd_enphysema_or_chronic_bronchitis
@@ -31,22 +32,22 @@ def bmi_contribution_to_estimate(self):
     def copd_enphysema_or_chronic_bronchitis_contribution_to_estimate(self):
         if self.copd_enphysema_or_chronic_bronchitis is None:
             raise self.InvalidValueError(
-                "copd_enphysema_or_chronic_bronchitis must be true or false")
+                "copd_enphysema_or_chronic_bronchitis must be set")
 
         return self.copd_enphysema_or_chronic_bronchitis * self.COPD_ENPHYSEMA_OR_CHRONIC_BRONCHITIS_COEFFICIENT
 
 
     def personal_history_of_cancer_contribution_to_estimate(self):
         if self.personal_history_of_cancer is None:
             raise self.InvalidValueError(
-                "personal_history_of_cancer must be true or false")
+                "personal_history_of_cancer must be set")
 
         return self.personal_history_of_cancer * self.PERSONAL_HISTORY_OF_CANCER_COEFFICIENT
 
     def family_history_of_cancer_contribution_to_estimate(self):
         if self.family_history_of_cancer is None:
             raise self.InvalidValueError(
-                "family_history_of_cancer must be true or false")
+                "family_history_of_cancer must be set")
 
         return self.family_history_of_cancer * self.FAMILY_HISTORY_OF_CANCER_COEFFICIENT
 

lung_cancer_screening/calculators/tests/test_plco.py

@@ -4,103 +4,112 @@
 from lung_cancer_screening.calculators.plco import Plco
 
 class TestPlco(TestCase):
+    def setUp(self):
+        self.defaultArgs = {
+            "age": 62,
+            "bmi": 27,
+            "copd_enphysema_or_chronic_bronchitis": False,
+            "personal_history_of_cancer": False,
+            "family_history_of_cancer": False
+        }
+
     def test_age_in_years_contribution_to_estimate_when_age_is_none(self):
-        calculator = Plco(age=None)
+        calculator = Plco(**dict(self.defaultArgs, age=None))
         result = calculator.age_in_years_contribution_to_estimate()
 
         self.assertEqual(result, Decimal('-4.8289816'))
 
     def test_age_in_years_contribution_to_estimate_at_74(self):
-        calculator = Plco(age=74)
+        calculator = Plco(**dict(self.defaultArgs, age=74))
         result = calculator.age_in_years_contribution_to_estimate()
 
         self.assertEqual(result, Decimal('0.9346416'))
 
     def test_age_in_years_contribution_to_estimate_at_62(self):
-        calculator = Plco(age=58)
+        calculator = Plco(**dict(self.defaultArgs, age=58))
         result = calculator.age_in_years_contribution_to_estimate()
 
         self.assertEqual(result, Decimal('-0.3115472'))
 
     def test_bmi_contribution_to_estimate_when_bmi_is_none(self):
-        calculator = Plco(bmi=None)
+        calculator = Plco(**dict(self.defaultArgs, bmi=None))
         result = calculator.bmi_contribution_to_estimate()
 
         self.assertEqual(result, Decimal('0.7403238'))
 
     def test_bmi_contribution_to_estimate_when_bmi_is_23_point_5(self):
-        calculator = Plco(bmi=23.5)
+        calculator = Plco(**dict(self.defaultArgs, bmi=23.5))
         result = calculator.bmi_contribution_to_estimate()
 
         self.assertEqual(result, Decimal('0.0959679'))
 
     def test_bmi_contribution_to_estimate_when_bmi_is_a_long_decimal(self):
-        calculator = Plco(bmi="26.4749212")
+        calculator = Plco(**dict(self.defaultArgs, bmi="26.4749212"))
         result = calculator.bmi_contribution_to_estimate()
 
         self.assertEqual(result, Decimal('0.01439734564872'))
 
     def test_copd_enphysema_or_chronic_bronchitiscontribution_to_estimate_when_none(self):
-        calculator = Plco(copd_enphysema_or_chronic_bronchitis=None)
+        calculator = Plco(**dict(self.defaultArgs, copd_enphysema_or_chronic_bronchitis=None))
 
         self.assertRaises(
             Plco.InvalidValueError,
             calculator.copd_enphysema_or_chronic_bronchitis_contribution_to_estimate
         )
 
     def test_copd_enphysema_or_chronic_bronchitiscontribution_to_estimate_when_true(self):
-        calculator = Plco(copd_enphysema_or_chronic_bronchitis=True)
+        calculator = Plco(**dict(self.defaultArgs, copd_enphysema_or_chronic_bronchitis=True))
 
         result = calculator.copd_enphysema_or_chronic_bronchitis_contribution_to_estimate()
 
         self.assertEqual(result, Decimal('0.3553063'))
 
     def test_copd_enphysema_or_chronic_bronchitiscontribution_to_estimate_when_false(self):
-        calculator = Plco(copd_enphysema_or_chronic_bronchitis=False)
+        calculator = Plco(**dict(self.defaultArgs, copd_enphysema_or_chronic_bronchitis=False))
 
         result = calculator.copd_enphysema_or_chronic_bronchitis_contribution_to_estimate()
 
         self.assertEqual(result, Decimal('0'))
 
     def test_personal_history_of_cancer_contribution_to_estimate_when_none(self):
-        calculator = Plco(personal_history_of_cancer=None)
+        calculator = Plco(**dict(self.defaultArgs, personal_history_of_cancer=None))
 
         self.assertRaises(
             Plco.InvalidValueError,
             calculator.personal_history_of_cancer_contribution_to_estimate
         )
 
     def test_personal_history_of_cancer_contribution_to_estimate_when_true(self):
-        calculator = Plco(personal_history_of_cancer=True)
+        calculator = Plco(**dict(self.defaultArgs, personal_history_of_cancer=True))
 
         result = calculator.personal_history_of_cancer_contribution_to_estimate()
 
         self.assertEqual(result, Decimal('0.4589971'))
 
     def test_personal_history_of_cancer_contribution_to_estimate_when_false(self):
-        calculator = Plco(personal_history_of_cancer=False)
+        calculator = Plco(**dict(self.defaultArgs, personal_history_of_cancer=False))
 
         result = calculator.personal_history_of_cancer_contribution_to_estimate()
 
         self.assertEqual(result, Decimal('0'))
 
     def test_family_history_of_cancer_contribution_to_estimate_when_none(self):
-        calculator = Plco(family_history_of_cancer=None)
+        calculator = Plco(**dict(self.defaultArgs, family_history_of_cancer=None))
 
         self.assertRaises(
             Plco.InvalidValueError,
             calculator.family_history_of_cancer_contribution_to_estimate
         )
 
     def test_family_history_of_cancer_contribution_to_estimate_when_true(self):
-        calculator = Plco(family_history_of_cancer=True)
+        calculator = Plco(**dict(self.defaultArgs, family_history_of_cancer=True))
 
         result = calculator.family_history_of_cancer_contribution_to_estimate()
 
         self.assertEqual(result, Decimal('0.587185'))
 
     def test_family_history_of_cancer_contribution_to_estimate_when_false(self):
-        calculator = Plco(family_history_of_cancer=False)
+        calculator = Plco(**dict(self.defaultArgs, family_history_of_cancer=False))
 
         result = calculator.family_history_of_cancer_contribution_to_estimate()