Migrate not a smoker exit tests to behave

Also use imperative I statements for behave features

Author: Themitchell

.gitignore

@@ -19,3 +19,4 @@ lung_cancer_screening/assets/compiled/*
 .DS_Store
 .venv
 .devcontainer/ca.crt
+tests/TEST-*.xml

behave.ini

@@ -29,6 +29,4 @@ requires = ["poetry-core>=2.0.0,<3.0.0"]
 build-backend = "poetry.core.masonry.api"
 
 [tool.behave]
-junit = true
-junit_directory = "tests"
-paths = ["tests"]
+paths = ["tests/features"]

pyproject.toml

@@ -1,8 +1,7 @@
 Feature: Participants with submitted responses
   Scenario: Cannot change responses once submitted
-    Given a participant abc123 exists
-    And the participant abc123 has submitted their responses
-    And the participant is on the "/start" path
-    When the participant abc123 submits their participant id
-    Then the participant should be on the "/start" path
-    And the participant should see en error summary "Responses have already been submitted for this participant"
+    Given I have already submitted my responses
+    When I go to "/start"
+    And I submit my participant id
+    Then I am on "/start"
+    And I should see an error summary "Responses have already been submitted for this participant"

tests/features/cannot_change_answers_after_submission.feature

@@ -49,10 +49,10 @@ def after_all(context):
         LiveServer.tearDownClass()
 
 
-def before_scenario(_context, _scenario):
+def before_scenario(context, _scenario):
     """Set up before each scenario."""
     # behave-django automatically handles database transactions per scenario
-    pass
+    context.page = context.browser.new_page()
 
 
 def after_scenario(context, _scenario):

tests/features/environment.py

@@ -1,7 +1,7 @@
 Feature: Non smokers
   Scenario: Non smokers are not elligible
-    Given a participant abc123 exists
-    And the participant is on the "/have-you-ever-smoked" path
-    When the participant fills in and submits their smoking status with "No, I have never smoked"
-    Then the participant should be on the "/non-smoker-exit" path
-    And the participant should see a title "You do not need an NHS lung health check"
+    Given I have started the questionnaire
+    When I go to "/have-you-ever-smoked"
+    And I fill in and submit my smoking status with "No, I have never smoked"
+    Then I am on "/non-smoker-exit"
+    And I see a title "You do not need an NHS lung health check"

tests/features/not_a_smoker_exit.feature

@@ -2,6 +2,6 @@
 from playwright.sync_api import expect
 
 
-@then(u'the participant should see en error summary "{error_summary}"')
-def then_the_participant_should_see_an_error_summary(context, error_summary):
-    expect(context.page.locator('#maincontent')).to_contain_text(error_summary)
+@then(u'I should see an error summary "{error_summary}"')
+def then_I_should_see_an_error_summary(context, error_summary):
+    expect(context.page.locator('.nhsuk-error-summary')).to_contain_text(error_summary)

tests/features/steps/error_steps.py

@@ -1,12 +1,12 @@
 from behave import when
 
 
-@when('the participant {participant_id} submits their participant id')
-def when_the_participant_submits_their_participant_id(context, participant_id):
-    context.page.fill('input[name="participant_id"]', participant_id)
+@when('I submit my participant id')
+def when_I_submit_my_participant_id(context):
+    context.page.fill('input[name="participant_id"]', context.participant_id)
     context.page.click('button[type="submit"]')
 
-@when('the participant fills in and submits their smoking status with "{smoking_status}"')
-def when_the_participant_fills_in_and_submits_their_smoking_status(context, smoking_status):
+@when('I fill in and submit my smoking status with "{smoking_status}"')
+def when_I_fill_in_and_submit_my_smoking_status(context, smoking_status):
     context.page.get_by_label(smoking_status).check()
     context.page.click("text=Continue")

tests/features/steps/form_steps.py

@@ -1,12 +1,11 @@
-from behave import given, then
+from behave import when, then
 from playwright.sync_api import expect
 
 
-@given('the participant is on the "{path}" path')
-def given_the_participant_is_on_the_path(context, path):
-    context.page = context.browser.new_page()
+@when('I go to "{path}"')
+def given_I_go_to(context, path):
     context.page.goto(f"{context.live_server_url}{path}")
 
-@then('the participant should be on the "{path}" path')
-def then_the_participant_should_be_on_the_path(context, path):
+@then('I am on "{path}"')
+def then_I_am_on(context, path):
     expect(context.page).to_have_url(f"{context.live_server_url}{path}")

tests/features/steps/navigation_steps.py

@@ -0,0 +1,7 @@
+from behave import given, then
+from playwright.sync_api import expect
+
+
+@then(u'I see a title "{title}"')
+def then_I_see_a_title(context, title):
+    expect(context.page.locator('.title')).to_have_text(title)