PPHA-262: Resolve linting errors

Author: Themitchell

lung_cancer_screening/core/form_fields.py

@@ -206,7 +206,7 @@ def widget_attrs(self, widget):
         attrs.pop("step", None)
 
         return attrs
-    
+
 class DecimalField(forms.DecimalField):
     def __init__(
         self,

lung_cancer_screening/core/jinja2/forms/input.jinja

@@ -31,4 +31,4 @@
     {% set input_params = dict(input_params, **error_params) %}
   {% endif %}
 
-{{ input(input_params) }}
+{{ input(input_params) }}

lung_cancer_screening/core/tests/acceptance/helpers/user_interaction_helpers.py

@@ -36,4 +36,4 @@ def fill_in_and_submit_height_imperial(page, feet, inches):
     page.get_by_label("Feet").fill(str(feet))
     page.get_by_label("Inches").fill(str(inches))
 
-    page.click("text=Continue")
+    page.click("text=Continue")

lung_cancer_screening/questions/forms/imperial_height_form.py

@@ -12,13 +12,13 @@ def __init__(self, *args, **kwargs):
         self.instance.participant = self.participant
 
         self.fields["height_feet"] = DecimalField(
-             label="Feet",
-             classes="nhsuk-input--width-4",
+            label="Feet",
+            classes="nhsuk-input--width-4",
         )
-        
+
         self.fields["height_inches"] = DecimalField(
-             label="Inches",
-             classes="nhsuk-input--width-4",
+            label="Inches",
+            classes="nhsuk-input--width-4",
         )
 
     def clean_height(self):
@@ -27,4 +27,4 @@ def clean_height(self):
 
     class Meta:
         model = ResponseSet
-        fields = ['height']
+        fields = ['height']

lung_cancer_screening/questions/forms/metric_height_form.py

@@ -12,14 +12,13 @@ def __init__(self, *args, **kwargs):
         self.instance.participant = self.participant
 
         self.fields["height"] = DecimalField(
-             label="Centimetres",
-             classes="nhsuk-input--width-4",
+            label="Centimetres",
+            classes="nhsuk-input--width-4",
         )
 
     def clean_height(self):
-      data = self.cleaned_data['height']
-      return data*10
+        return self.cleaned_data['height'] * 10
 
     class Meta:
         model = ResponseSet
-        fields = ['height']
+        fields = ['height']

lung_cancer_screening/questions/tests/unit/views/test_height.py

@@ -74,12 +74,3 @@ def test_post_responds_with_422_if_the_resource_is_invalid(self):
         )
 
         self.assertEqual(response.status_code, 422)
-
-
-# If nothing is entered - Enter your height
-# User enters a height that is outside the accepted range (cms) - Height must be between 139.7cm and 243.8 cm
-# User enters a height that is outside the accepted range (feet and inches) - Height must be between 4 feet 7 inches and 8 feet
-# User enters a reading for feet that is outside the accepted range - Feet must be between 4 and 8
-# User enters a reading for inches that is outside the accepted range - Inches must be between 0 and 11
-# User enters a reading for feet using a decimal point - Feet must be in whole numbers
-# User enters a reading for inches using a decimal point - I

lung_cancer_screening/questions/views/height.py

@@ -1,38 +1,37 @@
 from django.shortcuts import render, redirect
-from django.core.exceptions import ValidationError
 
 from lung_cancer_screening.questions.forms.metric_height_form import MetricHeightForm
-from lung_cancer_screening.questions.models import participant
 
 from .decorators.participant_decorators import require_participant
 
 @require_participant
-def height(request): 
-  if request.method == "POST":
-    form = MetricHeightForm(
-      instance = request.participant.responseset_set.last(),
-      data=request.POST, 
-      participant=request.participant
-    )
+def height(request):
+    if request.method == "POST":
+        form = MetricHeightForm(
+            instance = request.participant.responseset_set.last(),
+            data=request.POST,
+            participant=request.participant
+        )
 
-    if form.is_valid() :
-      form.save()
+        if form.is_valid():
+            form.save()
 
-      return redirect("questions:responses")
-    else :
-      return render(
-        request,
-        "height.jinja",
-        { "form" : form },
-        status=422
-      )
-  unit = request.GET.get('unit')
-  return render(
+            return redirect("questions:responses")
+        else :
+            return render(
+                request,
+                "height.jinja",
+                { "form": form },
+                status=422
+            )
+
+    unit = request.GET.get('unit')
+    return render(
         request,
         "height.jinja",
-        { 
-          "form" : MetricHeightForm(participant=request.participant),
-          "unit" : unit,
-          "switch_to_unit" : "metric" if unit == "imperial" else "imperial"
+        {
+            "form": MetricHeightForm(participant=request.participant),
+            "unit": unit,
+            "switch_to_unit": "metric" if unit == "imperial" else "imperial"
         }
     )