PPHA-475: Ensure a response set is created on submission

Before all questionnaire pages unsure a response set exists for the
user or redirect back to start if they have submitted responses in the
last year.

This replaces the /start page submission and creation of Participant
and corresponding response set.

Using NHS Login flow, no post can be made to create the response set so
handle it on each POST request using the EnsureResponseSet mixin.

Author: Themitchell

lung_cancer_screening/questions/auth.py

@@ -39,6 +39,7 @@ def create_user(self, claims):
             raise ValueError("Missing 'nhs_number' claim in OIDC token")
         return User.objects.create_user(nhs_number=nhs_number)
 
+
     def update_user(self, user, _claims):
         return user
 

lung_cancer_screening/questions/forms/asbestos_exposure_form.py

@@ -5,9 +5,7 @@
 
 class AsbestosExposureForm(forms.ModelForm):
     def __init__(self, *args, **kwargs):
-        self.user = kwargs.pop('user')
         super().__init__(*args, **kwargs)
-        self.instance.user = self.user
 
         self.fields["asbestos_exposure"] = TypedChoiceField(
             choices=[(True, 'Yes'), (False, 'No')],

lung_cancer_screening/questions/forms/date_of_birth_form.py

@@ -4,11 +4,10 @@
 from ..models.response_set import ResponseSet
 from ...nhsuk_forms.split_date_field import SplitDateField
 
+
 class DateOfBirthForm(forms.ModelForm):
     def __init__(self, *args, **kwargs):
-        self.user = kwargs.pop('user')
         super().__init__(*args, **kwargs)
-        self.instance.user = self.user
 
         invalid_error_message = 'Date of birth must be a real date'
         self.fields["date_of_birth"] = SplitDateField(

lung_cancer_screening/questions/forms/ethnicity_form.py

@@ -3,26 +3,30 @@
 from ...nhsuk_forms.choice_field import ChoiceField
 from ..models.response_set import ResponseSet, EthnicityValues
 
+
 class EthnicityForm(forms.ModelForm):
 
     def __init__(self, *args, **kwargs):
-        self.user = kwargs.pop('user')
         super().__init__(*args, **kwargs)
-        self.instance.user = self.user
 
         self.fields["ethnicity"] = ChoiceField(
             choices=EthnicityValues.choices,
             label="What is your ethnic background?",
             widget=forms.RadioSelect,
             label_classes="nhsuk-fieldset__legend--l",
             label_is_page_heading=True,
-            hint="Your ethnicity may impact your chances of developing lung cancer.",
+            hint=(
+                "Your ethnicity may impact your chances of "
+                "developing lung cancer."
+            ),
             error_messages={
                 'required': 'Select your ethnic background'
             }
         )
 
-        self["ethnicity"].add_divider_after(EthnicityValues.OTHER.value, "or")
+        self["ethnicity"].add_divider_after(
+            EthnicityValues.OTHER.value, "or"
+        )
 
     class Meta:
         model = ResponseSet

lung_cancer_screening/questions/forms/gender_form.py

@@ -3,20 +3,22 @@
 from ...nhsuk_forms.choice_field import ChoiceField
 from ..models.response_set import ResponseSet, GenderValues
 
+
 class GenderForm(forms.ModelForm):
 
     def __init__(self, *args, **kwargs):
-        self.user = kwargs.pop('user')
         super().__init__(*args, **kwargs)
-        self.instance.user = self.user
 
         self.fields["gender"] = ChoiceField(
             choices=GenderValues.choices,
             widget=forms.RadioSelect,
             label="Which of these best describes you?",
             label_classes="nhsuk-fieldset__legend--l",
             label_is_page_heading=True,
-            hint="This information is used to find your NHS number and match with your GP record.",
+            hint=(
+                "This information is used to find your NHS number and "
+                "match with your GP record."
+            ),
             error_messages={
                 'required': 'Select the option that best describes your gender'
             }

lung_cancer_screening/questions/forms/have_you_ever_smoked_form.py

@@ -6,9 +6,7 @@
 class HaveYouEverSmokedForm(forms.ModelForm):
 
     def __init__(self, *args, **kwargs):
-        self.user = kwargs.pop('user')
         super().__init__(*args, **kwargs)
-        self.instance.user = self.user
 
         self.fields["have_you_ever_smoked"] = TypedChoiceField(
             choices=HaveYouEverSmokedValues.choices,

lung_cancer_screening/questions/forms/imperial_height_form.py

@@ -3,12 +3,11 @@
 from ...nhsuk_forms.imperial_height_field import ImperialHeightField
 from ..models.response_set import ResponseSet
 
+
 class ImperialHeightForm(forms.ModelForm):
 
     def __init__(self, *args, **kwargs):
-        self.user = kwargs.pop('user')
         super().__init__(*args, **kwargs)
-        self.instance.user = self.user
 
         self.fields["height_imperial"] = ImperialHeightField(
             label="Height",

lung_cancer_screening/questions/forms/imperial_weight_form.py

@@ -3,12 +3,11 @@
 from ...nhsuk_forms.imperial_weight_field import ImperialWeightField
 from ..models.response_set import ResponseSet
 
+
 class ImperialWeightForm(forms.ModelForm):
 
     def __init__(self, *args, **kwargs):
-        self.user = kwargs.pop('user')
         super().__init__(*args, **kwargs)
-        self.instance.user = self.user
 
         self.fields["weight_imperial"] = ImperialWeightField(
             label="Weight",

lung_cancer_screening/questions/forms/metric_height_form.py

@@ -3,20 +3,22 @@
 from ...nhsuk_forms.decimal_field import DecimalField
 from ..models.response_set import ResponseSet
 
+
 class MetricHeightForm(forms.ModelForm):
 
     def __init__(self, *args, **kwargs):
-        self.user = kwargs.pop('user')
         super().__init__(*args, **kwargs)
-        self.instance.user = self.user
 
         self.fields["height"] = DecimalField(
             decimal_places=1,
             label="Centimetres",
             classes="nhsuk-input--width-4",
             error_messages={
                 'required': 'Enter your height',
-                "max_decimal_places": "Centimetres must be to 1 decimal place, for example 185.5cm",
+                "max_decimal_places": (
+                    "Centimetres must be to 1 decimal place, "
+                    "for example 185.5cm"
+                ),
             },
             suffix="cm"
         )

lung_cancer_screening/questions/forms/metric_weight_form.py

@@ -3,12 +3,11 @@
 from ...nhsuk_forms.decimal_field import DecimalField
 from ..models.response_set import ResponseSet
 
+
 class MetricWeightForm(forms.ModelForm):
 
     def __init__(self, *args, **kwargs):
-        self.user = kwargs.pop('user')
         super().__init__(*args, **kwargs)
-        self.instance.user = self.user
 
         self.fields["weight_metric"] = DecimalField(
             decimal_places=1,
@@ -17,7 +16,10 @@ def __init__(self, *args, **kwargs):
             required=True,
             error_messages={
                 'required': 'Enter your weight',
-                'max_decimal_places': 'Kilograms must be to 1 decimal place, for example 90.2kgs',
+                'max_decimal_places': (
+                    'Kilograms must be to 1 decimal place, '
+                    'for example 90.2kgs'
+                ),
             },
             suffix="kg"
         )