Ensure only able to view and modify unsubmitted ResponseSet

Author: Themitchell

lung_cancer_screening/questions/models/participant.py

@@ -3,3 +3,9 @@
 
 class Participant(BaseModel):
     unique_id = models.CharField(max_length=255, unique=True)
+
+    def unsubmitted_response_sets(self):
+        return self.responseset_set.filter(submitted_at__isnull=True)
+
+    def has_unsubmitted_response_set(self):
+        return self.unsubmitted_response_sets().exists()

lung_cancer_screening/questions/tests/unit/models/test_participant.py

@@ -1,5 +1,6 @@
 from django.test import TestCase
 from datetime import datetime, date
+from django.utils import timezone
 from django.core.exceptions import ValidationError
 
 
@@ -41,3 +42,23 @@ def test_raises_a_validation_error_if_the_unique_id_is_null(self):
     def test_raises_a_validation_error_if_the_unique_id_is_empty(self):
         with self.assertRaises(ValidationError):
             Participant.objects.create(unique_id="")
+
+    def test_unsubmitted_response_sets_returns_only_responses_that_have_not_been_submitted(self):
+        unsubmitted = self.participant.responseset_set.create(
+            submitted_at=None
+        )
+        submitted = self.participant.responseset_set.create(
+            submitted_at=timezone.now()
+        )
+
+        unsubmitted_response_sets = list(self.participant.unsubmitted_response_sets())
+        self.assertIn(unsubmitted, unsubmitted_response_sets)
+        self.assertNotIn(submitted, unsubmitted_response_sets)
+
+    def test_has_unsubmitted_response_set_returns_true_if_the_participant_has_an_unsubmitted_response_set(self):
+        self.participant.responseset_set.create(submitted_at=None)
+        self.assertTrue(self.participant.has_unsubmitted_response_set())
+
+    def test_has_unsubmitted_response_set_returns_false_if_the_participant_has_no_unsubmitted_response_set(self):
+        self.participant.responseset_set.create(submitted_at=timezone.now())
+        self.assertFalse(self.participant.has_unsubmitted_response_set())

lung_cancer_screening/questions/tests/unit/views/test_age_range_exit.py

@@ -1,14 +1,16 @@
 from django.test import TestCase
 from django.urls import reverse
+from django.utils import timezone
 
 from lung_cancer_screening.questions.models.participant import Participant
 
 class TestPostAgeRangeExit(TestCase):
     def setUp(self):
-        participant = Participant.objects.create(unique_id="12345")
+        self.participant = Participant.objects.create(unique_id="12345")
+        self.participant.responseset_set.create()
 
         session = self.client.session
-        session['participant_id'] = participant.unique_id
+        session['participant_id'] = self.participant.unique_id
         session.save()
 
     def test_get_redirects_if_the_particpant_does_not_exist(self):
@@ -22,6 +24,15 @@ def test_get_redirects_if_the_particpant_does_not_exist(self):
 
         self.assertRedirects(response, reverse("questions:start"))
 
+    def test_get_redirects_if_the_particpant_has_no_unsubmitted_response_set(self):
+        self.participant.responseset_set.all().update(submitted_at=timezone.now())
+
+        response = self.client.get(
+            reverse("questions:age_range_exit")
+        )
+
+        self.assertRedirects(response, reverse("questions:start"))
+
     def test_get_responds_successfully(self):
         response = self.client.get(reverse("questions:age_range_exit"))
 

lung_cancer_screening/questions/tests/unit/views/test_date_of_birth.py

@@ -1,6 +1,7 @@
 from django.test import TestCase
 from django.urls import reverse
 from datetime import date
+from django.utils import timezone
 from dateutil.relativedelta import relativedelta
 
 from ....models.participant import Participant
@@ -38,6 +39,15 @@ def test_get_redirects_if_the_particpant_does_not_exist(self):
 
         self.assertRedirects(response, reverse("questions:start"))
 
+    def test_get_redirects_if_the_participant_has_no_unsubmitted_response_set(self):
+        self.participant.responseset_set.all().update(submitted_at=timezone.now())
+
+        response = self.client.get(
+            reverse("questions:date_of_birth")
+        )
+
+        self.assertRedirects(response, reverse("questions:start"))
+
     def test_get_responds_successfully(self):
         response = self.client.get(reverse("questions:date_of_birth"))
 
@@ -55,6 +65,16 @@ def test_post_redirects_if_the_particpant_does_not_exist(self):
 
         self.assertRedirects(response, reverse("questions:start"))
 
+    def test_post_redirects_if_the_participant_has_no_unsubmitted_response_set(self):
+        self.participant.responseset_set.all().update(submitted_at=timezone.now())
+
+        response = self.client.post(
+            reverse("questions:date_of_birth"),
+            self.valid_params
+        )
+
+        self.assertRedirects(response, reverse("questions:start"))
+
     def test_post_stores_a_valid_response_set_for_the_participant(self):
         self.client.post(
             reverse("questions:date_of_birth"),

lung_cancer_screening/questions/tests/unit/views/test_have_you_ever_smoked.py

@@ -1,5 +1,6 @@
 from django.test import TestCase
 from django.urls import reverse
+from django.utils import timezone
 
 from lung_cancer_screening.questions.models.participant import Participant
 from lung_cancer_screening.questions.models.response_set import HaveYouEverSmokedValues
@@ -25,6 +26,15 @@ def test_get_redirects_if_the_particpant_does_not_exist(self):
 
         self.assertRedirects(response, reverse("questions:start"))
 
+    def test_get_redirects_if_the_particpant_has_no_unsubmitted_response_set(self):
+        self.participant.responseset_set.all().update(submitted_at=timezone.now())
+
+        response = self.client.get(
+            reverse("questions:have_you_ever_smoked")
+        )
+
+        self.assertRedirects(response, reverse("questions:start"))
+
     def test_get_responds_successfully(self):
         response = self.client.get(reverse("questions:have_you_ever_smoked"))
 
@@ -42,6 +52,16 @@ def test_post_redirects_if_the_particpant_does_not_exist(self):
 
         self.assertRedirects(response, reverse("questions:start"))
 
+    def test_post_redirects_if_the_participant_has_no_unsubmitted_response_set(self):
+        self.participant.responseset_set.all().update(submitted_at=timezone.now())
+
+        response = self.client.post(
+            reverse("questions:have_you_ever_smoked"),
+            self.valid_params
+        )
+
+        self.assertRedirects(response, reverse("questions:start"))
+
     def test_post_stores_a_valid_response_for_the_participant(self):
         self.client.post(
             reverse("questions:have_you_ever_smoked"),

lung_cancer_screening/questions/tests/unit/views/test_non_smoker_exit.py

@@ -1,14 +1,16 @@
 from django.test import TestCase
 from django.urls import reverse
+from django.utils import timezone
 
 from lung_cancer_screening.questions.models.participant import Participant
 
 class TestPostNonSmokerExit(TestCase):
     def setUp(self):
-        participant = Participant.objects.create(unique_id="12345")
+        self.participant = Participant.objects.create(unique_id="12345")
+        self.participant.responseset_set.create()
 
         session = self.client.session
-        session['participant_id'] = participant.unique_id
+        session['participant_id'] = self.participant.unique_id
         session.save()
 
     def test_get_redirects_if_the_particpant_does_not_exist(self):
@@ -22,6 +24,15 @@ def test_get_redirects_if_the_particpant_does_not_exist(self):
 
         self.assertRedirects(response, reverse("questions:start"))
 
+    def test_get_redirects_if_the_particpant_has_no_unsubmitted_response_set(self):
+        self.participant.responseset_set.all().update(submitted_at=timezone.now())
+
+        response = self.client.get(
+            reverse("questions:non_smoker_exit")
+        )
+
+        self.assertRedirects(response, reverse("questions:start"))
+
     def test_get_responds_successfully(self):
         response = self.client.get(reverse("questions:non_smoker_exit"))
 

lung_cancer_screening/questions/tests/unit/views/test_responses.py

@@ -1,5 +1,6 @@
 from django.test import TestCase
 from django.urls import reverse
+from django.utils import timezone
 from datetime import date
 
 from lung_cancer_screening.questions.models.participant import Participant
@@ -26,6 +27,15 @@ def test_get_redirects_if_the_participant_does_not_exist(self):
 
         self.assertRedirects(response, reverse("questions:start"))
 
+    def test_get_redirects_if_the_particpant_has_no_unsubmitted_response_set(self):
+        self.participant.responseset_set.all().update(submitted_at=timezone.now())
+
+        response = self.client.get(
+            reverse("questions:responses")
+        )
+
+        self.assertRedirects(response, reverse("questions:start"))
+
     def test_get_responds_successfully(self):
         response = self.client.get(reverse("questions:responses"))
 
@@ -47,6 +57,36 @@ def test_get_does_not_contain_responses_for_other_participants(self):
             response, other_date_response.get_have_you_ever_smoked_display())
         self.assertNotContains(response, other_date_response.date_of_birth)
 
+    def test_get_does_not_contain_responses_which_have_already_been_submitted(self):
+        submitted = self.participant.responseset_set.create(
+            have_you_ever_smoked=False,
+            date_of_birth=date(1966, 1, 1),
+            submitted_at=timezone.now()
+        )
+
+        response = self.client.get(reverse("questions:responses"))
+
+        self.assertNotContains(response, submitted.get_have_you_ever_smoked_display())
+        self.assertNotContains(response, submitted.date_of_birth)
+
+    def test_post_redirects_if_the_participant_does_not_exist(self):
+        session = self.client.session
+        session['participant_id'] = "somebody none existant participant"
+        session.save()
+
+        response = self.client.post(reverse("questions:responses"))
+
+        self.assertRedirects(response, reverse("questions:start"))
+
+    def test_post_redirects_if_the_particpant_has_no_unsubmitted_response_set(self):
+        self.participant.responseset_set.all().update(submitted_at=timezone.now())
+
+        response = self.client.get(
+            reverse("questions:responses")
+        )
+
+        self.assertRedirects(response, reverse("questions:start"))
+
     def test_post_redirects_to_your_results(self):
         response = self.client.post(reverse("questions:responses"))
 

lung_cancer_screening/questions/views/age_range_exit.py

@@ -1,8 +1,9 @@
 from django.shortcuts import render
 
-from .decorators.participant_decorators import require_participant
+from .decorators.participant_decorators import require_participant, require_unsubmitted_response_set
 
 @require_participant
+@require_unsubmitted_response_set
 def age_range_exit(request):
     return render(
         request,

lung_cancer_screening/questions/views/date_of_birth.py

@@ -3,10 +3,11 @@
 from datetime import date
 from dateutil.relativedelta import relativedelta
 
-from .decorators.participant_decorators import require_participant
+from .decorators.participant_decorators import require_participant, require_unsubmitted_response_set
 from ..forms.date_of_birth_form import DateOfBirthForm
 
 @require_participant
+@require_unsubmitted_response_set
 def date_of_birth(request):
     if request.method == "POST":
         form = DateOfBirthForm(
@@ -20,7 +21,7 @@ def date_of_birth(request):
             date_of_birth = form.cleaned_data["date_of_birth"]
 
             if (seventy_five_years_ago < date_of_birth <= fifty_five_years_ago):
-                response_set = request.participant.responseset_set.last()
+                response_set = request.participant.unsubmitted_response_sets().last()
                 response_set.date_of_birth = date_of_birth
                 response_set.save()
 

lung_cancer_screening/questions/views/decorators/participant_decorators.py

@@ -15,3 +15,12 @@ def wrap(request, *args, **kwargs):
 
         return function(request, *args, **kwargs)
     return wrap
+
+def require_unsubmitted_response_set(function):
+    @wraps(function)
+    def wrap(request, *args, **kwargs):
+        if not request.participant.has_unsubmitted_response_set():
+            return redirect(reverse("questions:start"))
+
+        return function(request, *args, **kwargs)
+    return wrap