PPHA-475: Fix accessibility tests

Author: Themitchell

lung_cancer_screening/core/tests/acceptance/test_accessibility.py

@@ -8,7 +8,6 @@
 
 from lung_cancer_screening.questions.tests.factories.user_factory import UserFactory
 from .helpers.assertion_helpers import expect_no_accessibility_violations
-from .helpers.user_interaction_helpers import setup_user
 
 @tag('accessibility')
 class TestQuestionnaireAccessibility(StaticLiveServerTestCase):
@@ -61,94 +60,77 @@ def test_start_page_errors_accessibility(self):
         expect_no_accessibility_violations(self.page)
 
     def test_have_you_ever_smoked_page_accessibility(self):
-        setup_user(self.page, self.live_server_url)
         self.page.goto(f"{self.live_server_url}/have-you-ever-smoked")
         expect_no_accessibility_violations(self.page)
 
     def test_have_you_ever_smoked_page_errors_accessibility(self):
-        setup_user(self.page, self.live_server_url)
         self.page.goto(f"{self.live_server_url}/have-you-ever-smoked")
         self.page.click("text=Continue")
         expect_no_accessibility_violations(self.page)
 
     def test_date_of_birth_page_accessibility(self):
-        setup_user(self.page, self.live_server_url)
         self.page.goto(f"{self.live_server_url}/date-of-birth")
         expect_no_accessibility_violations(self.page)
 
     def test_date_of_birth_page_errors_accessibility(self):
-        setup_user(self.page, self.live_server_url)
         self.page.goto(f"{self.live_server_url}/date-of-birth")
         self.page.click("text=Continue")
         expect_no_accessibility_violations(self.page)
 
     def test_height_page_accessibility(self):
-        setup_user(self.page, self.live_server_url)
         self.page.goto(f"{self.live_server_url}/height")
         expect_no_accessibility_violations(self.page)
 
     def test_height_page_errors_accessibility(self):
-        setup_user(self.page, self.live_server_url)
         self.page.goto(f"{self.live_server_url}/height")
         self.page.click("text=Continue")
         expect_no_accessibility_violations(self.page)
 
     def test_height_imperial_page_accessibility(self):
-        setup_user(self.page, self.live_server_url)
         self.page.goto(f"{self.live_server_url}/height?unit=imperial")
         expect_no_accessibility_violations(self.page)
 
     def test_weight_page_accessibility(self):
-        setup_user(self.page, self.live_server_url)
         self.page.goto(f"{self.live_server_url}/weight")
         expect_no_accessibility_violations(self.page)
 
     def test_weight_page_errors_accessibility(self):
-        setup_user(self.page, self.live_server_url)
         self.page.goto(f"{self.live_server_url}/weight")
         self.page.click("text=Continue")
         expect_no_accessibility_violations(self.page)
 
     def test_weight_imperial_page_accessibility(self):
-        setup_user(self.page, self.live_server_url)
         self.page.goto(f"{self.live_server_url}/weight?unit=imperial")
         expect_no_accessibility_violations(self.page)
 
     def test_weight_imperial_page_errors_accessibility(self):
-        setup_user(self.page, self.live_server_url)
         self.page.goto(f"{self.live_server_url}/weight?unit=imperial")
         self.page.click("text=Continue")
         expect_no_accessibility_violations(self.page)
 
     def test_sex_at_birth_page_accessibility(self):
-        setup_user(self.page, self.live_server_url)
         self.page.goto(f"{self.live_server_url}/sex-at-birth")
         expect_no_accessibility_violations(self.page)
 
     def test_sex_at_birth_page_errors_accessibility(self):
-        setup_user(self.page, self.live_server_url)
         self.page.goto(f"{self.live_server_url}/sex-at-birth")
         self.page.click("text=Continue")
         expect_no_accessibility_violations(self.page)
 
     def test_gender_page_accessibility(self):
-        setup_user(self.page, self.live_server_url)
         self.page.goto(f"{self.live_server_url}/gender")
         expect_no_accessibility_violations(self.page)
 
     def test_gender_page_errors_accessibility(self):
-        setup_user(self.page, self.live_server_url)
         self.page.goto(f"{self.live_server_url}/gender")
         self.page.click("text=Continue")
         expect_no_accessibility_violations(self.page)
 
     def test_ethnicity_page_accessibility(self):
-        setup_user(self.page, self.live_server_url)
         self.page.goto(f"{self.live_server_url}/ethnicity")
         expect_no_accessibility_violations(self.page)
 
     def test_ethnicity_page_errors_accessibility(self):
-        setup_user(self.page, self.live_server_url)
         self.page.goto(f"{self.live_server_url}/ethnicity")
         self.page.click("text=Continue")
         expect_no_accessibility_violations(self.page)
@@ -166,13 +148,11 @@ def test_ethnicity_page_errors_accessibility(self):
     #     expect_no_accessibility_violations(page)
 
     def test_asbestos_exposure_page_errors_accessibility(self):
-        setup_user(self.page, self.live_server_url)
         self.page.goto(f"{self.live_server_url}/asbestos-exposure")
         self.page.click("text=Continue")
         expect_no_accessibility_violations(self.page)
 
     def test_asbestos_exposure_page_accessibility(self):
-        setup_user(self.page, self.live_server_url)
         self.page.goto(f"{self.live_server_url}/asbestos-exposure")
         expect_no_accessibility_violations(self.page)
 
@@ -189,11 +169,9 @@ def test_asbestos_exposure_page_accessibility(self):
     #     expect_no_accessibility_violations(page)
 
     def test_responses_page_accessibility(self):
-        setup_user(self.page, self.live_server_url)
         self.page.goto(f"{self.live_server_url}/responses")
         expect_no_accessibility_violations(self.page)
 
     def test_your_results_page_accessibility(self):
-        setup_user(self.page, self.live_server_url)
         self.page.goto(f"{self.live_server_url}/your-results")
         expect_no_accessibility_violations(self.page)

lung_cancer_screening/questions/auth.py

@@ -27,7 +27,7 @@ def filter_users_by_claims(self, claims):
 
         nhs_number = claims.get('nhs_number')
         if not nhs_number:
-            return User.objects.none()
+            return user_class.objects.none()
 
         return user_class.objects.filter(nhs_number=nhs_number)
 

lung_cancer_screening/questions/tests/unit/views/test_start.py

@@ -1,8 +1,6 @@
 from django.test import TestCase
 from django.urls import reverse
 
-from .helpers.authentication import login_user
-
 class TestGetStart(TestCase):
 
     def test_get_responds_successfully(self):