Skip to content

Commit 21a338d

Browse files
Update public v10.0.0 pre-release (#128)
* Update public v10.0.0 pre-release * Update footer params * Add missing error summary attributes * Use notification banner from NHS.UK frontend
1 parent 2876d18 commit 21a338d

File tree

13 files changed

+40
-222
lines changed

13 files changed

+40
-222
lines changed

app/assets/sass/components/_dark-mode.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -232,7 +232,7 @@ $app-dark-mode-link-visited-color: #89b;
232232
border-left-color: $app-dark-mode-text-colour-secondary;
233233
}
234234

235-
.app-notification-banner__content {
235+
.nhsuk-notification-banner__content {
236236
color: $app-dark-mode-text-colour;
237237
background: $app-dark-mode-background-secondary;
238238
}

app/assets/sass/components/_notification-banner.scss

Lines changed: 0 additions & 129 deletions
This file was deleted.

app/assets/sass/main.scss

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
@forward 'components/secondary-navigation';
1111
@forward 'components/count';
1212
@forward 'components/forward-link';
13-
@forward 'components/notification-banner';
1413
@forward 'components/status';
1514
@forward 'components/reading';
1615

app/views/_components/notification-banner/macro.njk

Lines changed: 0 additions & 3 deletions
This file was deleted.

app/views/_components/notification-banner/template.njk

Lines changed: 0 additions & 51 deletions
This file was deleted.

app/views/_templates/layout-app.html

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -110,20 +110,20 @@
110110
{% if flash.success %}
111111
{% set flashSuccess = flash.success[0] %}
112112
{% if flashSuccess | isString %}
113-
{{ appNotificationBanner({
113+
{{ notificationBanner({
114114
text: flashSuccess,
115115
type: "success"
116116
}) }}
117117
{% else %}
118118
{% set html = flashSuccess.html %}
119119
{% if flashSuccess.wrapWithHeading %}
120120
{% set html %}
121-
<p class="app-notification-banner__heading">
121+
<p class="nhsuk-notification-banner__heading">
122122
{{ flashSuccess.wrapWithHeading | safe }}
123123
</p>
124124
{% endset %}
125125
{% endif %}
126-
{{ appNotificationBanner({
126+
{{ notificationBanner({
127127
title: flashSuccess.title,
128128
html: html,
129129
text: flashSuccess.text,
@@ -133,14 +133,14 @@
133133
{% endif %}
134134

135135
{% if flash.info %}
136-
{{ appNotificationBanner({
136+
{{ notificationBanner({
137137
html: flash.info,
138138
type: "info"
139139
}) }}
140140
{% endif %}
141141

142142
{% if flash.warning %}
143-
{{ appNotificationBanner({
143+
{{ notificationBanner({
144144
html: flash.warning,
145145
type: "warning"
146146
}) }}

app/views/_templates/layout.html

Lines changed: 21 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
{%- from '_components/hidden-input/macro.njk' import appHiddenInput %}
1414
{%- from '_components/modal/macro.njk' import appModal %}
1515
{%- from '_components/modal/macro.njk' import appConfirmationModal %}
16-
{%- from '_components/notification-banner/macro.njk' import appNotificationBanner %}
1716
{%- from '_components/secondary-navigation/macro.njk' import appSecondaryNavigation %}
1817
{%- from '_components/button-menu/macro.njk' import buttonMenu %}
1918
{%- from '_components/summary-list/macro.njk' import appSummaryListRow %}
@@ -47,25 +46,27 @@
4746
<!-- Footer code examples can be found at https://service-manual.nhs.uk/design-system/components/footer -->
4847
{% block footer %}
4948
{{ footer({
50-
"links": [
51-
{
52-
"URL": "/",
53-
"label": "Home"
54-
},
55-
{
56-
"URL": "/settings",
57-
"label": "Settings"
58-
},
59-
{
60-
"URL": "/clear-data",
61-
"label": "Clear data"
62-
},
63-
{
64-
"URL": "https://github.com/NHSDigital/manage-screening-events-prototype",
65-
"label": "Github"
66-
}
67-
]
68-
})}}
49+
meta: {
50+
links: [
51+
{
52+
href: "/",
53+
text: "Home"
54+
},
55+
{
56+
href: "/settings",
57+
text: "Settings"
58+
},
59+
{
60+
href: "/clear-data",
61+
text: "Clear data"
62+
},
63+
{
64+
href: "https://github.com/NHSDigital/manage-screening-events-prototype",
65+
text: "Github"
66+
}
67+
]
68+
}
69+
}) }}
6970
{% endblock %}
7071

7172
{% block bodyEnd %}

app/views/reading/batch.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ <h3 class="nhsuk-notification-banner__heading">
7575
</h3>
7676
{% endset %}
7777

78-
{{ appNotificationBanner({
78+
{{ notificationBanner({
7979
html: notificationBannerHtml,
8080
type: "success"
8181
}) }}

app/views/settings.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ <h1>
1919
{{ data.settings | log("Settings")}}
2020

2121
{% if flash.error %}
22-
<div class="nhsuk-error-summary" role="alert">
23-
<h2 class="nhsuk-error-summary__title">Error</h2>
22+
<div class="nhsuk-error-summary" aria-labelledby="error-summary-title" role="alert" tabindex="-1" data-module="nhsuk-error-summary">
23+
<h2 class="nhsuk-error-summary__title" id="error-summary-title">Error</h2>
2424
<div class="nhsuk-error-summary__body">
2525
<p>{{ flash.error }}</p>
2626
</div>

docs/views/layout.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
{% endblock %}
2929

3030
{% block footer %}
31-
{{ footer({ }) }}
31+
{{ footer() }}
3232
{% endblock %}
3333

3434
{% block bodyEnd %}

0 commit comments

Comments
 (0)