Use memory store rather than file store to work around intermittent data saving bug (#187)

Author: edwardhorsford

app.js

@@ -138,28 +138,48 @@ if (useCookieSessionStore === 'true') {
     })
   }
 
-  app.use(
-    sessionInMemory({
-      ...sessionOptions,
-      name: sessionName,
-      resave: false,
-      saveUninitialized: false,
-      store: new FileStore({
-        path: sessionPath,
-        logFn: (message) => {
-          // Suppress all expected session-related messages
-          if (
-            message.endsWith('Deleting expired sessions') ||
-            message.includes('ENOENT')
-          ) {
-            return
-          }
-          // Only log unexpected issues
-          console.log(message)
-        }
+  // app.use(
+  //   sessionInMemory({
+  //     ...sessionOptions,
+  //     name: sessionName,
+  //     resave: false,
+  //     saveUninitialized: false,
+  //     store: new FileStore({
+  //       path: sessionPath,
+  //       logFn: (message) => {
+  //         // Suppress all expected session-related messages
+  //         if (
+  //           message.endsWith('Deleting expired sessions') ||
+  //           message.includes('ENOENT')
+  //         ) {
+  //           return
+  //         }
+  //         // Only log unexpected issues
+  //         console.log(message)
+  //       }
+  //     })
+  //   })
+  // )
+  // Support session data in cookie or memory
+  if (useCookieSessionStore === 'true') {
+    app.use(
+      sessionInCookie({
+        ...sessionOptions,
+        cookieName: sessionName,
+        proxy: true,
+        requestKey: 'session'
       })
-    })
-  )
+    )
+  } else {
+    app.use(
+      sessionInMemory({
+        ...sessionOptions,
+        name: sessionName,
+        resave: false,
+        saveUninitialized: false
+      })
+    )
+  }
 }
 
 // Support for parsing data in POSTs

app/lib/utils/regenerate-data.js

@@ -39,10 +39,18 @@ async function regenerateData(req) {
   }
 
   // Reload session data defaults with fresh data and updated generation info
-  req.session.data = {
-    ...require('../../data/session-data-defaults'),
-    generationInfo
-  }
+  // req.session.data = {
+  //   ...require('../../data/session-data-defaults'),
+  //   generationInfo
+  // }
+  // IMPORTANT: Modify existing object rather than replacing it
+  // Replacing breaks express-session's change tracking
+  const freshDefaults = require('../../data/session-data-defaults')
+
+  // Clear existing keys
+  Object.keys(req.session.data).forEach((key) => delete req.session.data[key])
+  // Merge in fresh defaults and generation info
+  Object.assign(req.session.data, freshDefaults, { generationInfo })
 }
 
 function needsRegeneration(generationInfo) {

app/lib/utils/status.js

@@ -121,7 +121,7 @@ const isAppointmentWorkflow = function (event, currentUser) {
   const startedBy = event?.sessionDetails?.startedBy
   if (!currentUser || !startedBy) {
     console.log(
-      `User or event not found: currentuser: ${currentUser}, startedBy: ${startedBy}`
+      `User or event not found: currentuser: ${currentUser?.id || currentUser}, startedBy: ${startedBy}`
     )
     return false
   }

app/routes.js

@@ -34,7 +34,7 @@ router.use((req, res, next) => {
 router.use((req, res, next) => {
   const data = req.session.data
 
-  if (data.currentUserId != data.currentUser.id) {
+  if (data && data.currentUser && data.currentUserId != data.currentUser.id) {
     const selectedUser = data.users.find(
       (user) => user.id === data.currentUserId
     )