Merge pull request #380 from NHSDigital/remove-screenshots-path

Remove `screenshots_path` fixture

Author: thomasleese

.gitignore

@@ -330,7 +330,6 @@ allure-report/
 allure-results/
 
 # Playwright
-screenshots/
 test-results/
 
 # Project

README.md

@@ -95,7 +95,7 @@ $ pytest --headed
 #### Screenshots
 
 To take screenshots while the tests are running there is a `--screenshot`
-command line option. The screenshots will be saved in a `screenshots`
+command line option. The screenshots will be saved in a `test-results`
 directory.
 
 ```shell
@@ -202,4 +202,3 @@ The following changes will be added soon:
 
 - complete automation of data prep. The first step of the workflow will be to generate a new valid cohort file to be used by the rest of the workflow. This will remove the need for URN and input file to be added as inputs.
 - Better reporting. Current thinking is to have the test results uploaded to Splunk for better analysis, however it is currently unknown whether this will be permitted. Another option would be to publish the reports to github pages, again this may be blocked by permissions. Lastly, a tabular version of the results could be generated directly on the workflow output, this is most definitely a 'backup' option.
-

mavis/test/__init__.py

@@ -36,7 +36,6 @@
     review_school_move_page,
     school_moves_page,
     schools,
-    screenshots_path,
     sessions_page,
     start_page,
     superuser,
@@ -84,7 +83,6 @@
     "review_school_move_page",
     "school_moves_page",
     "schools",
-    "screenshots_path",
     "sessions_page",
     "start_page",
     "superuser",

mavis/test/fixtures/__init__.py

@@ -40,13 +40,7 @@
     team,
     users,
 )
-from .playwright import (
-    base_url,
-    basic_auth,
-    browser_context_args,
-    browser_type,
-    screenshots_path,
-)
+from .playwright import base_url, basic_auth, browser_context_args, browser_type
 
 __all__ = [
     "add_vaccine_batch",
@@ -81,7 +75,6 @@
     "review_school_move_page",
     "school_moves_page",
     "schools",
-    "screenshots_path",
     "sessions_page",
     "start_page",
     "superuser",

mavis/test/fixtures/playwright.py

@@ -1,5 +1,3 @@
-from datetime import datetime
-from pathlib import Path
 import os
 from typing import Optional
 
@@ -20,19 +18,6 @@ def basic_auth() -> dict[str, str]:
     }
 
 
-@pytest.fixture(scope="session")
-def screenshots_path(pytestconfig) -> Optional[Path]:
-    screenshot = pytestconfig.getoption("screenshot")
-
-    if screenshot == "off":
-        return None
-
-    session_name = datetime.now().isoformat()
-    path = Path("screenshots") / session_name
-    path.mkdir(parents=True, exist_ok=True)
-    return path
-
-
 @pytest.fixture(scope="session")
 def browser_type(playwright: Playwright, device: Optional[str]) -> BrowserType:
     device = device or "Desktop Chrome"