Merge pull request #419 from NHSDigital/remove-unused-flag

jf-x-dev · web-flow · commit 96fad7993a3e · 2025-07-03T09:57:21.000+01:00
remove unused is_created flag
diff --git a/mavis/test/pages/children.py b/mavis/test/pages/children.py
@@ -119,7 +119,7 @@ def expect_text_in_heading(self, text: str) -> None:
         expect(self.page.get_by_role("heading")).to_contain_text(text)
 
     def verify_activity_log_for_created_or_matched_child(
-        self, child_name: str, location: str, *, is_created: bool
+        self, child_name: str, location: str
     ):
         self.search_textbox.fill(child_name)
         self.search_button.click()
diff --git a/tests/test_consent_responses.py b/tests/test_consent_responses.py
@@ -88,7 +88,7 @@ def test_match(
     dashboard_page.click_mavis()
     dashboard_page.click_children()
     children_page.verify_activity_log_for_created_or_matched_child(
-        str(children[0]), schools[0], is_created=False
+        str(children[0]), schools[0]
     )
 
 
@@ -132,7 +132,7 @@ def test_create_with_nhs_number(
     dashboard_page.click_mavis()
     dashboard_page.click_children()
     children_page.verify_activity_log_for_created_or_matched_child(
-        f"{child_name[1]}, {child_name[0]}", schools[0], is_created=False
+        f"{child_name[1]}, {child_name[0]}", schools[0]
     )
 
 
@@ -157,5 +157,5 @@ def test_create_with_no_nhs_number(
     dashboard_page.click_mavis()
     dashboard_page.click_children()
     children_page.verify_activity_log_for_created_or_matched_child(
-        str(children[0]), schools[0], is_created=False
+        str(children[0]), schools[0]
     )

Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,7 @@ def test_match(`
`88`	`88`	`dashboard_page.click_mavis()`
`89`	`89`	`dashboard_page.click_children()`
`90`	`90`	`children_page.verify_activity_log_for_created_or_matched_child(`
`91`		`- str(children[0]), schools[0], is_created=False`
	`91`	`+ str(children[0]), schools[0]`
`92`	`92`	`)`
`93`	`93`
`94`	`94`
`@@ -132,7 +132,7 @@ def test_create_with_nhs_number(`
`132`	`132`	`dashboard_page.click_mavis()`
`133`	`133`	`dashboard_page.click_children()`
`134`	`134`	`children_page.verify_activity_log_for_created_or_matched_child(`
`135`		`- f"{child_name[1]}, {child_name[0]}", schools[0], is_created=False`
	`135`	`+ f"{child_name[1]}, {child_name[0]}", schools[0]`
`136`	`136`	`)`
`137`	`137`
`138`	`138`
`@@ -157,5 +157,5 @@ def test_create_with_no_nhs_number(`
`157`	`157`	`dashboard_page.click_mavis()`
`158`	`158`	`dashboard_page.click_children()`
`159`	`159`	`children_page.verify_activity_log_for_created_or_matched_child(`
`160`		`- str(children[0]), schools[0], is_created=False`
	`160`	`+ str(children[0]), schools[0]`
`161`	`161`	`)`