Merge pull request #826 from NHSDigital/remove-comments

jf-x-dev · web-flow · commit aab7d6c2df69 · 2025-12-10T09:38:39.000Z
Small code improvements
diff --git a/mavis/test/fixtures/imms_api.py b/mavis/test/fixtures/imms_api.py
@@ -12,7 +12,7 @@
 logger = logging.getLogger(__name__)
 
 
-@pytest.fixture(scope="session", autouse=False)
+@pytest.fixture(scope="session")
 def authenticate_api():
     _api_auth: dict[str, str] = _read_imms_api_credentials()
     _endpoint = urllib.parse.urljoin(_api_auth["url"], "oauth2-mock/token")
diff --git a/mavis/test/pages/error_pages/__init__.py b/mavis/test/pages/error_pages/__init__.py
@@ -1,4 +1,3 @@
-# Automatically generated
 from .bad_request_page import BadRequestPage
 from .service_error_page import ServiceErrorPage
 
diff --git a/mavis/test/pages/imports/__init__.py b/mavis/test/pages/imports/__init__.py
@@ -1,4 +1,3 @@
-# Automatically generated
 from .import_records_wizard_page import ImportRecordsWizardPage
 from .imports_page import ImportsPage
 
diff --git a/mavis/test/pages/programmes/__init__.py b/mavis/test/pages/programmes/__init__.py
@@ -1,4 +1,3 @@
-# Automatically generated
 from .programme_children_page import ProgrammeChildrenPage
 from .programme_overview_page import ProgrammeOverviewPage
 from .programme_sessions_page import ProgrammeSessionsPage
diff --git a/mavis/test/pages/reports/__init__.py b/mavis/test/pages/reports/__init__.py
@@ -1,4 +1,3 @@
-# Automatically generated
 from .reports_download_page import ReportsDownloadPage
 from .reports_vaccinations_page import ReportsVaccinationsPage
 
diff --git a/mavis/test/pages/school_moves/__init__.py b/mavis/test/pages/school_moves/__init__.py
@@ -1,4 +1,3 @@
-# Automatically generated
 from .download_school_moves_page import DownloadSchoolMovesPage
 from .review_school_move_page import ReviewSchoolMovePage
 from .school_moves_page import SchoolMovesPage
diff --git a/mavis/test/pages/sessions/__init__.py b/mavis/test/pages/sessions/__init__.py
@@ -1,4 +1,3 @@
-# Automatically generated
 from .gillick_competence_page import GillickCompetencePage
 from .nurse_consent_wizard_page import NurseConsentWizardPage
 from .sessions_children_page import SessionsChildrenPage
diff --git a/mavis/test/pages/unmatched_responses/__init__.py b/mavis/test/pages/unmatched_responses/__init__.py
@@ -1,4 +1,3 @@
-# Automatically generated
 from .archive_consent_response_page import ArchiveConsentResponsePage
 from .consent_response_page import ConsentResponsePage
 from .create_new_record_consent_response_page import CreateNewRecordConsentResponsePage
diff --git a/mavis/test/pages/vaccination_record/__init__.py b/mavis/test/pages/vaccination_record/__init__.py
@@ -1,4 +1,3 @@
-# Automatically generated
 from .edit_vaccination_record_page import EditVaccinationRecordPage
 from .vaccination_record_page import VaccinationRecordPage
 
diff --git a/mavis/test/pages/vaccines/__init__.py b/mavis/test/pages/vaccines/__init__.py
@@ -1,4 +1,3 @@
-# Automatically generated
 from .add_batch_page import AddBatchPage
 from .archive_batch_page import ArchiveBatchPage
 from .batch_expiry_date import BatchExpiryDate
diff --git a/tests/test_import_class_lists.py b/tests/test_import_class_lists.py
@@ -147,10 +147,8 @@ def test_class_list_file_upload_empty_file(
 @pytest.mark.classlist
 def test_class_list_file_upload_wrong_year_group(
     setup_class_list_import,
-    schools,
     page,
     file_generator,
-    year_groups,
 ):
     """
     Test: Upload a class list file with the wrong year group and verify error handling.
diff --git a/tests/test_tallying.py b/tests/test_tallying.py
@@ -185,8 +185,6 @@ def test_tallying_totals_match_eligible_patients(
     setup_fixed_child,
     page,
     programme,
-    children,
-    schools,
 ):
     """
     Test: Verify that tallying totals match the number of eligible patients.

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-# Automatically generated`
`2`	`1`	`from .bad_request_page import BadRequestPage`
`3`	`2`	`from .service_error_page import ServiceErrorPage`
`4`	`3`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-# Automatically generated`
`2`	`1`	`from .import_records_wizard_page import ImportRecordsWizardPage`
`3`	`2`	`from .imports_page import ImportsPage`
`4`	`3`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-# Automatically generated`
`2`	`1`	`from .programme_children_page import ProgrammeChildrenPage`
`3`	`2`	`from .programme_overview_page import ProgrammeOverviewPage`
`4`	`3`	`from .programme_sessions_page import ProgrammeSessionsPage`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-# Automatically generated`
`2`	`1`	`from .reports_download_page import ReportsDownloadPage`
`3`	`2`	`from .reports_vaccinations_page import ReportsVaccinationsPage`
`4`	`3`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-# Automatically generated`
`2`	`1`	`from .download_school_moves_page import DownloadSchoolMovesPage`
`3`	`2`	`from .review_school_move_page import ReviewSchoolMovePage`
`4`	`3`	`from .school_moves_page import SchoolMovesPage`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-# Automatically generated`
`2`	`1`	`from .gillick_competence_page import GillickCompetencePage`
`3`	`2`	`from .nurse_consent_wizard_page import NurseConsentWizardPage`
`4`	`3`	`from .sessions_children_page import SessionsChildrenPage`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-# Automatically generated`
`2`	`1`	`from .archive_consent_response_page import ArchiveConsentResponsePage`
`3`	`2`	`from .consent_response_page import ConsentResponsePage`
`4`	`3`	`from .create_new_record_consent_response_page import CreateNewRecordConsentResponsePage`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-# Automatically generated`
`2`	`1`	`from .edit_vaccination_record_page import EditVaccinationRecordPage`
`3`	`2`	`from .vaccination_record_page import VaccinationRecordPage`
`4`	`3`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-# Automatically generated`
`2`	`1`	`from .add_batch_page import AddBatchPage`
`3`	`2`	`from .archive_batch_page import ArchiveBatchPage`
`4`	`3`	`from .batch_expiry_date import BatchExpiryDate`