fixes (#32)

Author: chinmaymudholkar1

conftest.py

@@ -35,6 +35,15 @@ def start_mavis(start_exe_session, start_playwright):
     close_browser(browser=_browser, page=ce.page)
 
 
+# @pytest.fixture
+# def start_consent_workflow(start_exe_session, start_playwright):
+#     _browser, _context = start_browser(pw=start_playwright, browser_or_device=ce.current_browser_name)
+#     ce.page = _context.new_page()
+#     ce.page.goto(url=ce.parental_consent_url)
+#     yield
+#     close_browser(browser=_browser, page=ce.page)
+
+
 @pytest.fixture
 def start_consent_workflow(start_exe_session, start_playwright):
     _browser, _context = start_browser(pw=start_playwright, browser_or_device=ce.current_browser_name)

libs/constants.py

@@ -4,6 +4,7 @@
 class object_properties:
     TEXT: Final[str] = "text"
     VISIBILITY: Final[str] = "visibility"
+    HREF: Final[str] = "href"
 
 
 class actions:

libs/playwright_ops.py

@@ -67,6 +67,9 @@ def get_object_property(self, locator: str, property: str, by_test_id: bool = Fa
                 else:
                     elem = self.ce.page.get_by_role(locator).nth(0)
                 return elem.is_visible()
+            case object_properties.HREF:
+                elem = self.ce.page.get_by_role("link", name=locator).nth(0)
+                return elem.get_attribute(object_properties.HREF)
 
     def perform_action(self, locator, action, value=None, exact: bool = False) -> None:
         self.capture_screenshot(identifier=locator, action=f"before-{action}")

pages/pg_login.py

@@ -46,3 +46,10 @@ def perform_invalid_login(self, user: str, pwd: str, expected_message: str) -> s
 
     def perform_logout(self):
         self.po.perform_action(locator=self.BTN_LOGOUT, action=actions.CLICK_BUTTON)
+
+    def go_to_url(self, url: str) -> None:
+        _full_url = f"{self.ce.service_url.replace("/start","")}{url}" if url.startswith("/") else url
+        self.ce.page.goto(_full_url)
+
+    def go_to_login_page(self) -> None:
+        self.ce.page.goto(self.ce.service_url)

pages/pg_sessions.py

@@ -59,6 +59,7 @@ class pg_sessions:
     LBL_CHILD_NOT_COMPETENT = "Child assessed as not Gillick competent"
     LNK_EDIT_GILLICK_COMPETENCE = "Edit Gillick competence"
     BTN_UPDATE_GILLICK_ASSESSMENT = "Update your assessment"
+    LNK_CONSENT_FORM = "View parental consent form ("
 
     def __get_display_formatted_date(self, date_to_format: str) -> str:
         _parsed_date = datetime.strptime(date_to_format, "%Y%m%d")
@@ -333,3 +334,6 @@ def set_gillick_competence_for_student(self):
         self.add_gillick_competence(is_competent=True, competence_details="Gillick competent")
         self.click_edit_gillick_competence()
         self.edit_gillick_competence(is_competent=False, competence_details="Not Gillick competent")
+
+    def get_consent_url(self) -> str:
+        return self.po.get_object_property(locator=self.LNK_CONSENT_FORM, property=object_properties.HREF)

pytest.ini

@@ -23,3 +23,4 @@ markers =
   childlist
   vaccsbatch
   rav
+  bugs

test_data/ParentalConsent.xlsx

@@ -1 +1 @@
-The file is missing the following headers: ["CHILD_DATE_OF_BIRTH", "CHILD_FIRST_NAME", "CHILD_LAST_NAME", "CHILD_POSTCODE", "CHILD_SCHOOL_URN"]
+The file is missing the following headers: CHILD_DATE_OF_BIRTH, CHILD_FIRST_NAME, CHILD_LAST_NAME, CHILD_POSTCODE, CHILD_SCHOOL_URN

test_data/child/o_invalid_structure.csv

@@ -7,7 +7,7 @@ Records could not be imported
 The records cannot be uploaded due to errors in the CSV file. When fixing these errors, note that the header does not count as a row.
 Row 1 CHILD_FIRST_NAME: is required but missing
 Row 2 CHILD_LAST_NAME: is required but missing
-Row 3 CHILD_SCHOOL_URN: is not included in the list
+Row 3 CHILD_SCHOOL_URN: The school URN is not recognised. If you’ve checked the URN, and you believe it’s valid, contact our support organisation.
 Row 4 CHILD_DATE_OF_BIRTH: is required but missing
 Row 5 CHILD_NHS_NUMBER: is the wrong length (should be 10 characters)
 Row 6 CHILD_NHS_NUMBER: is the wrong length (should be 10 characters)

test_data/child/o_negative.csv

@@ -1 +1 @@
-The file is missing the following headers: ["CHILD_DATE_OF_BIRTH", "CHILD_FIRST_NAME", "CHILD_LAST_NAME"]
+There is a problemThe file is missing the following headers: CHILD_DATE_OF_BIRTH, CHILD_FIRST_NAME, CHILD_LAST_NAME