Merge pull request #865 from NHSDigital/increase-search-coverage

Increase session search coverage

Author: jf-x-dev

mavis/test/pages/search_components/patient_search_component.py

@@ -35,7 +35,7 @@ def get_patient_card_locator(self, child: Child) -> Locator:
             f'div.nhsuk-card.app-card.app-card--compact:has(h4:has-text("{child!s}"))'
         )
 
-    def verify_search(self) -> None:
+    def check_no_patients_found_when_expected(self) -> None:
         self.search_for("a very long string that won't match any names")
         expect(
             self.page.get_by_text("No children matching search criteria found"),
@@ -71,6 +71,18 @@ def search_for_a_child_name(self, child_name: str) -> None:
             self.page.get_by_role("link", name=child_name),
         )
 
+    @step("Search for child {1}")
+    def search_for_a_child_by_nhs_number(self, child: Child) -> None:
+        self.search_textbox.fill(child.nhs_number)
+
+        with self.page.expect_navigation():
+            self.search_button.click()
+
+        reload_until_element_is_visible(
+            self.page,
+            self.page.get_by_role("link", name=str(child)),
+        )
+
     @step("Click Advanced filters")
     def click_advanced_filters(self) -> None:
         self.advanced_filters_link.click()

mavis/test/pages/sessions/sessions_patient_page.py

@@ -220,7 +220,7 @@ def confirm_pre_screening_checks(
             expect(locator).to_be_visible()
 
         # need to wait for checkbox to load properly
-        self.page.wait_for_load_state("networkidle")
+        time.sleep(1)
 
         expect(self.pre_screening_checkbox).to_be_editable()
         self.pre_screening_checkbox.check()

tests/test_sessions.py

@@ -177,19 +177,31 @@ def test_attendance_filters_functionality(
 @issue("MAV-1018")
 @pytest.mark.bug
 def test_session_search_functionality(
-    setup_random_child,
+    setup_fixed_child,
+    children,
     page,
 ):
     """
     Test: Verify the search functionality within a session.
     Steps:
-    1. Open a session with a random child.
-    2. Use the search feature to look for children.
+    1. Open a session with a child.
+    2. Use the search feature to look for the child by name and NHS number
+    3. Use the search features with the year group filter
     Verification:
     - Search returns expected results for the session.
     """
+    child = children[Programme.HPV][0]
+
     SessionsOverviewPage(page).tabs.click_children_tab()
-    SessionsChildrenPage(page).search.verify_search()
+    SessionsChildrenPage(page).search.check_no_patients_found_when_expected()
+
+    SessionsChildrenPage(page).search.search_for_a_child_name(str(child))
+    SessionsChildrenPage(page).search.search_for_a_child_by_nhs_number(child)
+
+    SessionsChildrenPage(page).search.check_year_checkbox(child.year_group)
+
+    SessionsChildrenPage(page).search.search_for_a_child_name(str(child))
+    SessionsChildrenPage(page).search.search_for_a_child_by_nhs_number(child)
 
 
 @issue("MAV-1381")