Skip to content

Commit ece0f67

Browse files
authored
Merge pull request #842 from NHSDigital/small-type-fixes
Small type fixes
2 parents b0affd6 + fdcb440 commit ece0f67

File tree

2 files changed

+11
-14
lines changed

2 files changed

+11
-14
lines changed

mavis/test/constants.py

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -237,15 +237,14 @@ def pre_screening_checks(
237237

238238
@property
239239
def year_groups(self) -> list[int]:
240-
match self:
241-
case self.FLU:
242-
return list(range(12))
243-
case self.HPV:
244-
return list(range(8, 12))
245-
case self.MMR:
246-
return list(range(12))
247-
case self.MENACWY | self.TD_IPV:
248-
return list(range(9, 12))
240+
year_group_map = {
241+
self.FLU: list(range(12)),
242+
self.HPV: list(range(8, 12)),
243+
self.MMR: list(range(12)),
244+
self.MENACWY: list(range(9, 12)),
245+
self.TD_IPV: list(range(9, 12)),
246+
}
247+
return year_group_map[self]
249248

250249
@property
251250
def tally_categories(self) -> list[str]:

tests/test_reset.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -107,11 +107,9 @@ def test_pre_screening_questions_prefilled_for_multiple_vaccinations(
107107
SessionsChildrenPage(page).register_child_as_attending(child)
108108
SessionsChildrenPage(page).tabs.click_children_tab()
109109
SessionsChildrenPage(page).search.search_and_click_child(child)
110-
programmes = (
111-
[Programme.MENACWY, Programme.TD_IPV]
112-
if programme_group == "doubles"
113-
else [programme_group]
114-
)
110+
programmes = [
111+
programme for programme in Programme if programme.group == programme_group
112+
]
115113
for programme in programmes:
116114
consent_option = (
117115
ConsentOption.NASAL_SPRAY_OR_INJECTION

0 commit comments

Comments
 (0)