Refactor notice text into helper function

This is an effort to deduplicate the hardcoded values of the important notice text. In particular, this is triggered by the introduction of the notice for patients who don't want their parents notified after self-consent; this requires dynamic content.

Author: alistair-white-horne-tng

app/components/app_notices_table_component.rb

@@ -5,84 +5,38 @@ def initialize(
     deceased_patients:,
     invalidated_patients:,
     restricted_patients:,
-    gillick_no_notify_patients:
+    has_vaccination_records_dont_notify_parents_patients:
   )
     super
 
     @deceased_patients = deceased_patients
     @invalidated_patients = invalidated_patients
     @restricted_patients = restricted_patients
-    @gillick_no_notify_patients = gillick_no_notify_patients
+    @has_vaccination_records_dont_notify_parents_patients =
+      has_vaccination_records_dont_notify_parents_patients
   end
 
   def render?
     @deceased_patients.present? || @invalidated_patients.present? ||
-      @restricted_patients.present? || @gillick_no_notify_patients.present?
+      @restricted_patients.present? ||
+      @has_vaccination_records_dont_notify_parents_patients.present?
   end
 
   private
 
   def notices
-    (
-      deceased_notices + invalidated_notices + restricted_notices +
-        gillick_no_notify_notices
-    ).sort_by { _1[:date_time] }.reverse
-  end
-
-  def deceased_notices
-    @deceased_patients.map do |patient|
-      {
-        patient:,
-        date_time: patient.date_of_death_recorded_at,
-        message: "Record updated with child’s date of death"
-      }
-    end
-  end
-
-  def invalidated_notices
-    @invalidated_patients.map do |patient|
-      {
-        patient:,
-        date_time: patient.invalidated_at,
-        message: "Record flagged as invalid"
-      }
-    end
-  end
-
-  def restricted_notices
-    @restricted_patients.map do |patient|
-      {
-        patient:,
-        date_time: patient.restricted_at,
-        message: "Record flagged as sensitive"
-      }
-    end
-  end
-
-  def gillick_no_notify_notices
-
-    @gillick_no_notify_patients.map do |patient|
-      vaccination_records = patient.vaccination_records.includes(:programme).select { it.notify_parents == false }
-
-      {
-        patient:,
-        date_time:
-          patient
-            .vaccination_records
-            .reject(&:notify_parents?)
-            .max_by(&:created_at)
-            &.created_at || Time.current,
-        message:
-          "Child gave consent for #{format_vaccinations(vaccination_records)} under Gillick competence and " \
-            "does not want their parents to be notified. " \
-            "These records will not be automatically synced with GP records. " \
-            "Your team must let the child’s GP know they were vaccinated."
-      }
-    end
-  end
-
-  def format_vaccinations(vaccination_records)
-    "#{vaccination_records.map(&:programme).map(&:name).to_sentence} " \
-      "#{"vaccination".pluralize(vaccination_records.length)}"
+    all_patients =
+      (
+        @deceased_patients + @invalidated_patients + @restricted_patients +
+          @has_vaccination_records_dont_notify_parents_patients
+      ).uniq
+
+    notices =
+      all_patients.flat_map do |patient|
+        helpers
+          .patient_important_notices(patient)
+          .map { |notification| notification.merge(patient:) }
+      end
+    notices.sort_by { it[:date_time] }.reverse
   end
 end

app/components/app_patient_card_component.rb

@@ -4,23 +4,9 @@ class AppPatientCardComponent < ViewComponent::Base
   erb_template <<-ERB
     <%= render AppCardComponent.new(heading_level:, section: true) do |card| %>
       <% card.with_heading { "Child’s details" } %>
-
-      <% if patient.date_of_death.present? %>
-        <%= render AppStatusComponent.new(
-          text: "Record updated with child’s date of death"
-        ) %>
-      <% end %>
-
-      <% if patient.invalidated? %>
-        <%= render AppStatusComponent.new(
-          text: "Record flagged as invalid"
-        ) %>
-      <% end %>
-
-      <% if patient.restricted? %>
-        <%= render AppStatusComponent.new(
-          text: "Record flagged as sensitive"
-        ) %>
+      
+      <% helpers.patient_important_notices(patient).each do |notification| %>
+        <%= render AppStatusComponent.new(text: notification[:message]) %>
       <% end %>
 
       <%= render AppChildSummaryComponent.new(

app/controllers/imports/notices_controller.rb

@@ -9,6 +9,7 @@ def index
     @deceased_patients = policy_scope(Patient).deceased
     @invalidated_patients = policy_scope(Patient).invalidated
     @restricted_patients = policy_scope(Patient).restricted
-    @gillick_no_notify_patients = policy_scope(Patient).gillick_no_notify
+    @has_vaccination_records_dont_notify_parents_patients =
+      policy_scope(Patient).has_vaccination_records_dont_notify_parents
   end
 end

app/helpers/patients_helper.rb

@@ -52,4 +52,51 @@ def patient_year_group(patient, academic_year:)
   def patient_parents(patient)
     format_parents_with_relationships(patient.parent_relationships)
   end
+
+  def patient_important_notices(patient)
+    notifications = []
+
+    if patient.deceased?
+      notifications << {
+        date_time: patient.date_of_death_recorded_at,
+        message: "Record updated with child’s date of death"
+      }
+    end
+
+    if patient.invalidated?
+      notifications << {
+        date_time: patient.invalidated_at,
+        message: "Record flagged as invalid"
+      }
+    end
+
+    if patient.restricted?
+      notifications << {
+        date_time: patient.restricted_at,
+        message: "Record flagged as sensitive"
+      }
+    end
+
+    no_notify_vaccination_records =
+      patient.vaccination_records.select { it.notify_parents == false }
+    if no_notify_vaccination_records.any?
+      notifications << {
+        date_time: no_notify_vaccination_records.maximum(:performed_at),
+        message:
+          "Child gave consent for #{format_vaccinations(no_notify_vaccination_records)} under Gillick competence and " \
+            "does not want their parents to be notified. " \
+            "These records will not be automatically synced with GP records. " \
+            "Your team must let the child's GP know they were vaccinated."
+      }
+    end
+
+    notifications.sort_by { |notification| notification[:date_time] }.reverse
+  end
+
+  private
+
+  def format_vaccinations(vaccination_records)
+    "#{vaccination_records.map(&:programme).map(&:name).to_sentence} " \
+      "#{"vaccination".pluralize(vaccination_records.length)}"
+  end
 end

app/models/patient.rb

@@ -122,7 +122,7 @@ class Patient < ApplicationRecord
   scope :not_deceased, -> { where(date_of_death: nil) }
   scope :restricted, -> { where.not(restricted_at: nil) }
 
-  scope :gillick_no_notify,
+  scope :has_vaccination_records_dont_notify_parents,
         -> do
           joins(:vaccination_records).where(
             vaccination_records: {
@@ -132,7 +132,12 @@ class Patient < ApplicationRecord
         end
 
   scope :with_notice,
-        -> { (deceased + restricted + invalidated + gillick_no_notify).uniq }
+        -> do
+          (
+            deceased + restricted + invalidated +
+              has_vaccination_records_dont_notify_parents
+          ).uniq
+        end
 
   scope :appear_in_programmes,
         ->(programmes, academic_year:) do

app/views/imports/notices/index.html.erb

@@ -4,12 +4,12 @@
 
 <%= render AppImportsNavigationComponent.new(active: :notices) %>
 
-<% if @deceased_patients.any? || @invalidated_patients.any? || @restricted_patients.any? || @gillick_no_notify_patients.any? %>
+<% if @deceased_patients.any? || @invalidated_patients.any? || @restricted_patients.any? || @has_vaccination_records_dont_notify_parents_patients.any? %>
   <%= render AppNoticesTableComponent.new(
         deceased_patients: @deceased_patients,
         invalidated_patients: @invalidated_patients,
         restricted_patients: @restricted_patients,
-        gillick_no_notify_patients: @gillick_no_notify_patients,
+        has_vaccination_records_dont_notify_parents_patients: @has_vaccination_records_dont_notify_parents_patients,
       ) %>
 <% else %>
   <p class="nhsuk-body"><%= t(".no_results") %></p>