Ensure vaccination records without vaccines are handled correctly (#3220)

A number of components currently break when they try to render a
vaccination record that doesn't have a vaccine. This is a valid state
for a historical vaccination record that was imported and performed
outside of the service, so it needs to be handled correctly.

Author: thomasleese

app/components/app_activity_log_component.rb

@@ -208,7 +208,11 @@ def vaccination_events
     vaccination_records.flat_map do |vaccination_record|
       title =
         if vaccination_record.administered?
-          "Vaccinated with #{vaccination_record.vaccine.brand}"
+          if (vaccine = vaccination_record.vaccine)
+            "Vaccinated with #{vaccine.brand}"
+          else
+            "Vaccinated"
+          end
         else
           "Vaccination not given: #{vaccination_record.human_enum_name(:outcome)}"
         end

app/components/app_outcome_banner_component.rb

@@ -74,9 +74,19 @@ def show_location?
 
   def vaccine_summary
     type = vaccination_record.programme.name
-    brand = vaccination_record.vaccine.brand
-    batch = vaccination_record.batch.name
-    "#{type} (#{brand}, #{batch})"
+    batch = vaccination_record.batch&.name
+    brand =
+      (vaccination_record.vaccine || vaccination_record.batch&.vaccine)&.brand
+
+    if brand.present? && batch.present?
+      "#{type} (#{brand}, #{batch})"
+    elsif brand.present?
+      "#{type} (#{brand})"
+    elsif batch.present?
+      "#{type} (#{batch})"
+    else
+      type
+    end
   end
 
   def reason_do_not_vaccinate

app/components/app_patient_vaccination_table_component.html.erb

@@ -15,7 +15,12 @@
         <% body.with_row do |row| %>
           <% row.with_cell do %>
             <span class="nhsuk-table-responsive__heading">Vaccine</span>
-            <% label = "#{vaccination_record.vaccine.brand} (#{vaccination_record.programme.name})" %>
+            <% label = if (vaccine = vaccination_record.vaccine)
+                   "#{vaccine.brand} (#{vaccination_record.programme.name})"
+                 else
+                   vaccination_record.programme.name
+                 end %>
+
             <%= link_to label, programme_vaccination_record_path(vaccination_record.programme, vaccination_record) %>
           <% end %>
           <% row.with_cell do %>

app/jobs/mesh_dps_export_job.rb

@@ -7,7 +7,12 @@ def perform
     return unless Flipper.enabled? :mesh_jobs
 
     Programme.find_each do |programme|
-      if programme.vaccination_records.administered.unexported.any?
+      if programme
+           .vaccination_records
+           .administered
+           .unexported
+           .recorded_in_service
+           .any?
         dps_export = DPSExport.create!(programme:)
         response =
           MESH.send_file(data: dps_export.csv, to: Settings.mesh.dps_mailbox)

app/models/dps_export.rb

@@ -59,6 +59,6 @@ def set_filename
 
   def set_vaccination_records
     self.vaccination_records =
-      programme.vaccination_records.administered.unexported
+      programme.vaccination_records.administered.unexported.recorded_in_service
   end
 end

app/models/vaccination_record.rb

@@ -92,6 +92,7 @@ class VaccinationRecord < ApplicationRecord
   has_one :organisation, through: :session
   has_one :team, through: :session
 
+  scope :recorded_in_service, -> { where.not(session: nil) }
   scope :unexported, -> { where.missing(:dps_exports) }
 
   scope :with_pending_changes,

spec/components/app_activity_log_component_spec.rb

@@ -402,4 +402,23 @@
                      date: "1 June 2024 at 12:00pm",
                      by: "Nurse Joy"
   end
+
+  describe "vaccination records" do
+    context "without a vaccine" do
+      before do
+        create(
+          :vaccination_record,
+          patient:,
+          programme: programmes.first,
+          vaccine: nil,
+          performed_at: Time.zone.parse("2024-05-31 13:00")
+        )
+      end
+
+      include_examples "card",
+                       title: "Vaccinated",
+                       date: "31 May 2024 at 1:00pm",
+                       programme: "HPV"
+    end
+  end
 end

spec/components/app_outcome_banner_component_spec.rb

@@ -93,6 +93,14 @@
 
       it { should have_text("Vaccinator\nUnknown") }
     end
+
+    context "when the vaccination is historical" do
+      before do
+        vaccination_record.update!(session: nil, location_name: "Unknown")
+      end
+
+      it { should have_text("Vaccinated") }
+    end
   end
 
   context "state is triaged_do_not_vaccinate" do

spec/components/app_patient_vaccination_table_component_spec.rb

@@ -34,20 +34,38 @@
       )
     end
     let(:session) { create(:session, location:, programmes: [programme]) }
-    let(:vaccination_record) do
-      create(
-        :vaccination_record,
-        patient:,
-        programme:,
-        session:,
-        performed_at: Time.zone.local(2024, 1, 1)
-      )
+
+    context "with a vaccine" do
+      before do
+        create(
+          :vaccination_record,
+          patient:,
+          programme:,
+          session:,
+          performed_at: Time.zone.local(2024, 1, 1)
+        )
+      end
+
+      it { should have_link("Gardasil 9 (HPV)") }
+      it { should have_content("Test School, Waterloo Road, London, SE1 8TY") }
+      it { should have_content("1 January 2024") }
     end
 
-    before { vaccination_record }
+    context "without a vaccine" do
+      before do
+        create(
+          :vaccination_record,
+          patient:,
+          programme:,
+          session:,
+          performed_at: Time.zone.local(2024, 1, 1),
+          vaccine: nil
+        )
+      end
 
-    it { should have_link("Gardasil 9 (HPV)") }
-    it { should have_content("Test School, Waterloo Road, London, SE1 8TY") }
-    it { should have_content("1 January 2024") }
+      it { should have_link("HPV") }
+      it { should have_content("Test School, Waterloo Road, London, SE1 8TY") }
+      it { should have_content("1 January 2024") }
+    end
   end
 end

spec/factories/vaccination_records.rb

@@ -70,11 +70,13 @@
     delivery_method { "intramuscular" }
 
     vaccine do
-      programme.vaccines.active.first || association(:vaccine, programme:)
+      if session
+        programme.vaccines.active.first || association(:vaccine, programme:)
+      end
     end
 
     batch do
-      association :batch, organisation:, vaccine:, strategy: :create if vaccine
+      association(:batch, organisation:, vaccine:, strategy: :create) if vaccine
     end
 
     performed_by