Post release of v2.1.3 remove old service

- The old service is replaced by identical service with new name
  - This used the module and simplifies setup/running/developing in the
    future

Author: TheOneFromNorway

terraform/app/ecs.tf

@@ -1,111 +1,3 @@
-#TODO: Remove after release
-resource "aws_security_group" "ecs_service_sg" {
-  name        = "ecs-service-sg"
-  description = "Security Group for communication with ECS"
-  vpc_id      = aws_vpc.application_vpc.id
-  lifecycle {
-    ignore_changes = [description]
-  }
-}
-
-#TODO: Remove after release
-resource "aws_security_group_rule" "ecs_ingress_http" {
-  type                     = "ingress"
-  from_port                = 4000
-  to_port                  = 4000
-  protocol                 = "tcp"
-  security_group_id        = aws_security_group.ecs_service_sg.id
-  source_security_group_id = aws_security_group.lb_service_sg.id
-  lifecycle {
-    create_before_destroy = true
-  }
-}
-
-#TODO: Remove after release
-resource "aws_security_group_rule" "ecs_talk_to_internet" {
-  type              = "egress"
-  from_port         = 0
-  to_port           = 0
-  protocol          = "-1"
-  cidr_blocks       = ["0.0.0.0/0"]
-  security_group_id = aws_security_group.ecs_service_sg.id
-}
-
-#TODO: Remove after release
-resource "aws_ecs_service" "service" {
-  name                              = "mavis-${var.environment}"
-  cluster                           = aws_ecs_cluster.cluster.id
-  task_definition                   = aws_ecs_task_definition.task_definition.arn
-  desired_count                     = var.minimum_web_replicas
-  launch_type                       = "FARGATE"
-  enable_execute_command            = true
-  health_check_grace_period_seconds = 60
-
-  network_configuration {
-    subnets         = [aws_subnet.private_subnet_a.id, aws_subnet.private_subnet_b.id]
-    security_groups = [aws_security_group.ecs_service_sg.id]
-  }
-
-  load_balancer {
-    target_group_arn = aws_lb_target_group.blue.arn
-    container_name   = "mavis-${var.environment}"
-    container_port   = 4000
-  }
-  deployment_controller {
-    type = "CODE_DEPLOY"
-  }
-
-  lifecycle {
-    ignore_changes = [
-      load_balancer,
-      task_definition,
-      # desired_count TODO: uncomment this when we proceed with enabling autoscaler
-    ]
-  }
-}
-
-#TODO: Remove after release
-resource "aws_ecs_task_definition" "task_definition" {
-  family                   = "task-definition-${var.environment}"
-  requires_compatibilities = ["FARGATE"]
-  network_mode             = "awsvpc"
-  cpu                      = 1024
-  memory                   = 2048
-  execution_role_arn       = aws_iam_role.ecs_task_execution_role.arn
-  task_role_arn            = aws_iam_role.ecs_task_role.arn
-  container_definitions = jsonencode([
-    {
-      name      = "mavis-${var.environment}"
-      image     = "${var.account_id}.dkr.ecr.eu-west-2.amazonaws.com/${var.docker_image}@${var.image_digest}"
-      essential = true
-      portMappings = [
-        {
-          containerPort = 4000
-          hostPort      = 4000
-        }
-      ]
-      environment = concat(local.task_envs, [{ name = "SERVER_TYPE", value = "web" }])
-      secrets     = local.task_secrets
-      logConfiguration = {
-        logDriver = "awslogs"
-        options = {
-          awslogs-group         = aws_cloudwatch_log_group.ecs_log_group.name
-          awslogs-region        = var.region
-          awslogs-stream-prefix = "${var.environment}-logs"
-        }
-      }
-      healthCheck = {
-        command     = ["CMD-SHELL", "curl -f http://localhost:4000/up || exit 1"]
-        interval    = 30
-        timeout     = 5
-        retries     = 3
-        startPeriod = 10
-      }
-    }
-  ])
-  depends_on = [aws_cloudwatch_log_group.ecs_log_group]
-}
-
 resource "aws_security_group_rule" "web_service_alb_ingress" {
   type                     = "ingress"
   from_port                = 4000

terraform/app/rds.tf

@@ -24,19 +24,6 @@ resource "aws_security_group_rule" "rds_ecs_ingress" {
   }
 }
 
-#TODO: Remove after release
-resource "aws_security_group_rule" "rds_ingress" {
-  type                     = "ingress"
-  from_port                = 5432
-  to_port                  = 5432
-  protocol                 = "tcp"
-  security_group_id        = aws_security_group.rds_security_group.id
-  source_security_group_id = aws_security_group.ecs_service_sg.id
-  lifecycle {
-    create_before_destroy = true
-  }
-}
-
 resource "aws_db_subnet_group" "aurora_subnet_group" {
   name        = var.resource_name.dbsubnet_group
   description = "Group of private subnets for Aurora Serverless v2 cluster."