Merge pull request #4266 from nhsuk/fix-sync-record-on-consent-change

Sync vaccs record to API if `notify_parents` has changed due to consent changes

Author: alistair-white-horne-tng

app/models/concerns/vaccination_record_sync_to_nhs_immunisations_api_concern.rb

@@ -5,15 +5,11 @@ module VaccinationRecordSyncToNHSImmunisationsAPIConcern
 
   included do
     scope :syncable_to_nhs_immunisations_api,
-          -> do
-            includes(:patient, :programme).where(
-              notify_parents: true
-            ).recorded_in_service
-          end
+          -> { includes(:patient, :programme).recorded_in_service }
   end
 
   def syncable_to_nhs_immunisations_api?
-    recorded_in_service? && notify_parents
+    recorded_in_service?
   end
 
   def sync_status

spec/features/invalidate_consent_spec.rb

@@ -52,8 +52,11 @@
 
   scenario "Given self consent, and requested parents aren't notified, and vaccinated, then invalidate" do
     given_i_am_signed_in
-    and_self_consent_has_been_given
-    and_patient_has_been_vaccinated_with_no_parent_notification
+    and_the_api_feature_flag_is_enabled
+    and_self_consent_has_been_given_with_no_parent_notification
+
+    when_the_patient_has_been_vaccinated_with_no_parent_notification
+    then_the_record_is_not_synced_to_the_imms_api
 
     when_i_go_to_the_patient
     then_i_see_the_self_consent
@@ -64,7 +67,8 @@
     when_i_fill_in_the_notes
     and_i_click_invalidate_consent
     then_i_see_the_consent_has_been_invalidated
-    and_the_vaccination_record_is_updated_to_notify_parents
+    and_the_vaccination_record_is_updated_to_notify_parents_true
+    and_the_vaccination_record_is_synced_to_the_imms_api
   end
 
   def given_i_am_signed_in
@@ -76,6 +80,11 @@ def given_i_am_signed_in
     sign_in team.users.first
   end
 
+  def and_the_api_feature_flag_is_enabled
+    Flipper.enable(:enqueue_sync_vaccination_records_to_nhs)
+    Flipper.enable(:immunisations_fhir_api_integration)
+  end
+
   def and_consent_has_been_given
     @consent =
       create(:consent, :given, patient: @patient, programme: @programme)
@@ -161,7 +170,7 @@ def and_i_am_not_able_to_record_a_vaccination
     expect(page).not_to have_content("ready for their HPV vaccination?")
   end
 
-  def and_self_consent_has_been_given
+  def and_self_consent_has_been_given_with_no_parent_notification
     @consent =
       create(
         :consent,
@@ -178,7 +187,7 @@ def and_self_consent_has_been_given
     )
   end
 
-  def and_patient_has_been_vaccinated_with_no_parent_notification
+  def when_the_patient_has_been_vaccinated_with_no_parent_notification
     @vaccination_record =
       create(
         :vaccination_record,
@@ -197,7 +206,20 @@ def when_i_click_on_the_self_consent
     click_on "Child (Gillick competent)"
   end
 
-  def and_the_vaccination_record_is_updated_to_notify_parents
+  def and_the_vaccination_record_is_updated_to_notify_parents_true
     expect(@vaccination_record.reload.notify_parents).to be true
   end
+
+  def then_the_record_is_not_synced_to_the_imms_api
+    @stubbed_post_request =
+      stub_immunisations_api_post(uuid: @vaccination_record.uuid)
+
+    perform_enqueued_jobs(only: SyncVaccinationRecordToNHSJob)
+    expect(@stubbed_post_request).not_to have_been_requested
+  end
+
+  def and_the_vaccination_record_is_synced_to_the_imms_api
+    perform_enqueued_jobs(only: SyncVaccinationRecordToNHSJob)
+    expect(@stubbed_post_request).to have_been_requested
+  end
 end