[PRMP-460] rename cloudfront_subdomain var

Signed-off-by: NogaNHS <[email protected]>

Author: NogaNHS

infrastructure/dev.tfvars

@@ -3,7 +3,7 @@ owner                             = "nhse/ndr-team"
 domain                            = "access-request-fulfilment.patient-deductions.nhs.uk"
 certificate_domain                = "access-request-fulfilment.patient-deductions.nhs.uk"
 certificate_subdomain_name_prefix = "api-"
-cloudfront_subdomain_prefix       = "file."
+cloudfront_subdomain      = "file."
 
 standalone_vpc_tag    = "ndr-dev"
 standalone_vpc_ig_tag = "ndr-dev"

infrastructure/preprod.tfvars

@@ -4,7 +4,7 @@ owner                             = "nhse/ndr-team"
 domain                            = "national-document-repository.nhs.uk"
 certificate_domain                = "pre-prod.national-document-repository.nhs.uk"
 certificate_subdomain_name_prefix = "api."
-cloudfront_subdomain_prefix       = "file."
+cloudfront_subdomain       = "file."
 
 standalone_vpc_tag    = "ndr-pre-prod"
 standalone_vpc_ig_tag = "ndr-pre-prod"

infrastructure/prod.tfvars

@@ -4,7 +4,7 @@ owner                             = "nhse/ndr-team"
 domain                            = "national-document-repository.nhs.uk"
 certificate_domain                = "national-document-repository.nhs.uk"
 certificate_subdomain_name_prefix = "api."
-cloudfront_subdomain_prefix       = "file."
+cloudfront_subdomain       = "file."
 
 standalone_vpc_tag    = "ndr-prod"
 standalone_vpc_ig_tag = "ndr-prod"

infrastructure/test.tfvars

@@ -4,7 +4,7 @@ owner                             = "nhse/ndr-team"
 domain                            = "access-request-fulfilment.patient-deductions.nhs.uk"
 certificate_domain                = "ndr-test.access-request-fulfilment.patient-deductions.nhs.uk"
 certificate_subdomain_name_prefix = "api."
-cloudfront_subdomain_prefix       = "file."
+cloudfront_subdomain       = "file."
 
 standalone_vpc_tag    = "ndr-test"
 standalone_vpc_ig_tag = "ndr-test"

infrastructure/variable.tf

@@ -26,8 +26,8 @@ variable "certificate_subdomain_name_prefix_mtls" {
   default     = "mtls"
 }
 
-variable "cloudfront_subdomain_prefix" {
-  description = "Prefix to add to CloudFront custom domain subdomain."
+variable "cloudfront_subdomain" {
+  description = "CloudFront custom subdomain."
   type        = string
   default     = "file."
 }
@@ -280,7 +280,7 @@ locals {
 
   mtls_api_gateway_full_domain_name = contains(["prod"], terraform.workspace) ? "${var.certificate_subdomain_name_prefix_mtls}.${var.domain}" : "${var.certificate_subdomain_name_prefix_mtls}.${terraform.workspace}.${var.domain}"
 
-  cloudfront_full_domain_name = contains(["prod"], terraform.workspace) ? "${var.cloudfront_subdomain_prefix}${var.domain}" : "${var.cloudfront_subdomain_prefix}${terraform.workspace}.${var.domain}"
+  cloudfront_full_domain_name = contains(["prod"], terraform.workspace) ? "${var.cloudfront_subdomain}${var.domain}" : "${var.cloudfront_subdomain}${terraform.workspace}.${var.domain}"
 
   current_region     = data.aws_region.current.name
   current_account_id = data.aws_caller_identity.current.account_id