[PRM-134-v2] more exploration of custom banding within alarms

Author: steph-torres-nhs

infrastructure/lambda-search-patient.tf

@@ -46,7 +46,7 @@ resource "aws_cloudwatch_metric_alarm" "error_alarm_count_low" {
   }
   metric_query {
     id          = "error"
-    label       = "error count for search patient, high if about 4, low if between 1 and 3"
+    label       = "error count for search patient, high if above 7, low if between 1 and 3, med between 4 - 6, high 7+"
     return_data = true
     expression  = "IF(m1 >= 1 AND m1 <= 3, 1, 0)"
   }
@@ -69,9 +69,9 @@ resource "aws_cloudwatch_metric_alarm" "error_alarm_count_low" {
 
 resource "aws_cloudwatch_metric_alarm" "error_alarm_count_medium" {
   alarm_name          = "search_patient_error_count_medium"
-  alarm_description   = "Triggers when search patient lambda error count is between 1 and 3 within 2mins"
+  alarm_description   = "Triggers when search patient lambda error count is between 4 and 6 within 2mins"
   comparison_operator = "GreaterThanThreshold"
-  threshold           = 4
+  threshold           = 0
   evaluation_periods  = 1
   alarm_actions       = [module.search_patient_alarm_topic.arn]
   ok_actions          = [module.search_patient_alarm_topic.arn]
@@ -100,28 +100,64 @@ resource "aws_cloudwatch_metric_alarm" "error_alarm_count_medium" {
     }
   }
 }
+
 resource "aws_cloudwatch_metric_alarm" "error_alarm_count_high" {
   alarm_name          = "search_patient_error_count_high"
-  alarm_description   = "Triggers when search patient lambda error count is above 3 within 2mins"
+  alarm_description   = "Triggers when search patient lambda error count is about 7"
   comparison_operator = "GreaterThanThreshold"
+  threshold           = 0
   evaluation_periods  = 1
   alarm_actions       = [module.search_patient_alarm_topic.arn]
   ok_actions          = [module.search_patient_alarm_topic.arn]
-  threshold           = 7
-  period              = 120
-  dimensions = {
-    FunctionName = module.search-patient-details-lambda.function_name
-  }
-  metric_name = "Errors"
-  statistic   = "Sum"
-  namespace   = "AWS/Lambda"
   tags = {
     alerting_type = "KPI"
     alarm_group   = module.search-patient-details-lambda.function_name
   }
+  metric_query {
+    id          = "error"
+    label       = "error count for search patient, high if about 4, low if between 1 and 3"
+    return_data = true
+    expression  = "IF(m1 >= 7, 1, 0)"
+  }
+
+  metric_query {
+    id = "m1"
+
+    metric {
+      metric_name = "Errors"
+      namespace   = "AWS/Lambda"
+      period      = 120
+      stat        = "Sum"
+      dimensions = {
+        FunctionName = module.search-patient-details-lambda.function_name
+      }
+    }
+  }
 }
 
 
+# resource "aws_cloudwatch_metric_alarm" "error_alarm_count_high" {
+#   alarm_name          = "search_patient_error_count_high"
+#   alarm_description   = "Triggers when search patient lambda error count is above 7 within 2mins"
+#   comparison_operator = "GreaterThanThreshold"
+#   evaluation_periods  = 1
+#   alarm_actions       = [module.search_patient_alarm_topic.arn]
+#   ok_actions          = [module.search_patient_alarm_topic.arn]
+#   threshold           = 7
+#   period              = 120
+#   dimensions = {
+#     FunctionName = module.search-patient-details-lambda.function_name
+#   }
+#   metric_name = "Errors"
+#   statistic   = "Sum"
+#   namespace   = "AWS/Lambda"
+#   tags = {
+#     alerting_type = "KPI"
+#     alarm_group   = module.search-patient-details-lambda.function_name
+#   }
+# }
+
+
 
 module "search_patient_alarm_topic" {
   source                = "./modules/sns"