Skip to content

Commit 24efda0

Browse files
committed
[NDR-232] Removing references to DynamoDB for state locking
1 parent d293d92 commit 24efda0

File tree

3 files changed

+0
-29
lines changed

3 files changed

+0
-29
lines changed

bootstrap/README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ No modules.
1919

2020
| Name | Type |
2121
|------|------|
22-
| [aws_dynamodb_table.dynamodb_terraform_state_lock](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/dynamodb_table) | resource |
2322
| [aws_kms_key.ndr_state_key](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/kms_key) | resource |
2423
| [aws_s3_bucket.ndr_lock_bucket](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/s3_bucket) | resource |
2524
| [aws_s3_bucket_acl.ndr_lock_bucket_acl](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/s3_bucket_acl) | resource |

bootstrap/main.tf

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -67,21 +67,6 @@ resource "aws_s3_bucket_public_access_block" "public_access_block" {
6767
restrict_public_buckets = true
6868
}
6969

70-
resource "aws_dynamodb_table" "dynamodb_terraform_state_lock" {
71-
name = "ndr-terraform-locks"
72-
hash_key = "LockID"
73-
read_capacity = 20
74-
write_capacity = 20
75-
76-
attribute {
77-
name = "LockID"
78-
type = "S"
79-
}
80-
lifecycle {
81-
prevent_destroy = true
82-
}
83-
}
84-
8570
data "aws_caller_identity" "current" {}
8671

8772
variable "region" {

scripts/cleanup_terraform_states.py

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -47,18 +47,6 @@ def remove_object_versions(self, tf_bucket: str, folder_prefix: str) -> None:
4747
)
4848
print("All object versions deleted.")
4949

50-
def delete_record_in_dynamo(self, tf_bucket: str, file_key: str):
51-
print(f"Deleting sandbox tfstate DynamoDB record")
52-
table_name = "ndr-terraform-locks"
53-
lock_id = f'{tf_bucket}/{file_key}-md5'
54-
55-
self.dynamo_client.delete_item(
56-
TableName=table_name,
57-
Key={'LockID': {'S': lock_id}},
58-
ConditionExpression="attribute_exists(LockID)"
59-
)
60-
print("DynamoDB record deleted successfully")
61-
6250

6351
def main(self, sandbox: str):
6452
tf_bucket = self.get_terraform_bucket()
@@ -71,7 +59,6 @@ def main(self, sandbox: str):
7159
if parent_folder == sandbox:
7260
folder_prefix = f"{self.env_folder}{parent_folder}/"
7361
self.remove_object_versions(tf_bucket=tf_bucket, folder_prefix=folder_prefix)
74-
self.delete_record_in_dynamo(tf_bucket, key)
7562

7663
if __name__ == '__main__':
7764
sandbox = sys.argv[1]

0 commit comments

Comments
 (0)