PRMT-462- addressed comments

PedroSoaresNHS · PedroSoaresNHS · commit 2ed90bccf2cb · 2025-07-23T16:43:05.000+01:00
diff --git a/infrastructure/iam.tf b/infrastructure/iam.tf
@@ -183,7 +183,7 @@ data "aws_iam_policy_document" "lambda_toggle_bulk_upload_document" {
     ]
 
     resources = [
-      aws_lambda_event_source_mapping.bulk_upload_esm.arn
+      aws_lambda_event_source_mapping.bulk_upload_lambda.arn
     ]
   }
 }
diff --git a/infrastructure/lambda-bulk-upload.tf b/infrastructure/lambda-bulk-upload.tf
@@ -55,10 +55,10 @@ module "bulk-upload-lambda" {
   ]
 }
 
-resource "aws_lambda_event_source_mapping" "bulk_upload_esm" {
+resource "aws_lambda_event_source_mapping" "bulk_upload_lambda" {
   event_source_arn = module.sqs-lg-bulk-upload-metadata-queue.sqs_arn
   function_name    = module.bulk-upload-lambda.lambda_arn
-  enabled          = false # Disabled by default; scheduler lambda will control
+  enabled          = false # Disabled by default; toggle-bulk-upload-lambda will control
   batch_size       = 10
   scaling_config {
     maximum_concurrency = local.bulk_upload_lambda_concurrent_limit
diff --git a/infrastructure/lambda-toggle-bulk-upload.tf b/infrastructure/lambda-toggle-bulk-upload.tf
@@ -10,7 +10,7 @@ module "toggle-bulk-upload-lambda" {
   ]
 
   lambda_environment_variables = {
-    ESM_UUID = aws_lambda_event_source_mapping.bulk_upload_esm.uuid
+    ESM_UUID = aws_lambda_event_source_mapping.bulk_upload_lambda.uuid
   }
 
   is_gateway_integration_needed = false

Original file line number	Diff line number	Diff line change
`@@ -183,7 +183,7 @@ data "aws_iam_policy_document" "lambda_toggle_bulk_upload_document" {`
`183`	`183`	`]`
`184`	`184`
`185`	`185`	`resources = [`
`186`		`- aws_lambda_event_source_mapping.bulk_upload_esm.arn`
	`186`	`+ aws_lambda_event_source_mapping.bulk_upload_lambda.arn`
`187`	`187`	`]`
`188`	`188`	`}`
`189`	`189`	`}`
Original file line number	Diff line number	Diff line change
`@@ -55,10 +55,10 @@ module "bulk-upload-lambda" {`
`55`	`55`	`]`
`56`	`56`	`}`
`57`	`57`
`58`		`-resource "aws_lambda_event_source_mapping" "bulk_upload_esm" {`
	`58`	`+resource "aws_lambda_event_source_mapping" "bulk_upload_lambda" {`
`59`	`59`	`event_source_arn = module.sqs-lg-bulk-upload-metadata-queue.sqs_arn`
`60`	`60`	`function_name = module.bulk-upload-lambda.lambda_arn`
`61`		`- enabled = false # Disabled by default; scheduler lambda will control`
	`61`	`+ enabled = false # Disabled by default; toggle-bulk-upload-lambda will control`
`62`	`62`	`batch_size = 10`
`63`	`63`	`scaling_config {`
`64`	`64`	`maximum_concurrency = local.bulk_upload_lambda_concurrent_limit`
Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ module "toggle-bulk-upload-lambda" {`
`10`	`10`	`]`
`11`	`11`
`12`	`12`	`lambda_environment_variables = {`
`13`		`- ESM_UUID = aws_lambda_event_source_mapping.bulk_upload_esm.uuid`
	`13`	`+ ESM_UUID = aws_lambda_event_source_mapping.bulk_upload_lambda.uuid`
`14`	`14`	`}`
`15`	`15`
`16`	`16`	`is_gateway_integration_needed = false`