[PRM-134-v2] address PR comments

Author: steph-torres-nhs

infrastructure/lambda-edge-presign.tf

@@ -33,7 +33,7 @@ resource "aws_cloudwatch_metric_alarm" "edge_presign_lambda_error" {
   ok_actions          = [module.edge_presign_alarm_topic.arn]
   depends_on          = [module.edge-presign-lambda, aws_sns_topic.alarm_notifications_topic[0]]
   alarm_description   = "Triggers when Edge Presign Lambda errors."
-  count               = local.is_sandbox ? 1 : 1
+  count               = local.is_sandbox ? 0 : 1
 }
 
 module "edge_presign_alarm_topic" {

infrastructure/lambda-search-patient.tf

@@ -125,30 +125,6 @@ resource "aws_cloudwatch_metric_alarm" "error_alarm_count_high" {
   }
 }
 
-
-# resource "aws_cloudwatch_metric_alarm" "error_alarm_count_high" {
-#   alarm_name          = "search_patient_error_count_high"
-#   alarm_description   = "Triggers when search patient lambda error count is above 7 within 2mins"
-#   comparison_operator = "GreaterThanThreshold"
-#   evaluation_periods  = 1
-#   alarm_actions       = [module.search_patient_alarm_topic.arn]
-#   ok_actions          = [module.search_patient_alarm_topic.arn]
-#   threshold           = 7
-#   period              = 120
-#   dimensions = {
-#     FunctionName = module.search-patient-details-lambda.function_name
-#   }
-#   metric_name = "Errors"
-#   statistic   = "Sum"
-#   namespace   = "AWS/Lambda"
-#   tags = {
-#     alerting_type = "KPI"
-#     alarm_group   = module.search-patient-details-lambda.function_name
-#   }
-# }
-
-
-
 module "search_patient_alarm_topic" {
   source                = "./modules/sns"
   sns_encryption_key_id = module.sns_encryption_key.id