[PRMP-1580] Removed implicit dependencies, extended Lambda timeout

Author: AndyFlintAnswerDigital

infrastructure/lambda-nhs-oauth-token-generator.tf

@@ -2,7 +2,7 @@ module "nhs-oauth-token-generator-lambda" {
   source         = "./modules/lambda"
   name           = "NhsOauthTokenGeneratorLambda"
   handler        = "handlers.nhs_oauth_token_generator_handler.lambda_handler"
-  lambda_timeout = 60
+  lambda_timeout = 120
   iam_role_policy_documents = [
     aws_iam_policy.ssm_access_policy.policy,
     module.ndr-app-config.app_config_policy
@@ -26,7 +26,6 @@ module "nhs-oauth-token-generator-alarm" {
   namespace            = "AWS/Lambda"
   alarm_actions        = [module.nhs-oauth-token-generator-alarm-topic.arn]
   ok_actions           = [module.nhs-oauth-token-generator-alarm-topic.arn]
-  depends_on           = [module.nhs-oauth-token-generator-lambda, module.nhs-oauth-token-generator-alarm-topic]
 }
 
 module "nhs-oauth-token-generator-alarm-topic" {
@@ -56,6 +55,4 @@ module "nhs-oauth-token-generator-alarm-topic" {
       }
     ]
   })
-
-  depends_on = [module.nhs-oauth-token-generator-lambda, module.sns_encryption_key]
 }

infrastructure/schedules.tf

@@ -172,25 +172,16 @@ resource "aws_cloudwatch_event_rule" "nhs_oauth_token_generator_schedule" {
   schedule_expression = "rate(9 minutes)"
 }
 
-resource "aws_cloudwatch_event_target" "nhs_oauth_token_generator_schedule_event" {
+resource "aws_cloudwatch_event_target" "nhs_oauth_token_generator_schedule" {
   rule      = aws_cloudwatch_event_rule.nhs_oauth_token_generator_schedule.name
   target_id = "nhs_oauth_token_generator_schedule"
-
   arn = module.nhs-oauth-token-generator-lambda.lambda_arn
-  depends_on = [
-    module.nhs-oauth-token-generator-lambda,
-    aws_cloudwatch_event_rule.nhs_oauth_token_generator_schedule
-  ]
 }
 
-resource "aws_lambda_permission" "nhs_oauth_token_generator_schedule_permission" {
+resource "aws_lambda_permission" "nhs_oauth_token_generator_schedule" {
   statement_id  = "AllowExecutionFromCloudWatch"
   action        = "lambda:InvokeFunction"
   function_name = module.nhs-oauth-token-generator-lambda.function_name
   principal     = "events.amazonaws.com"
   source_arn    = aws_cloudwatch_event_rule.nhs_oauth_token_generator_schedule.arn
-  depends_on = [
-    module.nhs-oauth-token-generator-lambda,
-    aws_cloudwatch_event_rule.nhs_oauth_token_generator_schedule
-  ]
 }