[PRM-459] refactor, rename data resources

Author: steph-torres-nhs

infrastructure/lambda-send-feedback.tf

@@ -9,19 +9,19 @@ locals {
   )
 }
 
-data "aws_ssm_parameter" "itoc_feedback_webhook" {
+data "aws_ssm_parameter" "itoc_feedback_testing_teams_webhook" {
   name = "/ndr/itoc/feedback_testing/teams_webhook"
 }
 
-data "aws_ssm_parameter" "itoc_testing_email_address" {
+data "aws_ssm_parameter" "itoc_feedback_testing_email_address" {
   name = "/ndr/itoc/feedback_testing/email_address"
 }
 
-data "aws_ssm_parameter" "itoc_testing_slack_channel_id" {
+data "aws_ssm_parameter" "itoc_feedback_testing_slack_channel_id" {
   name = "/ndr/itoc/feedback_testing/slack/channel_id"
 }
 
-data "aws_ssm_parameter" "itoc_testing_slack_bot_token" {
+data "aws_ssm_parameter" "itoc_feedback_testing_slack_bot_token" {
   name = "/ndr/itoc/feedback_testing/slack/bot_token"
 }
 
@@ -99,12 +99,10 @@ module "send-feedback-lambda" {
     FROM_EMAIL_ADDRESS            = local.ses_feedback_sender_email_address
     EMAIL_SUBJECT                 = "Digitised Lloyd George feedback"
     EMAIL_RECIPIENT_SSM_PARAM_KEY = local.feedback_recipient_list_ssm_param_key
-    ITOC_TESTING_TEAMS_WEBHOOK    = data.aws_ssm_parameter.itoc_feedback_webhook.value
-    ITOC_TESTING_EMAIL_ADDRESS    = data.aws_ssm_parameter.itoc_testing_email_address.value
-    ITOC_TESTING_CHANNEL_ID       = data.aws_ssm_parameter.itoc_testing_slack_channel_id.value
-    ITOC_TESTING_SLACK_BOT_TOKEN  = data.aws_ssm_parameter.itoc_testing_slack_bot_token.value
-
-
+    ITOC_TESTING_TEAMS_WEBHOOK    = data.aws_ssm_parameter.itoc_feedback_testing_teams_webhook.value
+    ITOC_TESTING_EMAIL_ADDRESS    = data.aws_ssm_parameter.itoc_feedback_testing_email_address.value
+    ITOC_TESTING_CHANNEL_ID       = data.aws_ssm_parameter.itoc_feedback_testing_slack_channel_id.value
+    ITOC_TESTING_SLACK_BOT_TOKEN  = data.aws_ssm_parameter.itoc_feedback_testing_slack_bot_token.value
   }
   depends_on = [
     aws_api_gateway_rest_api.ndr_doc_store_api,