[NDR-194] Resolve TF warnings relating to S3 lifecycle rules (#358)

* [NDR-194] adding empty filter block

* [NDR-194] adding days to lifecycle cofnig

---------

Co-authored-by: Sam Whyte <[email protected]>

Author: SWhyteAnswer

infrastructure/buckets.tf

@@ -139,7 +139,9 @@ resource "aws_s3_bucket_lifecycle_configuration" "lg-lifecycle-rules" {
     status = "Enabled"
     transition {
       storage_class = "INTELLIGENT_TIERING"
+      days          = 0
     }
+    filter {}
   }
 }
 
@@ -150,7 +152,9 @@ resource "aws_s3_bucket_lifecycle_configuration" "doc-store-lifecycle-rules" {
     status = "Enabled"
     transition {
       storage_class = "INTELLIGENT_TIERING"
+      days          = 0
     }
+    filter {}
   }
 }
 
@@ -173,7 +177,9 @@ resource "aws_s3_bucket_lifecycle_configuration" "staging-store-lifecycle-rules"
     status = "Enabled"
     transition {
       storage_class = "INTELLIGENT_TIERING"
+      days          = 0
     }
+    filter {}
   }
 }
 
@@ -186,6 +192,20 @@ resource "aws_s3_bucket_lifecycle_configuration" "ndr-zip-request-store-lifecycl
     expiration {
       days = 1
     }
+    filter {}
+  }
+}
+
+resource "aws_s3_bucket_lifecycle_configuration" "pdm_document_store" {
+  bucket = module.pdm-document-store.bucket_id
+  rule {
+    id     = "default-to-intelligent-tiering"
+    status = "Enabled"
+    transition {
+      storage_class = "INTELLIGENT_TIERING"
+      days          = 0
+    }
+    filter {}
   }
 }
 
@@ -353,14 +373,3 @@ module "pdm-document-store" {
   owner                    = var.owner
   force_destroy            = local.is_force_destroy
 }
-
-resource "aws_s3_bucket_lifecycle_configuration" "pdm_document_store" {
-  bucket = module.pdm-document-store.bucket_id
-  rule {
-    id     = "default-to-intelligent-tiering"
-    status = "Enabled"
-    transition {
-      storage_class = "INTELLIGENT_TIERING"
-    }
-  }
-}

infrastructure/modules/ecr/README.md

@@ -49,7 +49,6 @@ module "ecr_repository" {
 |------|-------------|------|---------|:--------:|
 | <a name="input_allow_force_destroy"></a> [allow\_force\_destroy](#input\_allow\_force\_destroy) | Enable force destroy of the ECR module | `bool` | `false` | no |
 | <a name="input_app_name"></a> [app\_name](#input\_app\_name) | Name of the application (used in repository naming). | `string` | n/a | yes |
-| <a name="input_current_account_id"></a> [current\_account\_id](#input\_current\_account\_id) | n/a | `string` | n/a | yes |
 | <a name="input_environment"></a> [environment](#input\_environment) | Deployment environment tag used for naming and labeling (e.g., dev, prod). | `string` | n/a | yes |
 | <a name="input_owner"></a> [owner](#input\_owner) | Identifies the team or person responsible for the resource (used for tagging). | `string` | n/a | yes |
 ## Outputs