Skip to content

Commit 9a695ae

Browse files
committed
[PRMP-1318] IAM policies in im-alerting-lambda
Signed-off-by: NogaNHS <[email protected]>
1 parent adcee05 commit 9a695ae

File tree

4 files changed

+34
-4
lines changed

4 files changed

+34
-4
lines changed

infrastructure/lambda-back-channel-logout.tf

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ module "back_channel_logout_lambda" {
3636
}
3737
depends_on = [
3838
aws_api_gateway_rest_api.ndr_doc_store_api,
39-
aws_iam_policy.ssm_access_policy,
4039
module.auth_session_dynamodb_table,
4140
module.back-channel-logout-gateway,
4241
module.ndr-app-config

infrastructure/lambda-bulk-upload.tf

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ module "bulk-upload-lambda" {
5454
module.ndr-lloyd-george-store,
5555
module.lloyd_george_reference_dynamodb_table,
5656
module.bulk_upload_report_dynamodb_table,
57-
aws_iam_policy.ssm_access_policy,
5857
module.lg-bulk-upload-expedite-metadata-queue,
5958
]
6059
}

infrastructure/lambda-im-alerting.tf

Lines changed: 24 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@ module "im-alerting-lambda" {
2020
handler = "handlers.im_alerting_handler.lambda_handler"
2121
iam_role_policy_documents = [
2222
local.ssm_access_policy.policy,
23-
aws_iam_policy.alerting_lambda_alarms.policy,
24-
aws_iam_policy.alerting_lambda_tags.policy,
23+
local.alerting_lambda_alarms_policy.policy,
24+
local.alerting_lambda_tags_policy.policy,
2525
module.ndr-app-config.app_config_policy,
2626
module.alarm_state_history_table.dynamodb_read_policy_document,
2727
module.alarm_state_history_table.dynamodb_write_policy_document
@@ -47,6 +47,7 @@ module "im-alerting-lambda" {
4747

4848

4949
resource "aws_iam_policy" "alerting_lambda_alarms" {
50+
count = local.is_sandbox ? 0 : 1
5051
name = "${terraform.workspace}_alerting_lambda_alarms_policy"
5152
description = "Alarms policy to allow lambda to describe all alarms"
5253
policy = jsonencode({
@@ -65,6 +66,7 @@ resource "aws_iam_policy" "alerting_lambda_alarms" {
6566
}
6667

6768
resource "aws_iam_policy" "alerting_lambda_tags" {
69+
count = local.is_sandbox ? 0 : 1
6870
name = "${terraform.workspace}_alerting_lambda_tags_policy"
6971
description = "Tags policy to allow alerting lambda to get resources by tags"
7072
policy = jsonencode({
@@ -80,3 +82,23 @@ resource "aws_iam_policy" "alerting_lambda_tags" {
8082
})
8183
}
8284

85+
data "aws_iam_policy" "dev_environment_alerting_lambda_alarms" {
86+
count = local.is_sandbox ? 1 : 0
87+
name = "${var.shared_infra_workspace}_alerting_lambda_alarms_policy"
88+
}
89+
90+
data "aws_iam_policy" "dev_environment_alerting_lambda_tags" {
91+
count = local.is_sandbox ? 1 : 0
92+
name = "${var.shared_infra_workspace}_alerting_lambda_tags_policy"
93+
}
94+
95+
locals {
96+
alerting_lambda_alarms_policy = local.is_sandbox ? (
97+
data.aws_iam_policy.dev_environment_alerting_lambda_alarms[0]
98+
) : aws_iam_policy.alerting_lambda_alarms[0]
99+
100+
alerting_lambda_tags_policy = local.is_sandbox ? (
101+
data.aws_iam_policy.dev_environment_alerting_lambda_tags[0]
102+
) : aws_iam_policy.alerting_lambda_tags[0]
103+
}
104+

infrastructure/moved-resources-v1.6.11.tf

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,3 +23,13 @@ moved {
2323
to = aws_iam_policy.mtls_access_ssm_policy[0]
2424
}
2525

26+
moved {
27+
from = aws_iam_policy.alerting_lambda_alarms
28+
to = aws_iam_policy.alerting_lambda_alarms[0]
29+
}
30+
31+
moved {
32+
from = aws_iam_policy.alerting_lambda_tags
33+
to = aws_iam_policy.alerting_lambda_tags[0]
34+
}
35+

0 commit comments

Comments
 (0)