pr comments

Author: adamwhitingnhs

infrastructure/gateway-document-reference.tf

@@ -36,4 +36,6 @@ module "document_reference_id_gateway" {
   request_parameters = {
     "method.request.path.id" = true
   }
+
+  depends_on = [module.document_reference_gateway]
 }

infrastructure/lambda-get-doc-ref.tf

@@ -43,18 +43,16 @@ module "get-doc-ref-lambda" {
   name    = "GetDocRefLambda"
   handler = "handlers.get_document_reference_handler.lambda_handler"
   iam_role_policy_documents = [
-    module.ndr-lloyd-george-store.s3_write_policy_document,
     module.ndr-lloyd-george-store.s3_read_policy_document,
-    module.lloyd_george_reference_dynamodb_table.dynamodb_write_policy_document,
     module.lloyd_george_reference_dynamodb_table.dynamodb_read_policy_document,
     aws_iam_policy.ssm_access_policy.policy,
     module.ndr-app-config.app_config_policy,
+    module.cloudfront_edge_dynamodb_table.dynamodb_write_policy_document
   ]
   kms_deletion_window = var.kms_deletion_window
   rest_api_id         = aws_api_gateway_rest_api.ndr_doc_store_api.id
   resource_id         = module.document_reference_id_gateway.gateway_resource_id
   http_methods        = ["GET"]
-  memory_size         = 512
 
   api_execution_arn = aws_api_gateway_rest_api.ndr_doc_store_api.execution_arn
   lambda_environment_variables = {
@@ -69,13 +67,8 @@ module "get-doc-ref-lambda" {
     CLOUDFRONT_URL             = module.cloudfront-distribution-lg.cloudfront_url
   }
   depends_on = [
-    module.document_reference_gateway,
     aws_api_gateway_rest_api.ndr_doc_store_api,
-    module.lloyd_george_reference_dynamodb_table,
-    module.ndr-lloyd-george-store,
-    module.ndr-app-config,
     module.cloudfront-distribution-lg,
-    module.cloudfront_edge_dynamodb_table,
     module.document_reference_id_gateway
   ]
 }

infrastructure/lambda-update-doc-ref.tf

@@ -58,7 +58,6 @@ module "update-doc-ref-lambda" {
   rest_api_id         = aws_api_gateway_rest_api.ndr_doc_store_api.id
   resource_id         = module.document_reference_id_gateway.gateway_resource_id
   http_methods        = ["PUT"]
-  memory_size         = 512
 
   api_execution_arn = aws_api_gateway_rest_api.ndr_doc_store_api.execution_arn
   lambda_environment_variables = {

infrastructure/moved-resources.tf

@@ -1,4 +1,4 @@
-#PRMP-594
+#release V1.6.7
 moved {
   from = module.update_doc_ref_lambda
   to   = module.update-doc-ref-lambda