[PRMP-557] amend typo, add environment check for env var

steph-torres-nhs · steph-torres-nhs · commit aa3387c65dc3 · 2025-10-21T16:36:42.000+01:00
diff --git a/infrastructure/lambda-im-alerting.tf b/infrastructure/lambda-im-alerting.tf
@@ -39,7 +39,7 @@ module "im-alerting-lambda" {
     ALARM_HISTORY_DYNAMODB_NAME = module.alarm_state_history_table.table_name
     SLACK_CHANNEL_ID            = data.aws_ssm_parameter.slack_alerting_channel_id.value
     SLACK_BOT_TOKEN             = data.aws_ssm_parameter.slack_alerting_bot_token.value
-    VIRUS_SCANNER_TOPIC_ARN     = module.cloud_storage_security[0].proactive_notification_topic_arn
+    VIRUS_SCANNER_TOPIC_ARN     = local.is_production ? module.cloud_storage_security[0].proactive_notification_topic_arn : ""
   }
   is_gateway_integration_needed = false
   is_invoked_from_gateway       = false
diff --git a/infrastructure/virusscanner.tf b/infrastructure/virusscanner.tf
@@ -114,7 +114,7 @@ resource "aws_sns_topic_subscription" "virus_scanner_im_alerting" {
   })
 }
 
-resource "aws_lambda_permission" "virsu_scanner_iam_alerting" {
+resource "aws_lambda_permission" "virus_scanner_im_alerting" {
   action        = "lambda:InvokeFunction"
   function_name = module.im-alerting-lambda.lambda_arn
   principal     = "sns.amzamonaws.com"

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ module "im-alerting-lambda" {`
`39`	`39`	`ALARM_HISTORY_DYNAMODB_NAME = module.alarm_state_history_table.table_name`
`40`	`40`	`SLACK_CHANNEL_ID = data.aws_ssm_parameter.slack_alerting_channel_id.value`
`41`	`41`	`SLACK_BOT_TOKEN = data.aws_ssm_parameter.slack_alerting_bot_token.value`
`42`		`- VIRUS_SCANNER_TOPIC_ARN = module.cloud_storage_security[0].proactive_notification_topic_arn`
	`42`	`+ VIRUS_SCANNER_TOPIC_ARN = local.is_production ? module.cloud_storage_security[0].proactive_notification_topic_arn : ""`
`43`	`43`	`}`
`44`	`44`	`is_gateway_integration_needed = false`
`45`	`45`	`is_invoked_from_gateway = false`
Original file line number	Diff line number	Diff line change
`@@ -114,7 +114,7 @@ resource "aws_sns_topic_subscription" "virus_scanner_im_alerting" {`
`114`	`114`	`})`
`115`	`115`	`}`
`116`	`116`
`117`		`-resource "aws_lambda_permission" "virsu_scanner_iam_alerting" {`
	`117`	`+resource "aws_lambda_permission" "virus_scanner_im_alerting" {`
`118`	`118`	`action = "lambda:InvokeFunction"`
`119`	`119`	`function_name = module.im-alerting-lambda.lambda_arn`
`120`	`120`	`principal = "sns.amzamonaws.com"`