[PRMP-579] attempt to fix logging_config error

steph-torres-nhs · steph-torres-nhs · commit b3f050d09e76 · 2025-10-29T12:27:15.000Z
diff --git a/infrastructure/cloudfront.tf b/infrastructure/cloudfront.tf
@@ -19,4 +19,5 @@ module "cloudfront-distribution-lg" {
   secondary_bucket_domain_name  = module.ndr-document-pending-review-store.bucket_regional_domain_name
   secondary_bucket_id           = module.ndr-document-pending-review-store.bucket_id
   secondary_bucket_path_pattern = "/review/*"
+  log_bucket_id                 = local.access_logs_bucket_id
 }
diff --git a/infrastructure/modules/cloudfront/main.tf b/infrastructure/modules/cloudfront/main.tf
@@ -98,6 +98,12 @@ resource "aws_cloudfront_distribution" "distribution_with_secondary_bucket" {
 
   }
 
+  logging_config {
+    bucket = var.log_bucket_id
+    # this might break it as path pattern is in format /pattern/
+    prefix = var.secondary_bucket_path_pattern
+  }
+
   viewer_certificate {
     cloudfront_default_certificate = true
   }
diff --git a/infrastructure/modules/cloudfront/variable.tf b/infrastructure/modules/cloudfront/variable.tf
@@ -39,3 +39,8 @@ variable "secondary_bucket_path_pattern" {
   type        = string
 }
 
+variable "log_bucket_id" {
+  description = "The bucket ID to send access logs to"
+  type        = string
+}
+

Original file line number	Diff line number	Diff line change
`@@ -19,4 +19,5 @@ module "cloudfront-distribution-lg" {`
`19`	`19`	`secondary_bucket_domain_name = module.ndr-document-pending-review-store.bucket_regional_domain_name`
`20`	`20`	`secondary_bucket_id = module.ndr-document-pending-review-store.bucket_id`
`21`	`21`	`secondary_bucket_path_pattern = "/review/*"`
	`22`	`+ log_bucket_id = local.access_logs_bucket_id`
`22`	`23`	`}`
Original file line number	Diff line number	Diff line change
`@@ -98,6 +98,12 @@ resource "aws_cloudfront_distribution" "distribution_with_secondary_bucket" {`
`98`	`98`
`99`	`99`	`}`
`100`	`100`
	`101`	`+ logging_config {`
	`102`	`+ bucket = var.log_bucket_id`
	`103`	`+ # this might break it as path pattern is in format /pattern/`
	`104`	`+ prefix = var.secondary_bucket_path_pattern`
	`105`	`+ }`
	`106`	`+`
`101`	`107`	`viewer_certificate {`
`102`	`108`	`cloudfront_default_certificate = true`
`103`	`109`	`}`
Original file line number	Diff line number	Diff line change
`@@ -39,3 +39,8 @@ variable "secondary_bucket_path_pattern" {`
`39`	`39`	`type = string`
`40`	`40`	`}`
`41`	`41`
	`42`	`+variable "log_bucket_id" {`
	`43`	`+ description = "The bucket ID to send access logs to"`
	`44`	`+ type = string`
	`45`	`+}`
	`46`	`+`