Skip to content

Commit bb9111a

Browse files
committed
Conditionalize DynamoDB access in document review modules for non-production environments
Signed-off-by: NogaNHS <[email protected]>
1 parent 8bd0ee9 commit bb9111a

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

infrastructure/lambda-get-document-review.tf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ module "get_document_review_lambda" {
66
module.ndr-app-config.app_config_policy,
77
module.cloudfront_edge_dynamodb_table.dynamodb_read_policy_document,
88
module.cloudfront_edge_dynamodb_table.dynamodb_write_policy_document,
9-
module.document_review_dynamodb_table.dynamodb_read_policy_document,
9+
local.is_production ? "" : module.document_review_dynamodb_table[0].dynamodb_read_policy_document,
1010
aws_iam_policy.ssm_access_policy.policy
1111
]
1212

@@ -21,7 +21,7 @@ module "get_document_review_lambda" {
2121
APPCONFIG_APPLICATION = module.ndr-app-config.app_config_application_id
2222
APPCONFIG_ENVIRONMENT = module.ndr-app-config.app_config_environment_id
2323
APPCONFIG_CONFIGURATION = module.ndr-app-config.app_config_configuration_profile_id
24-
DOCUMENT_REVIEW_DYNAMODB_NAME = module.document_review_dynamodb_table.table_name
24+
DOCUMENT_REVIEW_DYNAMODB_NAME = local.is_production ? "" : module.document_review_dynamodb_table[0].table_name
2525
EDGE_REFERENCE_TABLE = module.cloudfront_edge_dynamodb_table.table_name
2626
CLOUDFRONT_URL = module.cloudfront-distribution-lg.cloudfront_url
2727
PRESIGNED_ASSUME_ROLE = aws_iam_role.get_document_review_presign.arn

infrastructure/lambda-put-document-review.tf renamed to infrastructure/lambda-patch-document-review.tf

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ module "patch_document_review_lambda" {
44
handler = "handlers.patch_document_review_handler.lambda_handler"
55
iam_role_policy_documents = [
66
module.ndr-app-config.app_config_policy,
7-
module.document_review_dynamodb_table.dynamodb_write_policy_document,
8-
module.document_review_dynamodb_table.dynamodb_read_policy_document,
7+
local.is_production ? "" : module.document_review_dynamodb_table[0].dynamodb_write_policy_document,
8+
local.is_production ? "" : module.document_review_dynamodb_table[0].dynamodb_read_policy_document,
99
aws_iam_policy.ssm_access_policy.policy,
1010
]
1111

@@ -20,7 +20,7 @@ module "patch_document_review_lambda" {
2020
APPCONFIG_APPLICATION = module.ndr-app-config.app_config_application_id
2121
APPCONFIG_ENVIRONMENT = module.ndr-app-config.app_config_environment_id
2222
APPCONFIG_CONFIGURATION = module.ndr-app-config.app_config_configuration_profile_id
23-
DOCUMENT_REVIEW_DYNAMODB_NAME = module.document_review_dynamodb_table.table_name
23+
DOCUMENT_REVIEW_DYNAMODB_NAME = local.is_production ? "" : module.document_review_dynamodb_table[0].table_name
2424
WORKSPACE = terraform.workspace
2525
}
2626
depends_on = [

infrastructure/lambda-search-document-review.tf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ module "search_document_review_lambda" {
44
handler = "handlers.search_document_review_handler.lambda_handler"
55
iam_role_policy_documents = [
66
module.ndr-app-config.app_config_policy,
7-
module.document_review_dynamodb_table.dynamodb_read_policy_document,
7+
local.is_production ? "" : module.document_review_dynamodb_table[0].dynamodb_read_policy_document,
88
aws_iam_policy.ssm_access_policy.policy
99
]
1010

@@ -19,7 +19,7 @@ module "search_document_review_lambda" {
1919
APPCONFIG_APPLICATION = module.ndr-app-config.app_config_application_id
2020
APPCONFIG_ENVIRONMENT = module.ndr-app-config.app_config_environment_id
2121
APPCONFIG_CONFIGURATION = module.ndr-app-config.app_config_configuration_profile_id
22-
DOCUMENT_REVIEW_DYNAMODB_NAME = module.document_review_dynamodb_table.table_name
22+
DOCUMENT_REVIEW_DYNAMODB_NAME = local.is_production ? "" : module.document_review_dynamodb_table[0].table_name
2323
WORKSPACE = terraform.workspace
2424

2525

0 commit comments

Comments
 (0)