Skip to content

Commit bed0572

Browse files
refactor: Remove redundant comments
1 parent 0d420a1 commit bed0572

File tree

5 files changed

+5
-17
lines changed

5 files changed

+5
-17
lines changed

infrastructure/dev.tfvars

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,4 @@ apim_environment = "internal-dev."
1313

1414
kms_deletion_window = 7
1515

16-
# SSH Key Management
17-
ssh_key_management_dry_run = true # Enable dry-run for dev environment
16+
ssh_key_management_dry_run = true

infrastructure/lambda-transfer-key-manager.tf

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
1-
# Transfer Key Manager Lambda for SSH Key Expiry Management
21
module "transfer-key-manager-lambda" {
32
source = "./modules/lambda"
43
name = "TransferKeyManagerLambda"
54
handler = "handlers.transfer_key_manager_handler.lambda_handler"
6-
lambda_timeout = 300 # 5 minutes - needed for iterating through all Transfer Family servers/users
5+
lambda_timeout = 300
76

87
iam_role_policy_documents = [
98
data.aws_iam_policy_document.transfer_key_manager_policy.json,
@@ -27,14 +26,11 @@ module "transfer-key-manager-lambda" {
2726
is_invoked_from_gateway = false
2827
}
2928

30-
# SSM Parameter for PRM Mailbox Email
3129
data "aws_ssm_parameter" "prm_mailbox_email" {
3230
name = "/prs/${var.environment}/user-input/prm-mailbox-email"
3331
}
3432

35-
# IAM Policy for Transfer Key Manager Lambda
3633
data "aws_iam_policy_document" "transfer_key_manager_policy" {
37-
# AWS Transfer Family permissions
3834
statement {
3935
sid = "TransferFamilyAccess"
4036
effect = "Allow"
@@ -47,7 +43,6 @@ data "aws_iam_policy_document" "transfer_key_manager_policy" {
4743
resources = ["*"]
4844
}
4945

50-
# SES permissions for sending notifications
5146
statement {
5247
sid = "SESAccess"
5348
effect = "Allow"
@@ -63,7 +58,6 @@ data "aws_iam_policy_document" "transfer_key_manager_policy" {
6358
}
6459
}
6560

66-
# CloudWatch metrics permissions
6761
statement {
6862
sid = "CloudWatchMetrics"
6963
effect = "Allow"
@@ -79,7 +73,6 @@ data "aws_iam_policy_document" "transfer_key_manager_policy" {
7973
}
8074
}
8175

82-
# CloudWatch Alarms for Transfer Key Manager Lambda
8376
module "transfer-key-manager-alarm" {
8477
source = "./modules/lambda_alarms"
8578
lambda_function_name = module.transfer-key-manager-lambda.function_name
@@ -91,7 +84,6 @@ module "transfer-key-manager-alarm" {
9184
depends_on = [module.transfer-key-manager-lambda, module.transfer-key-manager-alarm-topic]
9285
}
9386

94-
# SNS Topic for Transfer Key Manager Alarms
9587
module "transfer-key-manager-alarm-topic" {
9688
source = "./modules/sns"
9789
sns_encryption_key_id = module.sns_encryption_key.id

infrastructure/preprod.tfvars

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ cloud_security_email_param_environment = "pre-prod"
1111

1212
apim_environment = "int."
1313

14-
# SSH Key Management
15-
ssh_key_management_dry_run = false # Disable dry-run for preprod (test real deletion)
14+
ssh_key_management_dry_run = false
1615

1716
deletion_protection_enabled = true

infrastructure/prod.tfvars

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ cloud_security_email_param_environment = "prod"
1111

1212
apim_environment = ""
1313

14-
# SSH Key Management
15-
ssh_key_management_dry_run = false # Disable dry-run for production
14+
ssh_key_management_dry_run = false
1615

1716
deletion_protection_enabled = true

infrastructure/test.tfvars

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,4 @@ cloud_security_email_param_environment = "ndr-test"
1111

1212
apim_environment = "internal-qa."
1313

14-
# SSH Key Management
15-
ssh_key_management_dry_run = true # Enable dry-run for test environment
14+
ssh_key_management_dry_run = true

0 commit comments

Comments
 (0)