[PRMP-579] refactor policies

Author: steph-torres-nhs

infrastructure/modules/cloudfront/README.md

@@ -49,11 +49,9 @@ module "cloudfront" {
 
 | Name | Description | Type | Default | Required |
 |------|-------------|------|---------|:--------:|
-| <a name="input_access_log_bucket"></a> [access\_log\_bucket](#input\_access\_log\_bucket) | Bucket to store access logs | `string` | n/a | yes |
 | <a name="input_bucket_domain_name"></a> [bucket\_domain\_name](#input\_bucket\_domain\_name) | Domain name to assign CloudFront distribution to. | `string` | n/a | yes |
 | <a name="input_bucket_id"></a> [bucket\_id](#input\_bucket\_id) | Bucket ID to assign CloudFront distribution to. | `string` | n/a | yes |
 | <a name="input_has_secondary_bucket"></a> [has\_secondary\_bucket](#input\_has\_secondary\_bucket) | Whether distribution is associated with a secondary buckets | `bool` | n/a | yes |
-| <a name="input_log_prefix"></a> [log\_prefix](#input\_log\_prefix) | Prefix to store access logs under | `string` | n/a | yes |
 | <a name="input_qualifed_arn"></a> [qualifed\_arn](#input\_qualifed\_arn) | Lambda@Edge function association. | `string` | n/a | yes |
 | <a name="input_secondary_bucket_domain_name"></a> [secondary\_bucket\_domain\_name](#input\_secondary\_bucket\_domain\_name) | Secondary bucket domain names | `string` | n/a | yes |
 | <a name="input_secondary_bucket_id"></a> [secondary\_bucket\_id](#input\_secondary\_bucket\_id) | Secondary bucket IDs | `string` | n/a | yes |

infrastructure/modules/lambda_edge/main.tf

@@ -75,11 +75,6 @@ resource "aws_iam_role_policy" "lambda_exec_policy" {
 }
 
 
-resource "aws_iam_role" "lambda_execution_role" {
-  name               = "${terraform.workspace}_lambda_execution_role_${var.name}"
-  assume_role_policy = data.aws_iam_policy_document.assume_role.json
-}
-
 data "aws_iam_policy_document" "merged_policy" {
   source_policy_documents = concat(var.iam_role_policy_documents)
 }
@@ -91,11 +86,11 @@ resource "aws_iam_policy" "combined_policies" {
 
 resource "aws_iam_role_policy_attachment" "default_policies" {
   for_each   = toset(var.default_policies)
-  role       = aws_iam_role.lambda_execution_role.name
+  role       = aws_iam_role.lambda_exec_role.name
   policy_arn = each.value
 }
 
 resource "aws_iam_role_policy_attachment" "lambda_execution_policy" {
-  role       = aws_iam_role.lambda_execution_role.name
+  role       = aws_iam_role.lambda_exec_role.name
   policy_arn = aws_iam_policy.combined_policies.arn
 }