Removed unnecessary locals

Author: chrisbloe

infrastructure/cloudwatch_rum.tf

@@ -41,7 +41,7 @@ resource "aws_iam_policy" "cloudwatch_rum_cognito_access" {
         {
           "Effect" : "Allow",
           "Action" : "rum:PutRumEvents",
-          "Resource" : "arn:aws:rum:${local.current_region}:${local.current_account_id}:appmonitor/${aws_rum_app_monitor.ndr[0].id}"
+          "Resource" : "arn:aws:rum:${data.aws_region.current.region}:${data.aws_caller_identity.current.account_id}:appmonitor/${aws_rum_app_monitor.ndr[0].id}"
         }
       ]
   })
@@ -65,7 +65,7 @@ resource "aws_cloudwatch_log_resource_policy" "rum_log" {
           "logs:DeleteLogGroup",
           "logs:DescribeLogGroups"
         ],
-        Resource = "arn:aws:logs:${local.current_region}:${local.current_account_id}:log-group:/aws/vendedlogs/RUMService-*"
+        Resource = "arn:aws:logs:${data.aws_region.current.region}:${data.aws_caller_identity.current.account_id}:log-group:/aws/vendedlogs/RUMService-*"
       }
     ]
   })

infrastructure/lambda-send-feedback.tf

@@ -104,7 +104,7 @@ resource "aws_iam_policy" "ses_send_email_policy" {
           "ses:SendEmail",
         ],
         Resource = [
-          "arn:aws:ses:${local.current_region}:${local.current_account_id}:identity/*",
+          "arn:aws:ses:${data.aws_region.current.region}:${data.aws_caller_identity.current.account_id}:identity/*",
         ]
       }
     ]

infrastructure/variable.tf

@@ -203,9 +203,6 @@ locals {
   api_gateway_subdomain_name   = contains(["prod"], terraform.workspace) ? "${var.certificate_subdomain_name_prefix}" : "${var.certificate_subdomain_name_prefix}${terraform.workspace}"
   api_gateway_full_domain_name = contains(["prod"], terraform.workspace) ? "${var.certificate_subdomain_name_prefix}${var.domain}" : "${var.certificate_subdomain_name_prefix}${terraform.workspace}.${var.domain}"
 
-  current_region     = data.aws_region.current.name
-  current_account_id = data.aws_caller_identity.current.account_id
-
   apim_api_url = "https://${var.apim_environment}api.service.nhs.uk/national-document-repository"
 }