Rename document review DynamoDB table to document upload review and update references in Lambda functions

NogaNHS · NogaNHS · commit e23be34004af · 2025-11-25T15:25:21.000Z
Signed-off-by: NogaNHS &lt;127490765+NogaNHS@users.noreply.github.com&gt;
diff --git a/infrastructure/dynamo_db_review.tf b/infrastructure/dynamo_db_review.tf
@@ -1,5 +1,4 @@
 module "document_upload_review_dynamodb_table" {
-  count                          = local.is_production ? 0 : 1
   source                         = "./modules/dynamo_db"
   table_name                     = var.document_review_table_name
   hash_key                       = "ID"
diff --git a/infrastructure/lambda-document-review-processor.tf b/infrastructure/lambda-document-review-processor.tf
@@ -5,8 +5,8 @@ module "document_review_processor_lambda" {
   iam_role_policy_documents = [
     module.document_review_queue.sqs_read_policy_document,
     module.document_review_queue.sqs_write_policy_document,
-    local.is_production ? "" : module.document_review_dynamodb_table[0].dynamodb_read_policy_document,
-    local.is_production ? "" : module.document_review_dynamodb_table[0].dynamodb_write_policy_document,
+    module.document_upload_review_dynamodb_table.dynamodb_read_policy_document,
+    module.document_upload_review_dynamodb_table.dynamodb_write_policy_document,
     module.ndr-bulk-staging-store.s3_read_policy_document,
     module.ndr-bulk-staging-store.s3_write_policy_document,
   ]
@@ -20,7 +20,7 @@ module "document_review_processor_lambda" {
   lambda_environment_variables = {
     PENDING_REVIEW_BUCKET_NAME    = module.ndr-document-pending-review-store.bucket_id
     STAGING_STORE_BUCKET_NAME     = module.ndr-bulk-staging-store.bucket_id
-    DOCUMENT_REVIEW_DYNAMODB_NAME = local.is_production ? "" : module.document_review_dynamodb_table[0].table_name
+    DOCUMENT_REVIEW_DYNAMODB_NAME = module.document_upload_review_dynamodb_table.table_name
     WORKSPACE                     = terraform.workspace
   }
   depends_on = []
diff --git a/infrastructure/lambda-get-document-review.tf b/infrastructure/lambda-get-document-review.tf
@@ -6,7 +6,7 @@ module "get_document_review_lambda" {
     module.ndr-app-config.app_config_policy,
     module.cloudfront_edge_dynamodb_table.dynamodb_read_policy_document,
     module.cloudfront_edge_dynamodb_table.dynamodb_write_policy_document,
-    local.is_production ? "" : module.document_review_dynamodb_table[0].dynamodb_read_policy_document,
+    module.document_upload_review_dynamodb_table.dynamodb_read_policy_document,
     aws_iam_policy.ssm_access_policy.policy,
     module.ndr-document-pending-review-store.s3_read_policy_document
   ]
@@ -22,7 +22,7 @@ module "get_document_review_lambda" {
     APPCONFIG_APPLICATION         = module.ndr-app-config.app_config_application_id
     APPCONFIG_ENVIRONMENT         = module.ndr-app-config.app_config_environment_id
     APPCONFIG_CONFIGURATION       = module.ndr-app-config.app_config_configuration_profile_id
-    DOCUMENT_REVIEW_DYNAMODB_NAME = local.is_production ? "" : module.document_review_dynamodb_table[0].table_name
+    DOCUMENT_REVIEW_DYNAMODB_NAME = module.document_upload_review_dynamodb_table.table_name
     EDGE_REFERENCE_TABLE          = module.cloudfront_edge_dynamodb_table.table_name
     CLOUDFRONT_URL                = module.cloudfront-distribution-lg.cloudfront_url
     PRESIGNED_ASSUME_ROLE         = aws_iam_role.get_document_review_presign.arn
diff --git a/infrastructure/lambda-mns-notification.tf b/infrastructure/lambda-mns-notification.tf
@@ -8,8 +8,8 @@ module "mns-notification-lambda" {
     module.sqs-mns-notification-queue[0].sqs_write_policy_document,
     module.lloyd_george_reference_dynamodb_table.dynamodb_write_policy_document,
     module.lloyd_george_reference_dynamodb_table.dynamodb_read_policy_document,
-    local.is_production ? "" : module.document_upload_review_dynamodb_table[0].dynamodb_write_policy_document,
-    local.is_production ? "" : module.document_upload_review_dynamodb_table[0].dynamodb_read_policy_document,
+    module.document_upload_review_dynamodb_table.dynamodb_write_policy_document,
+    module.document_upload_review_dynamodb_table.dynamodb_read_policy_document,
     aws_iam_policy.ssm_access_policy.policy,
     module.ndr-app-config.app_config_policy,
     aws_iam_policy.kms_mns_lambda_access[0].policy,
@@ -23,7 +23,7 @@ module "mns-notification-lambda" {
     APPCONFIG_CONFIGURATION       = module.ndr-app-config.app_config_configuration_profile_id
     WORKSPACE                     = terraform.workspace
     LLOYD_GEORGE_DYNAMODB_NAME    = module.lloyd_george_reference_dynamodb_table.table_name
-    DOCUMENT_REVIEW_DYNAMODB_NAME = local.is_production ? "" : module.document_upload_review_dynamodb_table[0].table_name
+    DOCUMENT_REVIEW_DYNAMODB_NAME = module.document_upload_review_dynamodb_table.table_name
     MNS_NOTIFICATION_QUEUE_URL    = module.sqs-mns-notification-queue[0].sqs_url
     PDS_FHIR_IS_STUBBED           = local.is_sandbox
   }
diff --git a/infrastructure/lambda-patch-document-review.tf b/infrastructure/lambda-patch-document-review.tf
@@ -4,8 +4,8 @@ module "patch_document_review_lambda" {
   handler = "handlers.patch_document_review_handler.lambda_handler"
   iam_role_policy_documents = [
     module.ndr-app-config.app_config_policy,
-    local.is_production ? "" : module.document_review_dynamodb_table[0].dynamodb_write_policy_document,
-    local.is_production ? "" : module.document_review_dynamodb_table[0].dynamodb_read_policy_document,
+    module.document_upload_review_dynamodb_table.dynamodb_write_policy_document,
+    module.document_upload_review_dynamodb_table.dynamodb_read_policy_document,
     aws_iam_policy.ssm_access_policy.policy,
     module.ndr-document-pending-review-store.s3_write_policy_document
   ]
@@ -21,7 +21,7 @@ module "patch_document_review_lambda" {
     APPCONFIG_APPLICATION         = module.ndr-app-config.app_config_application_id
     APPCONFIG_ENVIRONMENT         = module.ndr-app-config.app_config_environment_id
     APPCONFIG_CONFIGURATION       = module.ndr-app-config.app_config_configuration_profile_id
-    DOCUMENT_REVIEW_DYNAMODB_NAME = local.is_production ? "" : module.document_review_dynamodb_table[0].table_name
+    DOCUMENT_REVIEW_DYNAMODB_NAME = module.document_upload_review_dynamodb_table.table_name
     WORKSPACE                     = terraform.workspace
   }
   depends_on = [
diff --git a/infrastructure/lambda-search-document-review.tf b/infrastructure/lambda-search-document-review.tf
@@ -4,7 +4,7 @@ module "search_document_review_lambda" {
   handler = "handlers.search_document_review_handler.lambda_handler"
   iam_role_policy_documents = [
     module.ndr-app-config.app_config_policy,
-    local.is_production ? "" : module.document_review_dynamodb_table[0].dynamodb_read_policy_document,
+    module.document_upload_review_dynamodb_table.dynamodb_read_policy_document,
     aws_iam_policy.ssm_access_policy.policy
   ]
 
@@ -19,7 +19,7 @@ module "search_document_review_lambda" {
     APPCONFIG_APPLICATION         = module.ndr-app-config.app_config_application_id
     APPCONFIG_ENVIRONMENT         = module.ndr-app-config.app_config_environment_id
     APPCONFIG_CONFIGURATION       = module.ndr-app-config.app_config_configuration_profile_id
-    DOCUMENT_REVIEW_DYNAMODB_NAME = local.is_production ? "" : module.document_review_dynamodb_table[0].table_name
+    DOCUMENT_REVIEW_DYNAMODB_NAME = module.document_upload_review_dynamodb_table.table_name
     WORKSPACE                     = terraform.workspace
   }
   depends_on = [
diff --git a/infrastructure/moved-resources.tf b/infrastructure/moved-resources.tf
@@ -13,8 +13,3 @@ moved {
   from = module.update_doc_ref_alarm_topic
   to   = module.update-doc-ref-alarm-topic
 }
-
-moved {
-  from = module.document_review_dynamodb_table
-  to   = module.document_upload_review_dynamodb_table
-}
diff --git a/infrastructure/variable.tf b/infrastructure/variable.tf
@@ -176,7 +176,7 @@ variable "alarm_state_history_table_name" {
 variable "document_review_table_name" {
   description = "The name of the DynamoDB table to store document review records."
   type        = string
-  default     = "DocumentReview"
+  default     = "DocumentUploadReview"
 }
 # VPC Variables
 

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,4 @@`
`1`	`1`	`module "document_upload_review_dynamodb_table" {`
`2`		`- count = local.is_production ? 0 : 1`
`3`	`2`	`source = "./modules/dynamo_db"`
`4`	`3`	`table_name = var.document_review_table_name`
`5`	`4`	`hash_key = "ID"`
Original file line number	Diff line number	Diff line change
`@@ -13,8 +13,3 @@ moved {`
`13`	`13`	`from = module.update_doc_ref_alarm_topic`
`14`	`14`	`to = module.update-doc-ref-alarm-topic`
`15`	`15`	`}`
`16`		`-`
`17`		`-moved {`
`18`		`- from = module.document_review_dynamodb_table`
`19`		`- to = module.document_upload_review_dynamodb_table`
`20`		`-}`
Original file line number	Diff line number	Diff line change
`@@ -176,7 +176,7 @@ variable "alarm_state_history_table_name" {`
`176`	`176`	`variable "document_review_table_name" {`
`177`	`177`	`description = "The name of the DynamoDB table to store document review records."`
`178`	`178`	`type = string`
`179`		`- default = "DocumentReview"`
	`179`	`+ default = "DocumentUploadReview"`
`180`	`180`	`}`
`181`	`181`	`# VPC Variables`
`182`	`182`