diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS new file mode 100644 index 000000000..aca9dd07d --- /dev/null +++ b/.github/CODEOWNERS @@ -0,0 +1 @@ +* @NHSDigital/patient-record-management @NHSDigital/national-document-repository @NHSDigital/access-store \ No newline at end of file diff --git a/.github/workflows/automated-deploy-dev.yml b/.github/workflows/automated-deploy-dev.yml index ee75029c7..1e04a8f4f 100644 --- a/.github/workflows/automated-deploy-dev.yml +++ b/.github/workflows/automated-deploy-dev.yml @@ -209,7 +209,7 @@ jobs: name: Deploy Lambdas (ndr-dev) needs: ['terraform_plan_apply'] if: github.ref == 'refs/heads/main' - uses: nhsconnect/national-document-repository/.github/workflows/lambdas-dev-to-main-ci.yml@main + uses: NHSDigital/national-document-repository/.github/workflows/lambdas-dev-to-main-ci.yml@main secrets: AWS_ASSUME_ROLE: ${{ secrets.AWS_ASSUME_ROLE }} @@ -217,6 +217,6 @@ jobs: name: Deploy UI (ndr-dev) needs: ['terraform_plan_apply'] if: github.ref == 'refs/heads/main' - uses: nhsconnect/national-document-repository/.github/workflows/ui-dev-to-main-ci.yml@main + uses: NHSDigital/national-document-repository/.github/workflows/ui-dev-to-main-ci.yml@main secrets: AWS_ASSUME_ROLE: ${{ secrets.AWS_ASSUME_ROLE }} diff --git a/.github/workflows/base-cleanup-lambda-edge.yml b/.github/workflows/base-cleanup-lambda-edge.yml index e1feae70a..4438c3b90 100644 --- a/.github/workflows/base-cleanup-lambda-edge.yml +++ b/.github/workflows/base-cleanup-lambda-edge.yml @@ -33,7 +33,7 @@ jobs: - name: Checkout uses: actions/checkout@v5 with: - repository: 'nhsconnect/national-document-repository-infrastructure' + repository: 'NHSDigital/national-document-repository-infrastructure' ref: ${{ inputs.git_ref }} fetch-depth: '0' diff --git a/.github/workflows/base-cleanup-workspace.yml b/.github/workflows/base-cleanup-workspace.yml index bd6a9a9d8..104a1b5ed 100644 --- a/.github/workflows/base-cleanup-workspace.yml +++ b/.github/workflows/base-cleanup-workspace.yml @@ -33,7 +33,7 @@ jobs: - name: Checkout uses: actions/checkout@v5 with: - repository: 'nhsconnect/national-document-repository-infrastructure' + repository: 'NHSDigital/national-document-repository-infrastructure' ref: ${{ inputs.git_ref }} fetch-depth: '0' diff --git a/.github/workflows/cron-daily-health-check.yml b/.github/workflows/cron-daily-health-check.yml index 98a48434b..5c0ed95ad 100644 --- a/.github/workflows/cron-daily-health-check.yml +++ b/.github/workflows/cron-daily-health-check.yml @@ -75,14 +75,14 @@ jobs: run_lambda_unit_tests: name: Run Lambda Unit Tests - uses: nhsconnect/national-document-repository/.github/workflows/base-lambdas-reusable-test.yml@main + uses: NHSDigital/national-document-repository/.github/workflows/base-lambdas-reusable-test.yml@main with: python_version: "3.11" build_branch: main run_ui_unit_tests: name: Run UI Unit Tests - uses: nhsconnect/national-document-repository/.github/workflows/base-vitest-test.yml@main + uses: NHSDigital/national-document-repository/.github/workflows/base-vitest-test.yml@main with: build_branch: main @@ -93,7 +93,7 @@ jobs: - name: Checkout uses: actions/checkout@v5 with: - repository: nhsconnect/national-document-repository + repository: NHSDigital/national-document-repository - name: npm install run: npm install --legacy-peer-deps @@ -153,7 +153,7 @@ jobs: publish_lambda_layers: name: Publish Lambda Layers needs: ['set_workspace', 'terraform_plan_apply'] - uses: nhsconnect/national-document-repository/.github/workflows/base-lambda-layer-reusable-publish-all.yml@main + uses: NHSDigital/national-document-repository/.github/workflows/base-lambda-layer-reusable-publish-all.yml@main with: build_branch: main sandbox: ${{ needs.set_workspace.outputs.workspace }} @@ -164,7 +164,7 @@ jobs: deploy_lambdas: name: Deploy Lambdas - uses: nhsconnect/national-document-repository/.github/workflows/base-lambdas-reusable-deploy-all.yml@main + uses: NHSDigital/national-document-repository/.github/workflows/base-lambdas-reusable-deploy-all.yml@main needs: ['set_workspace', 'publish_lambda_layers'] with: build_branch: main @@ -177,7 +177,7 @@ jobs: deploy_ui: name: Deploy UI - uses: nhsconnect/national-document-repository/.github/workflows/base-deploy-ui.yml@main + uses: NHSDigital/national-document-repository/.github/workflows/base-deploy-ui.yml@main needs: ['terraform_plan_apply', 'set_workspace'] with: build_branch: main diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md new file mode 100644 index 000000000..3911ce449 --- /dev/null +++ b/CONTRIBUTING.md @@ -0,0 +1,23 @@ +# Welcome to the National Document Repository contributors guide + +Thank you for your interest in improving the codebase that powers the National Document Repository. + +In this guide you will get an overview of the contribution workflow from creating a PR, reviewing, and merging the PR. + +To raise an issue, please contact one of the [CODEOWNERS](.github/CODEOWNERS) directly, or raise a PR. + +If you're new to GitHub and/or Markdown, GitHub's own [contributor's guide](https://github.com/github/docs/blob/main/.github/CONTRIBUTING.md) provides good signposting on these topics. + +## Pull requests and merging + +You can't push to the main branch. Therefore, for all changes you will need to create a new branch, and then a pull request to merge said branch into `main`. The [CODEOWNERS](.github/CODEOWNERS) will be nominated as reviewers of your PR by default, but feel free to add other people as well if you think they will have valuable input. + +## Contributing guidelines and etiquette + +- Preview your Markdown code to make sure the format is not broken. +- Check grammar, spelling and punctuation - no-one wants to look pedantic by requesting changes due to typos or inconsistent grammar/syntax, but it's only fair to keep this tidy. +- The codebase is open to the world. This has a few implications: + - Nothing in it should be confidential, private to NHSE or include any personal data. + - All links should be public. + - Consider comments and README.md text: comments in open source repos such as this are not official communications and don't go through the normal approval process for public communication. They can however still be interpreted as official communication, even if not intended as such. +- Use [inclusive language](https://github.com/NHSDigital/software-engineering-quality-framework/blob/main/inclusive-language.md): avoid terms which cause hurt and offence, including if they have historically been considered industry-standard terms. diff --git a/scripts/cleanup_sandboxes.py b/scripts/cleanup_sandboxes.py index d71c65c8c..3a8aac815 100644 --- a/scripts/cleanup_sandboxes.py +++ b/scripts/cleanup_sandboxes.py @@ -4,7 +4,7 @@ def trigger_delete_workflow(token: str, sandbox: str): - owner = "nhsconnect" + owner = "NHSDigital" repo = "national-document-repository-infrastructure" workflow = "tear-down-sandbox.yml" diff --git a/sonar-project.properties b/sonar-project.properties index 1e90c94cc..8e4e63193 100644 --- a/sonar-project.properties +++ b/sonar-project.properties @@ -1,5 +1,5 @@ -sonar.projectKey=prm-repository_infrastructure -sonar.organization=prm-repository +sonar.projectKey=NHSDigital_national-document-repository-infrastructure +sonar.organization=nhsdigital # This is the name and version displayed in the SonarCloud UI. sonar.projectName=Repository-Infrastructure @@ -10,4 +10,4 @@ sonar.projectVersion=1.0 sonar.sources=infrastructure/ # Encoding of the source code. Default is default system encoding -#sonar.sourceEncoding=UTF-8 \ No newline at end of file +#sonar.sourceEncoding=UTF-8