[PRMP-124] Resolved issue DocumentUploadLloydGeorgePreview tests (#782)

* Resolved issue with tests.
Refactor DocumentUploadLloydGeorgePreview to improve rendering logic and ensure state is cleared when no documents are provided.

* removed some unneeded commets

Author: lillie-dae

app/src/components/blocks/_documentUpload/documentUploadLloydGeorgePreview/DocumentUploadLloydGeorgePreview.test.tsx

@@ -1,4 +1,4 @@
-import { render, screen, waitFor } from '@testing-library/react';
+import { act, render, screen, waitFor } from '@testing-library/react';
 import {
     UploadDocument,
     DOCUMENT_TYPE,
@@ -38,15 +38,20 @@ describe('DocumentUploadCompleteStage', () => {
     });
 
     describe('Rendering', () => {
-        it('renders without documents', () => {
-            render(
-                <DocumentUploadLloydGeorgePreview
-                    documents={documents}
-                    setMergedPdfBlob={mockSetMergedPdfBlob}
-                />,
+        it('renders without documents', async () => {
+            vi.mocked(getMergedPdfBlob).mockResolvedValue(
+                new Blob([''], { type: 'application/pdf' }),
             );
 
-            // When no documents are provided, nothing should render
+            await act(async () => {
+                render(
+                    <DocumentUploadLloydGeorgePreview
+                        documents={documents}
+                        setMergedPdfBlob={mockSetMergedPdfBlob}
+                    />,
+                );
+            });
+
             expect(screen.queryByTestId('pdf-viewer')).not.toBeInTheDocument();
         });
 
@@ -55,17 +60,19 @@ describe('DocumentUploadCompleteStage', () => {
             const mockBlob = new Blob(['test pdf content'], { type: 'application/pdf' });
             vi.mocked(getMergedPdfBlob).mockResolvedValue(mockBlob);
 
-            render(
-                <DocumentUploadLloydGeorgePreview
-                    documents={testDocuments}
-                    setMergedPdfBlob={mockSetMergedPdfBlob}
-                />,
-            );
+            await act(async () => {
+                render(
+                    <DocumentUploadLloydGeorgePreview
+                        documents={testDocuments}
+                        setMergedPdfBlob={mockSetMergedPdfBlob}
+                    />,
+                );
+            });
+
+            expect(await screen.findByTestId('pdf-viewer')).toBeInTheDocument();
 
-            // Wait for the PDF merger to complete
             await waitFor(() => {
                 expect(mockSetMergedPdfBlob).toHaveBeenCalledWith(mockBlob);
-                expect(screen.getByTestId('pdf-viewer')).toBeInTheDocument();
             });
         });
     });

app/src/components/blocks/_documentUpload/documentUploadLloydGeorgePreview/DocumentUploadLloydGeorgePreview.tsx

@@ -13,21 +13,23 @@ const DocumentUploadLloydGeorgePreview = ({ documents, setMergedPdfBlob }: Props
 
     const runningRef = useRef(false);
     useEffect(() => {
-        if (!documents || runningRef.current) {
+        // If no docs or effect already running, ensure state cleared and exit
+        if (!documents || documents.length === 0) {
+            if (mergedPdfUrl) {
+                setMergedPdfUrl('');
+            }
             return;
         }
+        if (runningRef.current) return;
 
         runningRef.current = true;
 
         const render = async (): Promise<void> => {
             const blob = await getMergedPdfBlob(documents.map((doc) => doc.file));
-
             setMergedPdfBlob(blob);
-
             const url = URL.createObjectURL(blob);
-
             runningRef.current = false;
-            return setMergedPdfUrl(url);
+            setMergedPdfUrl(url);
         };
 
         render().catch((err) => {