PRMP-643 Refactor document services to use cached environment variables for table names and S3 buckets

Author: NogaNHS

lambdas/services/document_service.py

@@ -21,16 +21,18 @@ class DocumentService:
     def __init__(self):
         self.s3_service = S3Service()
         self.dynamo_service = DynamoDBService()
+        self._lg_table_name = os.getenv("LLOYD_GEORGE_DYNAMODB_NAME")
+        self._lg_s3_bucket = os.getenv("LLOYD_GEORGE_BUCKET_NAME")
 
     @property
     def table_name(self) -> str:
         """DynamoDB table name. Can be overridden by child classes."""
-        return os.getenv("LLOYD_GEORGE_DYNAMODB_NAME")
+        return self._lg_table_name
 
     @property
     def s3_bucket(self) -> str:
         """S3 bucket name. Can be overridden by child classes."""
-        return os.getenv("LLOYD_GEORGE_BUCKET_NAME")
+        return self._lg_s3_bucket
 
     @property
     def model_class(self) -> type[BaseModel]:

lambdas/services/document_upload_review_service.py

@@ -9,18 +9,22 @@
 
 class DocumentUploadReviewService(DocumentService):
     """Service for handling DocumentUploadReviewReference operations."""
+    def __init__(self):
+        super().__init__()
+        self._table_name = os.environ.get("DOCUMENT_REVIEW_DYNAMODB_NAME")
+        self._s3_bucket = os.environ.get("DOCUMENT_REVIEW_S3_BUCKET_NAME")
 
     @property
     def table_name(self) -> str:
-        return os.environ.get("DOCUMENT_REVIEW_DYNAMODB_NAME")
+        return self._table_name
 
     @property
     def model_class(self) -> type:
         return DocumentUploadReviewReference
 
     @property
     def s3_bucket(self) -> str:
-        return os.environ.get("DOCUMENT_REVIEW_S3_BUCKET_NAME")
+        return self._s3_bucket
 
     def update_document_review_custodian(
         self,