[PRME-139] Practice - Patient ODS mismatch error update (#764)

* update error code; fix unit and smoke tests

* fix related missing return types

Author: kamenbachvarov-nhs

app/cypress/e2e/1-ndr-smoke-tests/gp_user_workflows/patient_search_and_verify_unhappy_workflow.cy.js

@@ -24,7 +24,7 @@ describe('GP Workflow: GP Role rejected from accessing a non mating ODS patient
                 // Assert
                 cy.get('#nhs-number-input--error-message', { timeout: 20000 }).should(
                     'include.text',
-                    "You cannot access this patient's record",
+                    "You cannot access this patient's record because they are not registered at your practice. The patient's current practice can access this record if it's stored in this service.",
                 );
             },
         );

app/src/helpers/utils/errorCodes.ts

@@ -39,7 +39,7 @@ const errorCodes: { [key: string]: string } = {
     LGL_423: 'Record is uploading. Wait a few minutes and try again',
     SP_4002: 'The NHS number entered could not be found in the Personal Demographics Service',
     SP_4003:
-        "You cannot access this patient's record because they are not registered at your practice. The patient's current practice can access this record.",
+        "You cannot access this patient's record because they are not registered at your practice. The patient's current practice can access this record if it's stored in this service.",
     UC_4002: 'There was an issue when attempting to virus scan your uploaded files',
     UC_4004: technicalIssueMsg,
 };

app/src/pages/patientSearchPage/PatientSearchPage.test.tsx

@@ -18,18 +18,18 @@ vi.mock('../../helpers/hooks/useBaseAPIHeaders');
 vi.mock('../../helpers/hooks/useRole');
 vi.mock('axios');
 vi.mock('react-router-dom', () => ({
-    useNavigate: () => mockedUseNavigate,
-    useLocation: () => vi.fn(),
+    useNavigate: (): Mock => mockedUseNavigate,
+    useLocation: (): Mock => vi.fn(),
 }));
 vi.mock('../../helpers/hooks/useConfig', () => ({
-    default: () => ({
+    default: (): { featureFlags: { uploadArfWorkflowEnabled: boolean } } => ({
         featureFlags: {
             uploadArfWorkflowEnabled: false,
         },
     }),
 }));
 
-Date.now = () => new Date('2020-01-01T00:00:00.000Z').getTime();
+Date.now = (): number => new Date('2020-01-01T00:00:00.000Z').getTime();
 const mockedAxios = axios as Mocked<typeof axios>;
 const mockedUseRole = useRole as Mock;
 
@@ -154,7 +154,7 @@ describe('PatientSearchPage', () => {
             await userEvent.click(screen.getByRole('button', { name: 'Search' }));
             expect(
                 await screen.findAllByText(
-                    "You cannot access this patient's record because they are not registered at your practice. The patient's current practice can access this record.",
+                    "You cannot access this patient's record because they are not registered at your practice. The patient's current practice can access this record if it's stored in this service.",
                 ),
             ).toHaveLength(2);
         });
@@ -198,7 +198,7 @@ describe('PatientSearchPage', () => {
 
             expect(
                 await screen.findAllByText(
-                    "You cannot access this patient's record because they are not registered at your practice. The patient's current practice can access this record.",
+                    "You cannot access this patient's record because they are not registered at your practice. The patient's current practice can access this record if it's stored in this service.",
                 ),
             ).toHaveLength(2);
         });
@@ -357,7 +357,7 @@ describe('PatientSearchPage', () => {
             await userEvent.click(screen.getByRole('button', { name: 'Search' }));
             expect(
                 await screen.findAllByText(
-                    "You cannot access this patient's record because they are not registered at your practice. The patient's current practice can access this record.",
+                    "You cannot access this patient's record because they are not registered at your practice. The patient's current practice can access this record if it's stored in this service.",
                 ),
             ).toHaveLength(2);
         });
@@ -493,7 +493,7 @@ describe('PatientSearchPage', () => {
     });
 });
 
-const renderPatientSearchPage = () => {
+const renderPatientSearchPage = (): void => {
     const patient: PatientDetails = buildPatientDetails();
     render(
         <ConfigProvider>