Skip to content

Commit 164138e

Browse files
committed
[NDR-359] Remove comments
1 parent 935901f commit 164138e

File tree

2 files changed

+2
-39
lines changed

2 files changed

+2
-39
lines changed

lambdas/services/delete_fhir_document_reference_service.py

Lines changed: 0 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -102,11 +102,6 @@ def delete_fhir_document_references_by_nhs_id(
102102
document_references=documents,
103103
document_ttl_days=DocumentRetentionDays.SOFT_DELETE,
104104
)
105-
# self.delete_document_references(
106-
# table_name=dynamo_table,
107-
# document_references=documents,
108-
# document_ttl_days=DocumentRetentionDays.SOFT_DELETE,
109-
# )
110105
logger.info(
111106
f"Deleted document of type {doc_type.display_name}",
112107
{"Result": "Successful deletion"},
@@ -119,38 +114,6 @@ def delete_fhir_document_references_by_nhs_id(
119114
)
120115
raise DocumentDeletionServiceException(500, LambdaError.DocDelClient)
121116

122-
# def delete_document_references(
123-
# self,
124-
# table_name: str,
125-
# document_references: list[DocumentReference],
126-
# document_ttl_days: int,
127-
# ):
128-
# deletion_date = datetime.now(timezone.utc)
129-
#
130-
# ttl_seconds = document_ttl_days * 24 * 60 * 60
131-
# document_reference_ttl = int(deletion_date.timestamp() + ttl_seconds)
132-
#
133-
# logger.info(f"Deleting items in table: {table_name}")
134-
#
135-
# for reference in document_references:
136-
# reference.doc_status = "deprecated"
137-
# reference.deleted = deletion_date.strftime("%Y-%m-%dT%H:%M:%S.%fZ")
138-
# reference.ttl = document_reference_ttl
139-
#
140-
# update_fields = reference.model_dump(
141-
# by_alias=True,
142-
# exclude_none=True,
143-
# include={"doc_status", "deleted", "ttl"},
144-
# )
145-
# self.dynamo_service.update_item(
146-
# table_name=table_name,
147-
# key_pair={
148-
# DocumentReferenceMetadataFields.NHS_NUMBER.value: reference.nhs_number,
149-
# DocumentReferenceMetadataFields.ID.value: reference.id,
150-
# },
151-
# updated_fields=update_fields,
152-
# )
153-
154117
def _determine_document_type_based_on_common_name(
155118
self, common_name: MtlsCommonNames | None
156119
) -> SnomedCode:

lambdas/tests/unit/services/test_document_service.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -217,11 +217,11 @@ def test_delete_documents_soft_delete_core(mock_service, mock_dynamo_service):
217217
}
218218

219219
mock_service.delete_document_references(
220-
"dev_COREDocument_metadata", [test_doc_ref], DocumentRetentionDays.SOFT_DELETE
220+
"dev_COREDocumentMetadata", [test_doc_ref], DocumentRetentionDays.SOFT_DELETE
221221
)
222222

223223
mock_dynamo_service.update_item.assert_called_once_with(
224-
table_name="dev_COREDocument_metadata",
224+
table_name="dev_COREDocumentMetadata",
225225
key_pair={"ID": test_doc_ref.id, "NhsNumber": test_doc_ref.nhs_number},
226226
updated_fields=test_update_fields,
227227
)

0 commit comments

Comments
 (0)