[PRMP-595] Implement new document screens (#895)

Author: adamwhitingnhs

app/cypress/e2e/0-ndr-core-tests/auth_routes/auth_general_browser_states.cy.js

@@ -50,7 +50,7 @@ describe('Authentication & Authorisation', () => {
             routes.home,
             routes.patientSearch,
             '/patient/verify',
-            '/patient/arf',
+            '/patient/documents',
             '/patient/lloyd-george-record',
             routes.createReport,
             routes.createReportComplete,

app/cypress/e2e/0-ndr-core-tests/auth_routes/auth_gp_admin_path_access.cy.js

@@ -17,9 +17,6 @@ const patient = {
 const baseUrl = Cypress.config('baseUrl');
 const patientVerifyUrl = '/patient/verify';
 const lloydGeorgeViewUrl = '/patient/lloyd-george-record';
-const arfDownloadUrl = '/patient/arf';
-
-const forbiddenRoutes = [arfDownloadUrl];
 
 describe('GP Admin user role has access to the expected GP_ADMIN workflow paths', () => {
     context('GP Admin role has access to expected routes', () => {
@@ -52,19 +49,3 @@ describe('GP Admin user role has access to the expected GP_ADMIN workflow paths'
         });
     });
 });
-
-describe('GP Admin user role cannot access expected forbidden routes', () => {
-    context('GP Admin role has no access to forbidden routes', () => {
-        forbiddenRoutes.forEach((forbiddenRoute) => {
-            it(
-                'GP Admin role cannot access route ' + forbiddenRoute,
-                { tags: 'regression' },
-                () => {
-                    cy.login(Roles.GP_ADMIN);
-                    cy.visit(forbiddenRoute);
-                    cy.url().should('include', 'unauthorised');
-                },
-            );
-        });
-    });
-});

app/cypress/e2e/0-ndr-core-tests/auth_routes/auth_gp_clinical_path_access.cy.js

@@ -17,8 +17,6 @@ const patient = {
 const baseUrl = Cypress.config('baseUrl');
 const patientVerifyUrl = '/patient/verify';
 const lloydGeorgeViewUrl = '/patient/lloyd-george-record';
-const arfDownloadUrl = '/patient/arf';
-const forbiddenRoutes = [arfDownloadUrl];
 
 describe('GP Clinical user role has access to the expected GP_CLINICAL workflow paths', () => {
     context(`GP Clinical role has access to expected routes`, () => {
@@ -50,20 +48,4 @@ describe('GP Clinical user role has access to the expected GP_CLINICAL workflow
             cy.url().should('eq', baseUrl + lloydGeorgeViewUrl);
         });
     });
-});
-
-describe('GP Clinical user role cannot access expected forbidden routes', () => {
-    context('GP Clinical role has no access to forbidden routes', () => {
-        forbiddenRoutes.forEach((forbiddenRoute) => {
-            it(
-                'GP Clinical role cannot access route ' + forbiddenRoute,
-                { tags: 'regression' },
-                () => {
-                    cy.login(Roles.GP_CLINICAL);
-                    cy.visit(forbiddenRoute);
-                    cy.url().should('include', 'unauthorised');
-                },
-            );
-        });
-    });
-});
+});

app/cypress/e2e/0-ndr-core-tests/auth_routes/auth_pcse_path_access.cy.js

@@ -1,5 +1,6 @@
 import { Roles } from '../../../support/roles';
 import { routes } from '../../../support/routes';
+import { DOCUMENT_TYPE } from '../../../../src/helpers/utils/documentType';
 
 const testPatient = '9000000009';
 const patient = {
@@ -16,7 +17,7 @@ const patient = {
 
 const baseUrl = Cypress.config('baseUrl');
 const lloydGeorgeViewUrl = '/patient/lloyd-george-record';
-const arfDownloadUrl = '/patient/arf';
+const documentsUrl = '/patient/documents';
 
 const forbiddenRoutes = [lloydGeorgeViewUrl];
 
@@ -28,6 +29,11 @@ describe('PCSE user role has access to the expected GP_ADMIN workflow paths', ()
                 body: patient,
             }).as('search');
 
+            cy.intercept('GET', '/SearchDocumentReferences*', {
+                statusCode: 200,
+                body: [],
+            }).as('documentSearch');
+
             cy.login(Roles.PCSE);
 
             cy.url().should('eq', baseUrl + routes.home);
@@ -40,7 +46,9 @@ describe('PCSE user role has access to the expected GP_ADMIN workflow paths', ()
             cy.wait('@search');
 
             cy.get('#verify-submit').click();
-            cy.url().should('eq', baseUrl + arfDownloadUrl);
+
+            cy.wait('@documentSearch');
+            cy.url().should('eq', baseUrl + documentsUrl);
         });
     });
 });

app/cypress/e2e/0-ndr-core-tests/feature_flag_workflows/arf_workflow.cy.js

@@ -128,7 +128,7 @@ describe('GP Workflow: View Lloyd George record', () => {
         cy.get('#verify-submit').click();
         cy.wait('@stitchJobCompleted', { timeout: 20000 });
 
-        cy.getByTestId('download-all-files-link').click();
+        cy.getByTestId('download-files-link').click();
     };
 
     context('Download Lloyd George document', () => {
@@ -153,8 +153,8 @@ describe('GP Workflow: View Lloyd George record', () => {
                 cy.wait('@stitchJobCompleted', { timeout: 20000 });
                 cy.title().should('eq', lloydGeorgeRecordPageTitle);
 
-                cy.getByTestId('download-all-files-link', { timeout: 20000 }).should('exist');
-                cy.getByTestId('download-all-files-link').click();
+                cy.getByTestId('download-files-link', { timeout: 20000 }).should('exist');
+                cy.getByTestId('download-files-link').click();
 
                 // Select documents page
                 cy.title().should('eq', downloadPageTitle);
@@ -270,8 +270,8 @@ describe('GP Workflow: View Lloyd George record', () => {
                 cy.wait('@stitchJobCompleted', { timeout: 20000 });
                 cy.title().should('eq', lloydGeorgeRecordPageTitle);
 
-                cy.getByTestId('download-all-files-link').should('exist');
-                cy.getByTestId('download-all-files-link').click();
+                cy.getByTestId('download-files-link').should('exist');
+                cy.getByTestId('download-files-link').click();
 
                 // Select documents page
                 cy.title().should('eq', downloadPageTitle);
@@ -384,7 +384,7 @@ describe('GP Workflow: View Lloyd George record', () => {
                 cy.get('#verify-submit').click();
                 cy.wait('@stitchJobPostEmpty', { timeout: 20000 });
 
-                cy.getByTestId('download-all-files-link').should('not.exist');
+                cy.getByTestId('download-files-link').should('not.exist');
             },
         );
 
@@ -399,7 +399,7 @@ describe('GP Workflow: View Lloyd George record', () => {
                 cy.get('#verify-submit').click();
                 cy.wait('@stitchJobCompleted', { timeout: 20000 });
 
-                cy.getByTestId('download-all-files-link').should('not.exist');
+                cy.getByTestId('download-files-link').should('not.exist');
             },
         );
 
@@ -418,8 +418,8 @@ describe('GP Workflow: View Lloyd George record', () => {
                 cy.get('#verify-submit').click();
                 cy.wait('@stitchJobCompleted', { timeout: 20000 });
 
-                cy.getByTestId('download-all-files-link').should('exist');
-                cy.getByTestId('download-all-files-link').click();
+                cy.getByTestId('download-files-link').should('exist');
+                cy.getByTestId('download-files-link').click();
 
                 cy.wait('@documentManifest');
 

app/cypress/e2e/0-ndr-core-tests/gp_user_workflows/download_lloyd_george_workflow.cy.js

@@ -148,43 +148,6 @@ describe('GP Workflow: Patient search and verify', () => {
         );
     });
 
-    // skipped as arf journey is not viable at this point in time
-    it.skip(
-        `Shows patient upload screen when patient search is used as a
-        GP_ADMIN and patient response is inactive`,
-        { tags: 'regression' },
-        () => {
-            setup(Roles.GP_ADMIN);
-            cy.intercept('GET', '/SearchPatient*', {
-                statusCode: 200,
-                body: patient,
-            }).as('search');
-
-            cy.get('#nhs-number-input').click();
-            cy.get('#nhs-number-input').type(testPatient);
-            cy.title().should(
-                'eq',
-                'Search for a patient - Access and store digital patient documents',
-            );
-
-            cy.get('#search-submit').click();
-            cy.wait('@search');
-            cy.title().should('eq', 'Patient details - Access and store digital patient documents');
-
-            cy.url().should('include', 'verify');
-            cy.url().should('eq', baseUrl + routes.patientVerify);
-            cy.get('#gp-message').should('be.visible');
-            cy.get('#gp-message').should(
-                'have.text',
-                'This page displays the current data recorded in the Personal Demographics Service for this patient.',
-            );
-            cy.get('#verify-submit').click();
-
-            cy.url().should('include', 'upload');
-            cy.url().should('eq', baseUrl + routes.arfUpload);
-        },
-    );
-
     it(
         'Does not show the upload documents page when upload patient is verified and inactive as a GP_Clinical',
         { tags: 'regression' },