changes discussed with Adam

Author: lillie-dae

app/src/components/blocks/_admin/reviewDetailsPage/ReviewDetailsPage.tsx

@@ -183,7 +183,15 @@ const ReviewsDetailsPage = ({ reviewSnoMed }: ReviewsDetailsPageProps): JSX.Elem
                 </PatientSummary>
             </div>
 
-            {!session.isFullscreen ? (
+            {session.isFullscreen ? (
+                <RecordCard
+                    heading={getConfigForDocType(reviewSnoMed).displayName}
+                    fullScreenHandler={setFullScreen}
+                    detailsElement={<RecordLoader {...recordDetailsProps} />}
+                    isFullScreen={session.isFullscreen!}
+                    pdfObjectUrl={hasRecordInStorage ? pdfObjectUrl : ''}
+                />
+            ) : (
                 <div className="lloydgeorge_record-stage_flex">
                     <div
                         className={`lloydgeorge_record-stage_flex-row lloydgeorge_record-stage_flex-row${menuClass}`}
@@ -202,14 +210,6 @@ const ReviewsDetailsPage = ({ reviewSnoMed }: ReviewsDetailsPageProps): JSX.Elem
                         />
                     </div>
                 </div>
-            ) : (
-                <RecordCard
-                    heading={getConfigForDocType(reviewSnoMed).displayName}
-                    fullScreenHandler={setFullScreen}
-                    detailsElement={<RecordLoader {...recordDetailsProps} />}
-                    isFullScreen={session.isFullscreen!}
-                    pdfObjectUrl={hasRecordInStorage ? pdfObjectUrl : ''}
-                />
             )}
 
             <section aria-labelledby="accepting-document" className="pb-6 accepting-document pt-6">

app/src/components/blocks/_admin/reviewDetailsPatientSearchPage/ReviewDetailsPatientSearchPage.tsx

@@ -23,6 +23,7 @@ import BackButton from '../../../generic/backButton/BackButton';
 import SpinnerButton from '../../../generic/spinnerButton/SpinnerButton';
 import ErrorBox from '../../../layout/errorBox/ErrorBox';
 import ServiceError from '../../../layout/serviceErrorBox/ServiceErrorBox';
+import { NHS_NUMBER_PATTERN } from '../../../../helpers/constants/regex';
 
 export const incorrectFormatMessage = "Enter patient's 10 digit NHS number";
 
@@ -51,7 +52,7 @@ const ReviewDetailsPatientSearchPage = ({
     const { ref: nhsNumberRef, ...searchProps } = register('nhsNumber', {
         required: incorrectFormatMessage,
         pattern: {
-            value: /^\s*([0-9]{10}|[0-9]{3}\s[0-9]{3}\s[0-9]{4}|[0-9]{3}-[0-9]{3}-[0-9]{4})\s*$/,
+            value: NHS_NUMBER_PATTERN,
             message: incorrectFormatMessage,
         },
     });
@@ -97,7 +98,7 @@ const ReviewDetailsPatientSearchPage = ({
                 if (error && error.response?.status === 404) {
                     const errorData = error.response?.data as { err_code: string };
                     setInputError(
-                        errorCodes![errorData?.err_code!] ?? 'Sorry, patient data not found.',
+                        errorCodes[errorData?.err_code] ?? 'Sorry, patient data not found.',
                     );
                 } else {
                     setInputError(errorMessage);

app/src/components/blocks/_admin/reviewsPage/ReviewsPage.tsx

@@ -62,7 +62,7 @@ export const ReviewsPage = ({ setSnoMed: setReviewType }: ReviewsPageProps): JSX
                     return newTokens;
                 });
             }
-        } catch (error) {
+        } catch {
             setFailedLoading(true);
             setCurrentPage(1);
             setPageTokens(['']);

app/src/helpers/constants/regex.ts

@@ -0,0 +1,2 @@
+export const NHS_NUMBER_PATTERN =
+    /^\s*(\d{10}|\d{3}\s\d{3}\s\d{4}|\d{3}-\d{3}-\d{4})\s*$/;