[NDR-313] Remove false assertion

Author: megan-bower4

.github/workflows/ndr-e2e-test-sandbox.yml

@@ -40,80 +40,4 @@ jobs:
       environment: ${{ inputs.environment }}
       sandbox: ${{ inputs.sandbox }}
     secrets:
-      AWS_ASSUME_ROLE: ${{ secrets.AWS_ASSUME_ROLE }}
-
-  notify-slack:
-    runs-on: ubuntu-latest
-    environment: ${{ inputs.environment }}
-    needs: [services-e2etest, services-fhir-api-e2etest]
-    if: always()
-    steps:
-      - name: Configure AWS Credentials
-        uses: aws-actions/configure-aws-credentials@v5
-        with:
-          role-to-assume: ${{ secrets.AWS_ASSUME_ROLE }}
-          role-skip-session-tagging: true
-          aws-region: ${{ vars.AWS_REGION }}
-          mask-aws-account-id: true
-
-      - name: Get SSM parameters from SSM
-        id: ssm-parameters
-        run: | 
-          slack_bot_token=$(aws ssm get-parameter --name "/ndr/alerting/slack/bot_token" --with-decryption --query "Parameter.Value" --output text)
-          echo "::add-mask::$slack_bot_token"
-          echo "SLACK_BOT_TOKEN=$slack_bot_token" >> $GITHUB_ENV
-      - name: Send Slack Notification
-        uses: slackapi/[email protected]
-        with:
-          method: chat.postMessage
-          token: ${{ env.SLACK_BOT_TOKEN }}
-          payload: |
-            {
-              "channel": "${{ vars.ALERTS_SLACK_CHANNEL_ID }}",
-              "attachments": [
-                {
-                  "color": "${{ (needs.services-e2etest.result == 'success' && needs.services-fhir-api-e2etest.result == 'success') && '#36a64f' || '#ff0000' }}",
-                  "blocks": [
-                    {
-                      "type": "header",
-                      "text": {
-                        "type": "plain_text",
-                        "text": "${{ (needs.services-e2etest.result == 'success' && needs.services-fhir-api-e2etest.result == 'success') && '✅ Workflow SANDBOX: E2e Tests Backend succeeded' || '❌ Workflow SANDBOX: E2e Tests Backend failed' }}"
-                      }
-                    },
-                    {
-                      "type": "section",
-                      "text": {
-                        "type": "mrkdwn",
-                        "text": "*Triggered by:* `${{ github.actor }}`\n*Branch:* `${{ github.event.pull_request.head.ref || github.ref_name }}`\n*Workflow:* <${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}|${{ github.workflow }}>"
-                      }
-                    },
-                    {
-                      "type": "divider"
-                    },
-                    {
-                      "type": "section",
-                      "fields": [
-                        {
-                          "type": "mrkdwn",
-                          "text": "*services-e2etest:* ${{ needs.services-e2etest.result == 'success' && ':white_check_mark:' || ':x:' }}"
-                        },
-                        {
-                          "type": "mrkdwn",
-                          "text": "*services-fhir-api-e2etest:* ${{ needs.services-fhir-api-e2etest.result == 'success' && ':white_check_mark:' || ':x:' }}"
-                        }
-                      ]
-                    },
-                    {
-                      "type": "context",
-                      "elements": [
-                        {
-                          "type": "mrkdwn",
-                          "text": "Environment: `${{ inputs.environment }}` | Sandbox: `${{ inputs.sandbox }}`"
-                        }
-                      ]
-                    }
-                  ]
-                }
-              ]
-            }
+      AWS_ASSUME_ROLE: ${{ secrets.AWS_ASSUME_ROLE }}

lambdas/tests/e2e/api/fhir/test_retrieve_document_fhir_api.py

@@ -36,8 +36,6 @@ def test_file_retrieval(test_data, file_size):
         )
         assert expected_presign_uri in json["content"][0]["attachment"]["url"]
 
-    assert False
-
 
 @pytest.mark.parametrize(
     "record_id,expected_status,expected_code,expected_diagnostics",